From patchwork Thu Sep 12 06:53:49 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jingoo Han X-Patchwork-Id: 2876381 Return-Path: X-Original-To: patchwork-linux-fbdev@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork1.web.kernel.org (Postfix) with ESMTP id AEBA09F478 for ; Thu, 12 Sep 2013 06:53:54 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id B9B9A2021E for ; Thu, 12 Sep 2013 06:53:53 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id C079D2021C for ; Thu, 12 Sep 2013 06:53:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754165Ab3ILGxw (ORCPT ); Thu, 12 Sep 2013 02:53:52 -0400 Received: from mailout3.samsung.com ([203.254.224.33]:63384 "EHLO mailout3.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753794Ab3ILGxv (ORCPT ); Thu, 12 Sep 2013 02:53:51 -0400 Received: from epcpsbgr2.samsung.com (u142.gpu120.samsung.co.kr [203.254.230.142]) by mailout3.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTP id <0MT000GUP33Q9PI0@mailout3.samsung.com> for linux-fbdev@vger.kernel.org; Thu, 12 Sep 2013 15:53:50 +0900 (KST) Received: from epcpsbgm2.samsung.com ( [203.254.230.50]) by epcpsbgr2.samsung.com (EPCPMTA) with SMTP id C7.1E.17682.EF461325; Thu, 12 Sep 2013 15:53:50 +0900 (KST) X-AuditID: cbfee68e-b7f756d000004512-64-523164fe5591 Received: from epmmp1.local.host ( [203.254.227.16]) by epcpsbgm2.samsung.com (EPCPMTA) with SMTP id E9.2F.05832.DF461325; Thu, 12 Sep 2013 15:53:49 +0900 (KST) Received: from DOJG1HAN03 ([12.23.120.99]) by mmp1.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTPA id <0MT000MKN35PDNB1@mmp1.samsung.com>; Thu, 12 Sep 2013 15:53:49 +0900 (KST) From: Jingoo Han To: 'Jean-Christophe PLAGNIOL-VILLARD' Cc: 'Tomi Valkeinen' , linux-fbdev@vger.kernel.org, 'Jingoo Han' References: <001a01ceaf84$32c52d90$984f88b0$%han@samsung.com> In-reply-to: <001a01ceaf84$32c52d90$984f88b0$%han@samsung.com> Subject: [PATCH 06/21] video: gx1fb: remove unnecessary pci_set_drvdata() Date: Thu, 12 Sep 2013 15:53:49 +0900 Message-id: <002001ceaf84$d5e9b450$81bd1cf0$%han@samsung.com> MIME-version: 1.0 Content-type: text/plain; charset=us-ascii Content-transfer-encoding: 7bit X-Mailer: Microsoft Office Outlook 12.0 Thread-index: Ac6vhDKuTCwbnQ4aTDC9KoLwWMziagAAIqUw Content-language: ko X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFjrDIsWRmVeSWpSXmKPExsVy+t8zI91/KYZBBnc2KFhcXniJ1eJE3wdW i3UPXzBZrJ9/i82BxePVhTssHn1bVjF6HL+xncnj8ya5AJYoLpuU1JzMstQifbsErox3y44x Fhxjr5h04Q1zA+Nati5GTg4JAROJ/SdnQNliEhfurQeyuTiEBJYxSpzY/5ERpmj7ijYWiMQi Ron9B2cxQji/GCXa381lB6liE1CT+PLlMJgtImAnsfDiJVYQm1kgX2LLkjYwW0jAVmLpm9ss IDYnUM2XYwvBVgsLeEo0PDkJFOfgYBFQlbg3xxzE5AUq3/1HHKSCV0BQ4sfkeywQE7Uk1u88 zgRhy0tsXvOWGaRcQkBd4tFfXYgDjCSaeiezQZSISOx78Q7sYgmBU+wSO06eZQZJsAgISHyb fIgFoldWYtMBZoh3JSUOrrjBMoFRYhaSzbOQbJ6FZPMsJCsWMLKsYhRNLUguKE5KLzLSK07M LS7NS9dLzs/dxAiJyb4djDcPWB9iTAZaP5FZSjQ5HxjTeSXxhsZmRhamJqbGRuaWZqQJK4nz qrVYBwoJpCeWpGanphakFsUXleakFh9iZOLglGpgtJI8+83erkv6bMoXGS9/aePJenMeBe4P KnqgJ///1QcZtSSHCR65m/b2n2NSvsUgJtO4X6hC1Ev/m/OM7C+Ts3I2zJGca35sKg9rcPyZ Y6wC+iYVi82YIhe7VpndjOieOKN8zpzT/7TeFn/4ePhnrIXCDZW9l45Gvft+U0H8hlz/khYW /yWuSizFGYmGWsxFxYkAPUgSAN8CAAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrJKsWRmVeSWpSXmKPExsVy+t9jAd2/KYZBBtdbTS0uL7zEanGi7wOr xbqHL5gs1s+/xebA4vHqwh0Wj74tqxg9jt/YzuTxeZNcAEtUA6NNRmpiSmqRQmpecn5KZl66 rZJ3cLxzvKmZgaGuoaWFuZJCXmJuqq2Si0+ArltmDtBOJYWyxJxSoFBAYnGxkr4dpgmhIW66 FjCNEbq+IUFwPUYGaCBhHWPGu2XHGAuOsVdMuvCGuYFxLVsXIyeHhICJxPYVbSwQtpjEhXvr geJcHEICixgl9h+cxQjh/GKUaH83lx2kik1ATeLLl8NgtoiAncTCi5dYQWxmgXyJLUvawGwh AVuJpW9ug03lBKr5cmwh2DZhAU+JhicngeIcHCwCqhL35piDmLxA5bv/iINU8AoISvyYfI8F YqKWxPqdx5kgbHmJzWveMoOUSwioSzz6qwtxgJFEU+9kNogSEYl9L94xTmAUmoVk0iwkk2Yh mTQLScsCRpZVjKKpBckFxUnpuUZ6xYm5xaV56XrJ+bmbGMER/0x6B+OqBotDjAIcjEo8vB2z DIKEWBPLiitzDzFKcDArifDGmxsGCfGmJFZWpRblxxeV5qQWH2JMBnpzIrOUaHI+MBnllcQb GpuYGVkamVkYmZibkyasJM57sNU6UEggPbEkNTs1tSC1CGYLEwenVAOj8DOGg26toefXbW8T +/W7Zaaq4A0FrlfneXWTX0549muBb7BzGM8fiyWP/mnwd36QaRK0YSp73pO5o95fqGaWoM/V 1t+8k+vUHlc9uX3l/tpH5ivvOArpP1+1sV1MfPs298yVl8Qa3ho373brZNDU/13TubVk5rRF kT/Wq38uUonwODR/qp6mEktxRqKhFnNRcSIA3wMPTzwDAAA= DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected Sender: linux-fbdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fbdev@vger.kernel.org X-Spam-Status: No, score=-7.8 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP From fbb1885952efb15a46d03aac050c38fc9179594e Mon Sep 17 00:00:00 2001 From: Jingoo Han Date: Thu, 12 Sep 2013 14:42:45 +0900 Subject: [PATCH 06/21] video: gx1fb: remove unnecessary pci_set_drvdata() The driver core clears the driver data to NULL after device_release or on probe failure. Thus, it is not needed to manually clear the device driver data to NULL. Signed-off-by: Jingoo Han --- drivers/video/geode/gx1fb_core.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/video/geode/gx1fb_core.c b/drivers/video/geode/gx1fb_core.c index ebbaada..7551a04 100644 --- a/drivers/video/geode/gx1fb_core.c +++ b/drivers/video/geode/gx1fb_core.c @@ -399,7 +399,6 @@ static void gx1fb_remove(struct pci_dev *pdev) release_mem_region(gx1_gx_base() + 0x8300, 0x100); fb_dealloc_cmap(&info->cmap); - pci_set_drvdata(pdev, NULL); framebuffer_release(info); }