From patchwork Mon Apr 28 11:17:05 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jingoo Han X-Patchwork-Id: 4076881 Return-Path: X-Original-To: patchwork-linux-fbdev@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 1A29FBFF02 for ; Mon, 28 Apr 2014 11:17:14 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 2AD722021B for ; Mon, 28 Apr 2014 11:17:13 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id C9CF020200 for ; Mon, 28 Apr 2014 11:17:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754957AbaD1LRK (ORCPT ); Mon, 28 Apr 2014 07:17:10 -0400 Received: from mailout3.samsung.com ([203.254.224.33]:11181 "EHLO mailout3.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754284AbaD1LRI (ORCPT ); Mon, 28 Apr 2014 07:17:08 -0400 Received: from epcpsbgr1.samsung.com (u141.gpu120.samsung.co.kr [203.254.230.141]) by mailout3.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTP id <0N4Q00EGNNCIFUD0@mailout3.samsung.com>; Mon, 28 Apr 2014 20:17:06 +0900 (KST) Received: from epcpsbgm1.samsung.com ( [203.254.230.48]) by epcpsbgr1.samsung.com (EPCPMTA) with SMTP id EB.5E.18501.2B83E535; Mon, 28 Apr 2014 20:17:06 +0900 (KST) X-AuditID: cbfee68d-b7f4e6d000004845-5e-535e38b22e7f Received: from epmmp1.local.host ( [203.254.227.16]) by epcpsbgm1.samsung.com (EPCPMTA) with SMTP id 19.1D.27725.2B83E535; Mon, 28 Apr 2014 20:17:06 +0900 (KST) Received: from DOJG1HAN03 ([12.36.166.146]) by mmp1.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTPA id <0N4Q00CDPNCIZTA0@mmp1.samsung.com>; Mon, 28 Apr 2014 20:17:06 +0900 (KST) From: Jingoo Han To: 'Masanari Iida' , 'Tomi Valkeinen' Cc: 'Jean-Christophe Plagniol-Villard' , linux-fbdev@vger.kernel.org, linux-omap@vger.kernel.org, 'Jingoo Han' References: <1398682455-21043-1-git-send-email-standby24x7@gmail.com> In-reply-to: <1398682455-21043-1-git-send-email-standby24x7@gmail.com> Subject: Re: [PATCH] fbdev: omap2: Fix format string mismatch in display-sysfs.c Date: Mon, 28 Apr 2014 20:17:05 +0900 Message-id: <002401cf62d3$634cc1f0$29e645d0$%han@samsung.com> MIME-version: 1.0 Content-type: text/plain; charset=us-ascii Content-transfer-encoding: 7bit X-Mailer: Microsoft Office Outlook 12.0 Thread-index: Ac9i0HCqpaZwVai4QKahrYy4Lztc2QAAlHWQ Content-language: ko X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFrrDIsWRmVeSWpSXmKPExsVy+t8zA91NFnHBBl17BSwuL7zEanGi7wOr xewl/SwW6x6+YLK4NOM6u8X6+bfYHNg8ds66y+7x6sIdFo++LasYPY7f2M7k8XmTXABrFJdN SmpOZllqkb5dAlfGut5zjAW7+SsuN7YxNzCe4eli5OSQEDCRmPrtITuELSZx4d56ti5GLg4h gWWMElNftbHCFJ3/v5sFIrGIUeLm0fXMEM5vRolfZ1eDtbMJqEl8+XIYzBYRCJc4fPkHI0gR s8B8Rom366+zgCSEBFwlunfOByri4OAUcJP4/MwJJCwsECDxZ+ozZhCbRUBVYvKafWBzeAVs JZ69PcsCYQtK/Jh8D8xmFtCSWL/zOBOELS+xec1bZpCREgLqEo/+6kKcYCRx8etWNogSEYl9 L94xQjzzll3iy3FLiFUCEt8mH2KBaJWV2HSAGaJEUuLgihssExglZiFZPAvJ4llIFs9CsmEB I8sqRtHUguSC4qT0IkO94sTc4tK8dL3k/NxNjJCY7d3BePuA9SHGZKD1E5mlRJPzgTGfVxJv aGxmZGFqYmpsZG5pRpqwkjhv0sOkICGB9MSS1OzU1ILUovii0pzU4kOMTBycUg2MeX9+JQoz OV3Vaw7xfmJ9yfZyR3rC9agLu8LWLf9nV3zCZPeu3TFGR/67BmQa8P76v9DZp8fo8RaGopp3 RwKPbGE0kdqcxvpaT7puxt60Bd3zfy16+Pp291qn6ztz/9lP3e158k7e8Z4clV0/nnV57Jb/ 9OHL1RnGPjtadG4umnN9D9u85aJtV5RYijMSDbWYi4oTAbvKpVLvAgAA X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFtrFKsWRmVeSWpSXmKPExsVy+t9jAd1NFnHBBst6eCwuL7zEanGi7wOr xewl/SwW6x6+YLK4NOM6u8X6+bfYHNg8ds66y+7x6sIdFo++LasYPY7f2M7k8XmTXABrVAOj TUZqYkpqkUJqXnJ+SmZeuq2Sd3C8c7ypmYGhrqGlhbmSQl5ibqqtkotPgK5bZg7QCUoKZYk5 pUChgMTiYiV9O0wTQkPcdC1gGiN0fUOC4HqMDNBAwjrGjHW95xgLdvNXXG5sY25gPMPTxcjJ ISFgInH+/24WCFtM4sK99WxdjFwcQgKLGCVuHl3PDOH8ZpT4dXY1O0gVm4CaxJcvh8FsEYFw icOXfzCCFDELzGeUeLv+OtgoIQFXie6d84GKODg4BdwkPj9zAgkLCwRI/Jn6jBnEZhFQlZi8 Zh/YHF4BW4lnb8+yQNiCEj8m3wOzmQW0JNbvPM4EYctLbF7zlhlkpISAusSjv7oQJxhJXPy6 lQ2iRERi34t3jBMYhWYhmTQLyaRZSCbNQtKygJFlFaNoakFyQXFSeq6hXnFibnFpXrpecn7u JkZwSngmtYNxZYPFIUYBDkYlHt6IObHBQqyJZcWVuYcYJTiYlUR475nEBQvxpiRWVqUW5ccX leakFh9iTAZ6dCKzlGhyPjBd5ZXEGxqbmBlZGplZGJmYm5MmrCTOe6DVOlBIID2xJDU7NbUg tQhmCxMHp1QDI1Nk2Ebj9m3Bqf91y+ydNjAIyqi1pgRtMXpkzpO+7cvqB8Iy/W07jDTuzT5o LSCvtWyC6Df/Joev1zl+8GzacKLw6oOwtxJaldrPLnOVTmC9f2d752NOa++OgyWLJr2Ymp4Y uXzehw2bVs6V2lsy0ejTynW34m7af1qjc/qS3JwXH9+GbtoYUKnEUpyRaKjFXFScCACz9izl TQMAAA== DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected Sender: linux-fbdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fbdev@vger.kernel.org X-Spam-Status: No, score=-7.5 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP On Monday, April 28, 2014 7:54 PM, Masanari Iida wrote: > > Fix two format string mismatch in display-sysfs.c > > Signed-off-by: Masanari Iida > --- > drivers/video/fbdev/omap2/dss/display-sysfs.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/video/fbdev/omap2/dss/display-sysfs.c b/drivers/video/fbdev/omap2/dss/display- > sysfs.c > index 5a2095a..5928bc9 100644 > --- a/drivers/video/fbdev/omap2/dss/display-sysfs.c > +++ b/drivers/video/fbdev/omap2/dss/display-sysfs.c > @@ -184,7 +184,7 @@ static ssize_t display_rotate_show(struct device *dev, > if (!dssdev->driver->get_rotate) > return -ENOENT; > rotate = dssdev->driver->get_rotate(dssdev); According to 'struct omap_dss_driver', get_rotate() returns 'u8'. Then, how about changing the type of 'rotate' variable from 'int' to 'u8' as below? Best regards, Jingoo Han > - return snprintf(buf, PAGE_SIZE, "%u\n", rotate); > + return snprintf(buf, PAGE_SIZE, "%d\n", rotate); > } > > static ssize_t display_rotate_store(struct device *dev, > @@ -215,7 +215,7 @@ static ssize_t display_mirror_show(struct device *dev, > if (!dssdev->driver->get_mirror) > return -ENOENT; > mirror = dssdev->driver->get_mirror(dssdev); > - return snprintf(buf, PAGE_SIZE, "%u\n", mirror); > + return snprintf(buf, PAGE_SIZE, "%d\n", mirror); > } > > static ssize_t display_mirror_store(struct device *dev, > -- > 2.0.0.rc1 --- To unsubscribe from this list: send the line "unsubscribe linux-fbdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html --- a/drivers/video/fbdev/omap2/dss/display-sysfs.c +++ b/drivers/video/fbdev/omap2/dss/display-sysfs.c @@ -180,7 +180,7 @@ static ssize_t display_rotate_show(struct device *dev, struct device_attribute *attr, char *buf) { struct omap_dss_device *dssdev = to_dss_device_sysfs(dev); - int rotate; + u8 rotate; if (!dssdev->driver->get_rotate) return -ENOENT; rotate = dssdev->driver->get_rotate(dssdev);