From patchwork Fri Oct 26 07:02:25 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jingoo Han X-Patchwork-Id: 1650011 Return-Path: X-Original-To: patchwork-linux-fbdev@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork2.kernel.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by patchwork2.kernel.org (Postfix) with ESMTP id 43D1EDF2F6 for ; Fri, 26 Oct 2012 07:02:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756629Ab2JZHC2 (ORCPT ); Fri, 26 Oct 2012 03:02:28 -0400 Received: from mailout2.samsung.com ([203.254.224.25]:60145 "EHLO mailout2.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756600Ab2JZHC1 (ORCPT ); Fri, 26 Oct 2012 03:02:27 -0400 Received: from epcpsbgm1.samsung.com (epcpsbgm1 [203.254.230.26]) by mailout2.samsung.com (Oracle Communications Messaging Server 7u4-24.01(7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTP id <0MCH00688NJSWAH0@mailout2.samsung.com> for linux-fbdev@vger.kernel.org; Fri, 26 Oct 2012 16:02:26 +0900 (KST) X-AuditID: cbfee61a-b7fa66d0000004cf-a1-508a3582447f Received: from epmmp1.local.host ( [203.254.227.16]) by epcpsbgm1.samsung.com (EPCPMTA) with SMTP id 24.81.01231.2853A805; Fri, 26 Oct 2012 16:02:26 +0900 (KST) Received: from DOJG1HAN02 ([12.23.120.99]) by mmp1.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTPA id <0MCH0059UNK2R750@mmp1.samsung.com> for linux-fbdev@vger.kernel.org; Fri, 26 Oct 2012 16:02:26 +0900 (KST) From: Jingoo Han To: 'Florian Tobias Schandinat' Cc: linux-fbdev@vger.kernel.org, 'Jingoo Han' References: <002101cdb347$86236950$926a3bf0$%han@samsung.com> In-reply-to: <002101cdb347$86236950$926a3bf0$%han@samsung.com> Subject: [PATCH 3/3] video: s3c-fb: fix red offset and lengh for ARGB232 format Date: Fri, 26 Oct 2012 16:02:25 +0900 Message-id: <002601cdb347$dad82260$90886720$%han@samsung.com> MIME-version: 1.0 Content-type: text/plain; charset=us-ascii Content-transfer-encoding: 7bit X-Mailer: Microsoft Office Outlook 12.0 Thread-index: Ac2zR4YHt9GLYlV0Sc+1eD0FYs6X0AAAD4Rg Content-language: ko X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFjrDLMWRmVeSWpSXmKPExsVy+t9jAd0m064Ag917+CxO9H1gdWD0+LxJ LoAxissmJTUnsyy1SN8ugStjwfY/7AUX2Ss2v7nI0sDYyNbFyMkhIWAi0dQ8lQnCFpO4cG89 UJyLQ0hgEaPEsoWPWSGcWUwSKz5/AqtiE1CT+PLlMHsXIweHiICVxKatmiBhZgFniQk3ToAN FRKwlVi0fyoriM0pYCdxtGUbO4gtLOAv0dKwFizOIqAq0fB9BQuIzQtUf+bzGnYIW1Dix+R7 LBAztSTW7zzOBGHLS2xe85YZZK2EgLrEo7+6IGERASOJuc29bBAlIhL7XrxjnMAoNAvJpFlI Js1CMmkWkpYFjCyrGEVTC5ILipPScw31ihNzi0vz0vWS83M3MYLD+JnUDsaVDRaHGAU4GJV4 eCNSOgOEWBPLiitzDzFKcDArifDungoU4k1JrKxKLcqPLyrNSS0+xCjNwaIkztvskRIgJJCe WJKanZpakFoEk2Xi4JRqYFw5w3F7u0yS3Xe1l08OrnnPtXNOzIcM+5P3Pjh7LN9bHXKHWZfN ZqJ6G6vGj/xZytU8tTLHv66OZc2eIJD7iF/jSMIMtrTq249nnJZpWxJ06eaPI48unp6dHXLC sbj3ln2A0fnHjcdCeo873GndqvvWzertUtUvT7nnxF5/Esz3Xapb8+wZyWlKLMUZiYZazEXF iQD4NJOQXwIAAA== Sender: linux-fbdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fbdev@vger.kernel.org Green pixel and blue pixel are 3 bits and 2 bits respectively at ARGB232 format. Thus, the value of red offset should be 5, not 4. Also, the value of red length should be 2, because red pixel is 2 bits at ARGB232 format. Signed-off-by: Jingoo Han --- drivers/video/s3c-fb.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/video/s3c-fb.c b/drivers/video/s3c-fb.c index f453b8b..d8bfb4a 100644 --- a/drivers/video/s3c-fb.c +++ b/drivers/video/s3c-fb.c @@ -268,10 +268,10 @@ static int s3c_fb_check_var(struct fb_var_screeninfo *var, case 8: if (sfb->variant.palette[win->index] != 0) { /* non palletised, A:1,R:2,G:3,B:2 mode */ - var->red.offset = 4; + var->red.offset = 5; var->green.offset = 2; var->blue.offset = 0; - var->red.length = 5; + var->red.length = 2; var->green.length = 3; var->blue.length = 2; var->transp.offset = 7;