From patchwork Thu Sep 12 06:57:54 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jingoo Han X-Patchwork-Id: 2876471 Return-Path: X-Original-To: patchwork-linux-fbdev@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork2.web.kernel.org (Postfix) with ESMTP id A7312BF43F for ; Thu, 12 Sep 2013 06:57:58 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id F03BD2021E for ; Thu, 12 Sep 2013 06:57:57 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id B57ED2021C for ; Thu, 12 Sep 2013 06:57:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754619Ab3ILG54 (ORCPT ); Thu, 12 Sep 2013 02:57:56 -0400 Received: from mailout1.samsung.com ([203.254.224.24]:29225 "EHLO mailout1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754294Ab3ILG5z (ORCPT ); Thu, 12 Sep 2013 02:57:55 -0400 Received: from epcpsbgr3.samsung.com (u143.gpu120.samsung.co.kr [203.254.230.143]) by mailout1.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTP id <0MT0000IR3BMJ3P0@mailout1.samsung.com> for linux-fbdev@vger.kernel.org; Thu, 12 Sep 2013 15:57:54 +0900 (KST) Received: from epcpsbgm1.samsung.com ( [203.254.230.47]) by epcpsbgr3.samsung.com (EPCPMTA) with SMTP id A9.88.20109.2F561325; Thu, 12 Sep 2013 15:57:54 +0900 (KST) X-AuditID: cbfee68f-b7f1e6d000004e8d-93-523165f2ce12 Received: from epmmp2 ( [203.254.227.17]) by epcpsbgm1.samsung.com (EPCPMTA) with SMTP id 09.26.09055.2F561325; Thu, 12 Sep 2013 15:57:54 +0900 (KST) Received: from DOJG1HAN03 ([12.23.120.99]) by mmp2.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTPA id <0MT000JYR3CIE660@mmp2.samsung.com>; Thu, 12 Sep 2013 15:57:54 +0900 (KST) From: Jingoo Han To: 'Jean-Christophe PLAGNIOL-VILLARD' Cc: 'Tomi Valkeinen' , linux-fbdev@vger.kernel.org, 'Jingoo Han' References: <001a01ceaf84$32c52d90$984f88b0$%han@samsung.com> In-reply-to: <001a01ceaf84$32c52d90$984f88b0$%han@samsung.com> Subject: [PATCH 13/21] video: neofb: remove unnecessary pci_set_drvdata() Date: Thu, 12 Sep 2013 15:57:54 +0900 Message-id: <002701ceaf85$67c44430$374ccc90$%han@samsung.com> MIME-version: 1.0 Content-type: text/plain; charset=us-ascii Content-transfer-encoding: 7bit X-Mailer: Microsoft Office Outlook 12.0 Thread-index: Ac6vhDKuTCwbnQ4aTDC9KoLwWMziagAARtHg Content-language: ko x-cr-hashedpuzzle: BUFN IY2A JgFi M4Y2 QQj7 U74h V6Zn X72I YXJS YhB0 ccpM g5Q8 lYa3 s8sB t2v5 vBMN; 4; agBnADEALgBoAGEAbgBAAHMAYQBtAHMAdQBuAGcALgBjAG8AbQA7AGwAaQBuAHUAeAAtAGYAYgBkAGUAdgBAAHYAZwBlAHIALgBrAGUAcgBuAGUAbAAuAG8AcgBnADsAcABsAGEAZwBuAGkAbwBqAEAAagBjAHIAbwBzAG8AZgB0AC4AYwBvAG0AOwB0AG8AbQBpAC4AdgBhAGwAawBlAGkAbgBlAG4AQAB0AGkALgBjAG8AbQA=; Sosha1_v1; 7; {15C352B3-ECFA-462C-8E93-615A171F1684}; agBnADEALgBoAGEAbgBAAHMAYQBtAHMAdQBuAGcALgBjAG8AbQA=; Thu, 12 Sep 2013 06:57:47 GMT; WwBQAEEAVABDAEgAIAAxADMALwAyADEAXQAgAHYAaQBkAGUAbwA6ACAAbgBlAG8AZgBiADoAIAByAGUAbQBvAHYAZQAgAHUAbgBuAGUAYwBlAHMAcwBhAHIAeQAgAHAAYwBpAF8AcwBlAHQAXwBkAHIAdgBkAGEAdABhACgAKQA= x-cr-puzzleid: {15C352B3-ECFA-462C-8E93-615A171F1684} X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrOIsWRmVeSWpSXmKPExsVy+t8zfd1PqYZBBr+nyFlcXniJ1eJE3wdW i3UPXzBZrJ9/i82BxePVhTssHn1bVjF6HL+xncnj8ya5AJYoLpuU1JzMstQifbsErowFpxew FHxhrVj/ZCtzA+Ntli5GTg4JAROJ7QfnM0HYYhIX7q1n62Lk4hASWMYo8Wz3JmaYohUHVjNC JKYzSmw82cQE4fxilDi28w9YO5uAmsSXL4fZQWwRATuJhRcvsYLYzAL5EluWtIHZQgK2Ekvf QKzmBKr5cmwhG4gtLOApsf3RSrBtLAKqEu8WPAGbwwtUf2PCVFYIW1Dix+R7LBAztSTW7zzO BGHLS2xe8xaolwPoUnWJR391IU4wkrh9awMzRImIxL4X78AekBCYwioxs/0NG8RnphLHOu4x QSReskvM/j2ZHeIIAYlvkw+xQAyVldh0ABoSkhIHV9xgmcAoNQvJSbOQnDQLyUmzkOxewMiy ilE0tSC5oDgpvchYrzgxt7g0L10vOT93EyMkkvt3MN49YH2IMRlo/URmKdHkfGAiyCuJNzQ2 M7IwNTE1NjK3NCNNWEmcV63FOlBIID2xJDU7NbUgtSi+qDQntfgQIxMHp1QDo5AVw0y10qNt NxZOXmLuJbV/HcsFkVe5byOrpmWvOegrvOxy36QFi17Pfe+5xdBsX/x1IZUstY3PfF7eW86z KfBbscURyyeO4UGbs/0V6m1OXL/+r+dA7J5LhfbL8g4ohq9tE7nYvWrqyQtm7/SVJCYWB9X+ EJrz3Srzkuo/9ryqd1JVtUtsupVYijMSDbWYi4oTAQ649kr6AgAA X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFjrCKsWRmVeSWpSXmKPExsVy+t9jQd1PqYZBBi2zpCwuL7zEanGi7wOr xbqHL5gs1s+/xebA4vHqwh0Wj74tqxg9jt/YzuTxeZNcAEtUA6NNRmpiSmqRQmpecn5KZl66 rZJ3cLxzvKmZgaGuoaWFuZJCXmJuqq2Si0+ArltmDtBOJYWyxJxSoFBAYnGxkr4dpgmhIW66 FjCNEbq+IUFwPUYGaCBhHWPGgtMLWAq+sFasf7KVuYHxNksXIyeHhICJxIoDqxkhbDGJC/fW s3UxcnEICUxnlNh4sokJwvnFKHFs5x8mkCo2ATWJL18Os4PYIgJ2EgsvXmIFsZkF8iW2LGkD s4UEbCWWvoHYwAlU8+XYQjYQW1jAU2L7o5XMIDaLgKrEuwVPwObwAtXfmDCVFcIWlPgx+R4L xEwtifU7jzNB2PISm9e8BerlALpUXeLRX12IE4wkbt/awAxRIiKx78U7RpCbJQSmsErMbH/D BvGZqcSxjntMExhFZiFZMQvJillIVsxCMmsBI8sqRtHUguSC4qT0XEO94sTc4tK8dL3k/NxN jOA08UxqB+PKBotDjAIcjEo8vB2zDIKEWBPLiitzDzFKcDArifDGmxsGCfGmJFZWpRblxxeV 5qQWH2JMBobARGYp0eR8YArLK4k3NDYxM7I0MrMwMjE3J01YSZz3QKt1oJBAemJJanZqakFq EcwWJg5OqQZG98lR539dY06/wdPnd5vhXrRdk0HmzqUV8/gypGWNE0tjJnFk+bEG32A7xS5g Wy+ffctx/dOjnoaveMx4Nm6S1vmiuiywQW7v6zbZy6KvpU6z3J5lOMuQY+1fvnCFZTw6s18L mL/hSz/F2/JokcIX27vli7Se/01ztn1/441U1pspFhO/daUosRRnJBpqMRcVJwIAYOTAolcD AAA= DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected Sender: linux-fbdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fbdev@vger.kernel.org X-Spam-Status: No, score=-7.8 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP The driver core clears the driver data to NULL after device_release or on probe failure. Thus, it is not needed to manually clear the device driver data to NULL. Signed-off-by: Jingoo Han --- drivers/video/neofb.c | 6 ------ 1 file changed, 6 deletions(-) diff --git a/drivers/video/neofb.c b/drivers/video/neofb.c index 7ef079c..891b0bf 100644 --- a/drivers/video/neofb.c +++ b/drivers/video/neofb.c @@ -2146,12 +2146,6 @@ static void neofb_remove(struct pci_dev *dev) fb_destroy_modedb(info->monspecs.modedb); neo_unmap_mmio(info); neo_free_fb_info(info); - - /* - * Ensure that the driver data is no longer - * valid. - */ - pci_set_drvdata(dev, NULL); } }