From patchwork Thu Sep 12 06:58:11 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jingoo Han X-Patchwork-Id: 2876481 Return-Path: X-Original-To: patchwork-linux-fbdev@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 78A679F478 for ; Thu, 12 Sep 2013 06:58:15 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id A259D2021E for ; Thu, 12 Sep 2013 06:58:14 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 98D022021C for ; Thu, 12 Sep 2013 06:58:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754294Ab3ILG6N (ORCPT ); Thu, 12 Sep 2013 02:58:13 -0400 Received: from mailout1.samsung.com ([203.254.224.24]:29281 "EHLO mailout1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753493Ab3ILG6M (ORCPT ); Thu, 12 Sep 2013 02:58:12 -0400 Received: from epcpsbgr5.samsung.com (u145.gpu120.samsung.co.kr [203.254.230.145]) by mailout1.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTP id <0MT000LV83CRB8Q0@mailout1.samsung.com> for linux-fbdev@vger.kernel.org; Thu, 12 Sep 2013 15:58:11 +0900 (KST) Received: from epcpsbgm1.samsung.com ( [203.254.230.48]) by epcpsbgr5.samsung.com (EPCPMTA) with SMTP id 32.6A.29948.30661325; Thu, 12 Sep 2013 15:58:11 +0900 (KST) X-AuditID: cbfee691-b7f4a6d0000074fc-bd-52316603cbbb Received: from epmmp2 ( [203.254.227.17]) by epcpsbgm1.samsung.com (EPCPMTA) with SMTP id FF.36.09055.30661325; Thu, 12 Sep 2013 15:58:11 +0900 (KST) Received: from DOJG1HAN03 ([12.23.120.99]) by mmp2.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTPA id <0MT000J7C3CZE670@mmp2.samsung.com>; Thu, 12 Sep 2013 15:58:11 +0900 (KST) From: Jingoo Han To: 'Jean-Christophe PLAGNIOL-VILLARD' Cc: 'Tomi Valkeinen' , linux-fbdev@vger.kernel.org, 'Jingoo Han' References: <001a01ceaf84$32c52d90$984f88b0$%han@samsung.com> In-reply-to: <001a01ceaf84$32c52d90$984f88b0$%han@samsung.com> Subject: [PATCH 14/21] video: pm2fb: remove unnecessary pci_set_drvdata() Date: Thu, 12 Sep 2013 15:58:11 +0900 Message-id: <002801ceaf85$71f3d740$55db85c0$%han@samsung.com> MIME-version: 1.0 Content-type: text/plain; charset=us-ascii Content-transfer-encoding: 7bit X-Mailer: Microsoft Office Outlook 12.0 Thread-index: Ac6vhDKuTCwbnQ4aTDC9KoLwWMziagAATH9w Content-language: ko X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFjrDIsWRmVeSWpSXmKPExsVy+t8zA13mNMMgg3ut0haXF15itTjR94HV Yt3DF0wW6+ffYnNg8Xh14Q6LR9+WVYwex29sZ/L4vEkugCWKyyYlNSezLLVI3y6BK2PR6i2M BQfZKzYtaGFpYFzB1sXIwSEhYCJxoZ29i5ETyBSTuHBvPVCYi0NIYBmjxPz5O5kgEiYSj5/v YIJITGeU+DFvH1hCSOAXo8Tt7fIgNpuAmsSXL4fBJokI2EksvHiJFcRmFsiX2LKkjRWi3lZi 6ZvbLCA2J1DNl2ML2UBsYQFPibauP8wgNouAqsTiG0/A4rxA9aeWboKyBSV+TL7HAjFTS2L9 zuNMELa8xOY1b5khnlGXePRXF+IEI4k1+79AnSAise/FO0aQ+yUEjrFLLNy0kgVil4DEt8mH WCB6ZSU2HWCG+FdS4uCKGywTGCVmIdk8C8nmWUg2z0KyYgEjyypG0dSC5ILipPQiU73ixNzi 0rx0veT83E2MkJicuIPx/gHrQ4zJQOsnMkuJJucDYzqvJN7Q2MzIwtTE1NjI3NKMNGElcV71 FutAIYH0xJLU7NTUgtSi+KLSnNTiQ4xMHJxSDYzn7y5ztWr12NP+KyZ+3UWn2d8+qVRatX/T L513Pl/c7bGE5d8HV5qiO3Pnp89dWLpH+mmRYMxczfPeih/0vfO3JIRt3aLm+ClB1GehTKGV oq73T+PSgHPO796cD8ho4ePRZXGTZVk/7XuQJS+LmbheZK1W0dUXb3WFtl3K557yfnf4RLuO UCWW4oxEQy3mouJEAJCIgWbfAgAA X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrFKsWRmVeSWpSXmKPExsVy+t9jQV3mNMMgg/Y1ohaXF15itTjR94HV Yt3DF0wW6+ffYnNg8Xh14Q6LR9+WVYwex29sZ/L4vEkugCWqgdEmIzUxJbVIITUvOT8lMy/d Vsk7ON453tTMwFDX0NLCXEkhLzE31VbJxSdA1y0zB2inkkJZYk4pUCggsbhYSd8O04TQEDdd C5jGCF3fkCC4HiMDNJCwjjFj0eotjAUH2Ss2LWhhaWBcwdbFyMkhIWAi8fj5DiYIW0ziwr31 QHEuDiGB6YwSP+btA0sICfxilLi9XR7EZhNQk/jy5TA7iC0iYCex8OIlVhCbWSBfYsuSNlaI eluJpW9us4DYnEA1X44tBFsmLOAp0db1hxnEZhFQlVh84wlYnBeo/tTSTVC2oMSPyfdYIGZq SazfeZwJwpaX2LzmLVAvB9Ch6hKP/upCnGAksWb/F6gTRCT2vXjHOIFRaBaSSbOQTJqFZNIs JC0LGFlWMYqmFiQXFCel5xrqFSfmFpfmpesl5+duYgTH/DOpHYwrGywOMQpwMCrx8HbMMggS Yk0sK67MPcQowcGsJMIbb24YJMSbklhZlVqUH19UmpNafIgxGejRicxSosn5wHSUVxJvaGxi ZmRpZGZhZGJuTpqwkjjvgVbrQCGB9MSS1OzU1ILUIpgtTBycUg2MmeYHFnHu9IyUfTmL5ZGC SJvm166nu7tmFmsscDeez29iwKEhZv5b+eTkRdfjOGxcts5YtvXS2Xebv296qrpGc+OWfO2V v/y4N0v95pTbPHnRHKmUPY5njupozWGyuBrPyRYWLC3GOiV+Z5Lxim3VgbfXHk3xd9hYJ8By 5GDHJ/NJbXF3ij6qKrEUZyQaajEXFScCAOWlawA9AwAA DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected Sender: linux-fbdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fbdev@vger.kernel.org X-Spam-Status: No, score=-7.8 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP From 9e2c37ee1d5c2145fac113c483c9e6dd408f10fe Mon Sep 17 00:00:00 2001 From: Jingoo Han Date: Thu, 12 Sep 2013 15:11:07 +0900 Subject: [PATCH 14/21] video: pm2fb: remove unnecessary pci_set_drvdata() The driver core clears the driver data to NULL after device_release or on probe failure. Thus, it is not needed to manually clear the device driver data to NULL. Signed-off-by: Jingoo Han --- drivers/video/pm2fb.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/video/pm2fb.c b/drivers/video/pm2fb.c index 81354ee..45d9a3f 100644 --- a/drivers/video/pm2fb.c +++ b/drivers/video/pm2fb.c @@ -1744,7 +1744,6 @@ static void pm2fb_remove(struct pci_dev *pdev) iounmap(par->v_regs); release_mem_region(fix->mmio_start, fix->mmio_len); - pci_set_drvdata(pdev, NULL); fb_dealloc_cmap(&info->cmap); kfree(info->pixmap.addr); framebuffer_release(info);