From patchwork Thu Sep 12 06:58:44 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jingoo Han X-Patchwork-Id: 2876491 Return-Path: X-Original-To: patchwork-linux-fbdev@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 6AC039F478 for ; Thu, 12 Sep 2013 06:58:48 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 9EB772021E for ; Thu, 12 Sep 2013 06:58:47 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 8A5352021C for ; Thu, 12 Sep 2013 06:58:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751543Ab3ILG6q (ORCPT ); Thu, 12 Sep 2013 02:58:46 -0400 Received: from mailout2.samsung.com ([203.254.224.25]:41951 "EHLO mailout2.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751458Ab3ILG6p (ORCPT ); Thu, 12 Sep 2013 02:58:45 -0400 Received: from epcpsbgr5.samsung.com (u145.gpu120.samsung.co.kr [203.254.230.145]) by mailout2.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTP id <0MT000C7Q3BDAFB0@mailout2.samsung.com> for linux-fbdev@vger.kernel.org; Thu, 12 Sep 2013 15:58:44 +0900 (KST) Received: from epcpsbgm1.samsung.com ( [203.254.230.48]) by epcpsbgr5.samsung.com (EPCPMTA) with SMTP id 89.BA.29948.42661325; Thu, 12 Sep 2013 15:58:44 +0900 (KST) X-AuditID: cbfee691-b7f4a6d0000074fc-87-52316624ac01 Received: from epmmp2 ( [203.254.227.17]) by epcpsbgm1.samsung.com (EPCPMTA) with SMTP id B1.76.09055.32661325; Thu, 12 Sep 2013 15:58:44 +0900 (KST) Received: from DOJG1HAN03 ([12.23.120.99]) by mmp2.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTPA id <0MT000J253DVQF30@mmp2.samsung.com>; Thu, 12 Sep 2013 15:58:43 +0900 (KST) From: Jingoo Han To: 'Jean-Christophe PLAGNIOL-VILLARD' Cc: 'Tomi Valkeinen' , linux-fbdev@vger.kernel.org, 'Jingoo Han' References: <001a01ceaf84$32c52d90$984f88b0$%han@samsung.com> In-reply-to: <001a01ceaf84$32c52d90$984f88b0$%han@samsung.com> Subject: [PATCH 15/21] video: pm3fb: remove unnecessary pci_set_drvdata() Date: Thu, 12 Sep 2013 15:58:44 +0900 Message-id: <002901ceaf85$857f59b0$907e0d10$%han@samsung.com> MIME-version: 1.0 Content-type: text/plain; charset=us-ascii Content-transfer-encoding: 7bit X-Mailer: Microsoft Office Outlook 12.0 Thread-index: Ac6vhDKuTCwbnQ4aTDC9KoLwWMziagAAUA9A Content-language: ko x-cr-hashedpuzzle: Ad90 DpCA Jh99 JwBj KTtg KqD+ Kx9+ LuV7 U2zx aNrb d1jN gETO nFaC paTm p30y ro8f; 4; agBnADEALgBoAGEAbgBAAHMAYQBtAHMAdQBuAGcALgBjAG8AbQA7AGwAaQBuAHUAeAAtAGYAYgBkAGUAdgBAAHYAZwBlAHIALgBrAGUAcgBuAGUAbAAuAG8AcgBnADsAcABsAGEAZwBuAGkAbwBqAEAAagBjAHIAbwBzAG8AZgB0AC4AYwBvAG0AOwB0AG8AbQBpAC4AdgBhAGwAawBlAGkAbgBlAG4AQAB0AGkALgBjAG8AbQA=; Sosha1_v1; 7; {8AC99BC0-FC44-47C4-91E2-39B015B7EF0D}; agBnADEALgBoAGEAbgBAAHMAYQBtAHMAdQBuAGcALgBjAG8AbQA=; Thu, 12 Sep 2013 06:58:38 GMT; WwBQAEEAVABDAEgAIAAxADUALwAyADEAXQAgAHYAaQBkAGUAbwA6ACAAcABtADMAZgBiADoAIAByAGUAbQBvAHYAZQAgAHUAbgBuAGUAYwBlAHMAcwBhAHIAeQAgAHAAYwBpAF8AcwBlAHQAXwBkAHIAdgBkAGEAdABhACgAKQA= x-cr-puzzleid: {8AC99BC0-FC44-47C4-91E2-39B015B7EF0D} X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrKIsWRmVeSWpSXmKPExsVy+t8zA12VNMMgg18HuSwuL7zEanGi7wOr xbqHL5gs1s+/xebA4vHqwh0Wj74tqxg9jt/YzuTxeZNcAEsUl01Kak5mWWqRvl0CV8ajhcdZ C46wVrz4fJq1gfEYSxcjJ4eEgInEz7XvoGwxiQv31rN1MXJxCAksY5TonrObDaboQVMfE0Ri OqPEsi/3WSGcX4wSU+YtYgKpYhNQk/jy5TA7iC0iYCex8OIlVhCbWSBfYsuSNjBbSMBWYumb 22DrOIFqvhxbCLZBWMBTYu7npWA1LAKqEnMndYPFeYHqr07tYIWwBSV+TL7HAjFTS2L9zuNM ELa8xOY1b5m7GDmALlWXePRXF8QUETCS2PG1BqJCRGLfi3eMICdLCExhlVj84AxUuanEhkXG EPFH7BJzVxxghDhBQOLb5EMsEDWyEpsOMEPCQVLi4IobLBMYpWYhOWgWkoNmITloFpLVCxhZ VjGKphYkFxQnpReZ6hUn5haX5qXrJefnbmKERPHEHYz3D1gfYkwGWj+RWUo0OR+YBPJK4g2N zYwsTE1MjY3MLc1IE1YS51VvsQ4UEkhPLEnNTk0tSC2KLyrNSS0+xMjEwSnVwNgXdvDkmyIZ 7c6k5rSWE6ya3apn1Zylq+Y8SV8X/yr10fU1yizrLj/U7Vx+V273rFXCimwTnx9+VvC95ni6 ga1Fn4oo194jhw5cbutY4H7jR8M73d/LJvqtCi1jFOJiPfw4PNRO9No92bLeo98Y+T0Pbdou +XZdYHnlOoZzl7deaGr1WvvcaLMSS3FGoqEWc1FxIgB6iX/x+AIAAA== X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFjrEKsWRmVeSWpSXmKPExsVy+t9jQV2VNMMgg7arbBaXF15itTjR94HV Yt3DF0wW6+ffYnNg8Xh14Q6LR9+WVYwex29sZ/L4vEkugCWqgdEmIzUxJbVIITUvOT8lMy/d Vsk7ON453tTMwFDX0NLCXEkhLzE31VbJxSdA1y0zB2inkkJZYk4pUCggsbhYSd8O04TQEDdd C5jGCF3fkCC4HiMDNJCwjjHj0cLjrAVHWCtefD7N2sB4jKWLkZNDQsBE4kFTHxOELSZx4d56 ti5GLg4hgemMEsu+3GeFcH4xSkyZtwisik1ATeLLl8PsILaIgJ3EwouXWEFsZoF8iS1L2sBs IQFbiaVvboNt4ASq+XJsIRuILSzgKTH381KwGhYBVYm5k7rB4rxA9VendrBC2IISPybfY4GY qSWxfudxJghbXmLzmrfMXYwcQJeqSzz6qwtiiggYSez4WgNRISKx78U7RpCTJQSmsEosfnAG qtxUYsMi4wmMIrOQLJiFZMEsJAtmIRm1gJFlFaNoakFyQXFSeq6hXnFibnFpXrpecn7uJkZw ingmtYNxZYPFIUYBDkYlHt6OWQZBQqyJZcWVuYcYJTiYlUR4480Ng4R4UxIrq1KL8uOLSnNS iw8xJgP9P5FZSjQ5H5i+8kriDY1NzIwsjcwsjEzMzUkTVhLnPdBqHSgkkJ5YkpqdmlqQWgSz hYmDU6qBccE0v5vZKidPf/3cvSF7fqoG677zByq7OqXVfjr5iMtLyqrx/FPM3PipKWl9zjqm Ca23ObfMvv5jedwT/yVX7M41sezp3r++d/053UmsPvNs8nzC96v62Gks4xafVt92u/pHMOtR pymT/XiZDrFvvin23Ndg/02vRh8u19z+Szz+F0KC8n15lViKMxINtZiLihMBy3MTQlUDAAA= DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected Sender: linux-fbdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fbdev@vger.kernel.org X-Spam-Status: No, score=-7.8 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP The driver core clears the driver data to NULL after device_release or on probe failure. Thus, it is not needed to manually clear the device driver data to NULL. Signed-off-by: Jingoo Han --- drivers/video/pm3fb.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/video/pm3fb.c b/drivers/video/pm3fb.c index 7718faa..9c17474 100644 --- a/drivers/video/pm3fb.c +++ b/drivers/video/pm3fb.c @@ -1489,7 +1489,6 @@ static void pm3fb_remove(struct pci_dev *dev) iounmap(par->v_regs); release_mem_region(fix->mmio_start, fix->mmio_len); - pci_set_drvdata(dev, NULL); kfree(info->pixmap.addr); framebuffer_release(info); }