From patchwork Thu Sep 12 06:59:13 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jingoo Han X-Patchwork-Id: 2876501 Return-Path: X-Original-To: patchwork-linux-fbdev@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 729C9BF43F for ; Thu, 12 Sep 2013 06:59:18 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id B906A2021E for ; Thu, 12 Sep 2013 06:59:17 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id CD4712021C for ; Thu, 12 Sep 2013 06:59:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752067Ab3ILG7Q (ORCPT ); Thu, 12 Sep 2013 02:59:16 -0400 Received: from mailout1.samsung.com ([203.254.224.24]:29446 "EHLO mailout1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752011Ab3ILG7P (ORCPT ); Thu, 12 Sep 2013 02:59:15 -0400 Received: from epcpsbgr1.samsung.com (u141.gpu120.samsung.co.kr [203.254.230.141]) by mailout1.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTP id <0MT0002HS3EPY6N0@mailout1.samsung.com> for linux-fbdev@vger.kernel.org; Thu, 12 Sep 2013 15:59:14 +0900 (KST) Received: from epcpsbgm1.samsung.com ( [203.254.230.50]) by epcpsbgr1.samsung.com (EPCPMTA) with SMTP id 93.49.30629.14661325; Thu, 12 Sep 2013 15:59:13 +0900 (KST) X-AuditID: cbfee68d-b7fe86d0000077a5-d7-523166411e22 Received: from epmmp2 ( [203.254.227.17]) by epcpsbgm1.samsung.com (EPCPMTA) with SMTP id CD.86.09055.14661325; Thu, 12 Sep 2013 15:59:13 +0900 (KST) Received: from DOJG1HAN03 ([12.23.120.99]) by mmp2.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTPA id <0MT000JRT3EPGA70@mmp2.samsung.com>; Thu, 12 Sep 2013 15:59:13 +0900 (KST) From: Jingoo Han To: 'Jean-Christophe PLAGNIOL-VILLARD' Cc: 'Tomi Valkeinen' , linux-fbdev@vger.kernel.org, 'Jingoo Han' References: <001a01ceaf84$32c52d90$984f88b0$%han@samsung.com> In-reply-to: <001a01ceaf84$32c52d90$984f88b0$%han@samsung.com> Subject: [PATCH 16/21] video: s3fb: remove unnecessary pci_set_drvdata() Date: Thu, 12 Sep 2013 15:59:13 +0900 Message-id: <002a01ceaf85$96f23550$c4d69ff0$%han@samsung.com> MIME-version: 1.0 Content-type: text/plain; charset=us-ascii Content-transfer-encoding: 7bit X-Mailer: Microsoft Office Outlook 12.0 Thread-index: Ac6vhDKuTCwbnQ4aTDC9KoLwWMziagAAU/7A Content-language: ko x-cr-hashedpuzzle: Ce1O HIPe Hdxz L+R8 Mo/q UAdL YB9z YncF Yzag aEVy cSYD iR// lp56 m7q1 pcJD qSsG; 4; agBnADEALgBoAGEAbgBAAHMAYQBtAHMAdQBuAGcALgBjAG8AbQA7AGwAaQBuAHUAeAAtAGYAYgBkAGUAdgBAAHYAZwBlAHIALgBrAGUAcgBuAGUAbAAuAG8AcgBnADsAcABsAGEAZwBuAGkAbwBqAEAAagBjAHIAbwBzAG8AZgB0AC4AYwBvAG0AOwB0AG8AbQBpAC4AdgBhAGwAawBlAGkAbgBlAG4AQAB0AGkALgBjAG8AbQA=; Sosha1_v1; 7; {19CB1CE4-46A6-45FE-A6D4-0233AC0E1918}; agBnADEALgBoAGEAbgBAAHMAYQBtAHMAdQBuAGcALgBjAG8AbQA=; Thu, 12 Sep 2013 06:59:07 GMT; WwBQAEEAVABDAEgAIAAxADYALwAyADEAXQAgAHYAaQBkAGUAbwA6ACAAcwAzAGYAYgA6ACAAcgBlAG0AbwB2AGUAIAB1AG4AbgBlAGMAZQBzAHMAYQByAHkAIABwAGMAaQBfAHMAZQB0AF8AZAByAHYAZABhAHQAYQAoACkA x-cr-puzzleid: {19CB1CE4-46A6-45FE-A6D4-0233AC0E1918} X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrGIsWRmVeSWpSXmKPExsVy+t8zI13HNMMgg5XzpS0uL7zEanGi7wOr xbqHL5gs1s+/xebA4vHqwh0Wj74tqxg9jt/YzuTxeZNcAEsUl01Kak5mWWqRvl0CV0bP7gts BVNYK7qn7mFpYJzB0sXIySEhYCLx+tF5dghbTOLCvfVsXYxcHEICyxglXiy8zApT9ODJZRaI xHRGiZb585kgnF+MEg3trcwgVWwCahJfvhwGGyUiYCex8OIlsG5mgXyJLUvawGwhAVuJpW9u g63mBKr5cmwh0DoODmEBD4lNbaEgYRYBVYnp59Ywgdi8QOXzbj9mg7AFJX5MvscCMVJLYv3O 40wQtrzE5jVvmUHGSAioSzz6qwtxgZHEx30noUpEJPa9eMcIcrKEwARWiW37DjBCPGYqca5x JitE4hG7xPZJS5ghjhCQ+Db5EAvEUFmJTQeYIeolJQ6uuMEygVFqFpKTZiE5aRaSk2Yh2b2A kWUVo2hqQXJBcVJ6kaFecWJucWleul5yfu4mRkgc9+5gvH3A+hBjMtD6icxSosn5wDSQVxJv aGxmZGFqYmpsZG5pRpqwkjivWot1oJBAemJJanZqakFqUXxRaU5q8SFGJg5OqQbGY1ainvF/ jhq5beUymqYbYB6Xe79GqrlMQfOH4oSdNk0JaSYZZltPGwvPS7thYWfyel+nwrWj2YenRM+4 /fHt/L/fLxl4v3v9bfOH+La3IvOlE//ceqPR53G44o1Q35+8H0Hh7zteTX33la103tbdl1N3 tn9/YZH3qtk4IWnbzmP7NQ6Uvdi/QYmlOCPRUIu5qDgRADgGtUn5AgAA X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFjrMKsWRmVeSWpSXmKPExsVy+t9jQV3HNMMgg+n3xC0uL7zEanGi7wOr xbqHL5gs1s+/xebA4vHqwh0Wj74tqxg9jt/YzuTxeZNcAEtUA6NNRmpiSmqRQmpecn5KZl66 rZJ3cLxzvKmZgaGuoaWFuZJCXmJuqq2Si0+ArltmDtBOJYWyxJxSoFBAYnGxkr4dpgmhIW66 FjCNEbq+IUFwPUYGaCBhHWNGz+4LbAVTWCu6p+5haWCcwdLFyMkhIWAi8eDJZShbTOLCvfVs XYxcHEIC0xklWubPZ4JwfjFKNLS3MoNUsQmoSXz5cpgdxBYRsJNYePESK4jNLJAvsWVJG5gt JGArsfTNbbCpnEA1X44tBJrKwSEs4CGxqS0UJMwioCox/dwaJhCbF6h83u3HbBC2oMSPyfdY IEZqSazfeZwJwpaX2LzmLTPIGAkBdYlHf3UhLjCS+LjvJFSJiMS+F+8YQU6WEJjAKrFt3wFG iMdMJc41zmSdwCgyC8mKWUhWzEKyYhaSWQsYWVYxiqYWJBcUJ6XnGuoVJ+YWl+al6yXn525i BCeJZ1I7GFc2WBxiFOBgVOLh7ZhlECTEmlhWXJl7iFGCg1lJhDfe3DBIiDclsbIqtSg/vqg0 J7X4EGMyMAQmMkuJJucDE1heSbyhsYmZkaWRmYWRibk5acJK4rwHWq0DhQTSE0tSs1NTC1KL YLYwcXBKNTBmL6gSnhSTXrnuGm/F+/MmwKBfbPGDwW15f8yHvXfmLdK/u+FX2QTmHMYP/UdX Gtbcjc41er5P/rZSYZLgvWUTPRmuMTbJeU25t0E293vLpUMmtq90wu66LJHOriks054ixh7U 0qbzOMdhZ3DsPG4eYVFRywLuGXIX9Y53lvTlmUobmlmaKbEUZyQaajEXFScCAPLNhIFWAwAA DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected Sender: linux-fbdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fbdev@vger.kernel.org X-Spam-Status: No, score=-7.8 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP The driver core clears the driver data to NULL after device_release or on probe failure. Thus, it is not needed to manually clear the device driver data to NULL. Signed-off-by: Jingoo Han --- drivers/video/s3fb.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/video/s3fb.c b/drivers/video/s3fb.c index 47ca86c..d158d2c 100644 --- a/drivers/video/s3fb.c +++ b/drivers/video/s3fb.c @@ -1431,7 +1431,6 @@ static void s3_pci_remove(struct pci_dev *dev) pci_release_regions(dev); /* pci_disable_device(dev); */ - pci_set_drvdata(dev, NULL); framebuffer_release(info); } }