From patchwork Thu Sep 12 06:59:43 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jingoo Han X-Patchwork-Id: 2876511 Return-Path: X-Original-To: patchwork-linux-fbdev@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 38673BF43F for ; Thu, 12 Sep 2013 06:59:48 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 47F152021E for ; Thu, 12 Sep 2013 06:59:47 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 0B7DA2021C for ; Thu, 12 Sep 2013 06:59:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753066Ab3ILG7p (ORCPT ); Thu, 12 Sep 2013 02:59:45 -0400 Received: from mailout1.samsung.com ([203.254.224.24]:29531 "EHLO mailout1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752011Ab3ILG7o (ORCPT ); Thu, 12 Sep 2013 02:59:44 -0400 Received: from epcpsbgr1.samsung.com (u141.gpu120.samsung.co.kr [203.254.230.141]) by mailout1.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTP id <0MT0001DQ3E0UZR0@mailout1.samsung.com> for linux-fbdev@vger.kernel.org; Thu, 12 Sep 2013 15:59:43 +0900 (KST) Received: from epcpsbgm1.samsung.com ( [203.254.230.49]) by epcpsbgr1.samsung.com (EPCPMTA) with SMTP id 5D.89.30629.F5661325; Thu, 12 Sep 2013 15:59:43 +0900 (KST) X-AuditID: cbfee68d-b7fe86d0000077a5-70-5231665f5158 Received: from epmmp1.local.host ( [203.254.227.16]) by epcpsbgm1.samsung.com (EPCPMTA) with SMTP id 60.C6.09055.E5661325; Thu, 12 Sep 2013 15:59:43 +0900 (KST) Received: from DOJG1HAN03 ([12.23.120.99]) by mmp1.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTPA id <0MT0002UP3FINMK0@mmp1.samsung.com>; Thu, 12 Sep 2013 15:59:42 +0900 (KST) From: Jingoo Han To: 'Jean-Christophe PLAGNIOL-VILLARD' Cc: 'Tomi Valkeinen' , linux-fbdev@vger.kernel.org, 'Jingoo Han' , 'Antonino Daplas' References: <001a01ceaf84$32c52d90$984f88b0$%han@samsung.com> In-reply-to: <001a01ceaf84$32c52d90$984f88b0$%han@samsung.com> Subject: [PATCH 17/21] video: savagefb: remove unnecessary pci_set_drvdata() Date: Thu, 12 Sep 2013 15:59:43 +0900 Message-id: <002b01ceaf85$a8a57550$f9f05ff0$%han@samsung.com> MIME-version: 1.0 Content-type: text/plain; charset=us-ascii Content-transfer-encoding: 7bit X-Mailer: Microsoft Office Outlook 12.0 Thread-index: Ac6vhDKuTCwbnQ4aTDC9KoLwWMziagAAWGZg Content-language: ko X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFrrJIsWRmVeSWpSXmKPExsVy+t8zQ934NMMgg4MN3BY/u7+wWVxeeInV 4kTfB1aLdQ9fMFmsn3+LzYHVY+esu+wery7cYfHo27KK0eP4je1MHp83yQWwRnHZpKTmZJal FunbJXBltD7ZwVJwmK2icfIJ5gbGVaxdjJwcEgImEt+PzWKCsMUkLtxbz9bFyMUhJLCMUeL/ zwVMMEVn125nh0gsYpSYtPwUE4Tzi1Hi972jzCBVbAJqEl++HGYHsUUE7CQWXrzEClLELDCN UeL+jT9gCSEBW4mlb26zgNicQEVfji1kA7GFBXwk/rbdBathEVCVeLnlBNh9vED1N++8Yoew BSV+TL4H1sssoCWxfudxJghbXmLzmrdAR3AAnaou8eivLsQNRhLX2j6zQpSISOx78Y4R5B4J gXvsEo/nPGWD2CUg8W3yIRaIXlmJTQeYIT6WlDi44gbLBEaJWUg2z0KyeRaSzbOQrFjAyLKK UTS1ILmgOCm9yFCvODG3uDQvXS85P3cTIyRae3cw3j5gfYgxGWj9RGYp0eR8YLTnlcQbGpsZ WZiamBobmVuakSasJM6r1mIdKCSQnliSmp2aWpBaFF9UmpNafIiRiYNTqoGx0+LR12zBhxGn trDfOOHusJI3ZVfuqzlvbtnc+5ofFHXviQdD6eTzgn28hiET3utcnjIrqGGis9iHheuZU6wD tGatT33JMM/P4nlGRpXv1K2yveum+U9YHf/ml6wGt/blOOHLntGT7QQZ/gkb6a09p1LVxulw 6wwD+4eYpnkxj7eFHjxXXh+mxFKckWioxVxUnAgA9HbituwCAAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFtrGKsWRmVeSWpSXmKPExsVy+t9jAd34NMMgg3WL2C1+dn9hs7i88BKr xYm+D6wW6x6+YLJYP/8WmwOrx85Zd9k9Xl24w+LRt2UVo8fxG9uZPD5vkgtgjWpgtMlITUxJ LVJIzUvOT8nMS7dV8g6Od443NTMw1DW0tDBXUshLzE21VXLxCdB1y8wB2q6kUJaYUwoUCkgs LlbSt8M0ITTETdcCpjFC1zckCK7HyAANJKxjzGh9soOl4DBbRePkE8wNjKtYuxg5OSQETCTO rt3ODmGLSVy4t56ti5GLQ0hgEaPEpOWnmCCcX4wSv+8dZQapYhNQk/jy5TBYh4iAncTCi5dY QYqYBaYxSty/8QcsISRgK7H0zW0WEJsTqOjLsYVsILawgI/E37a7YDUsAqoSL7ecADuDF6j+ 5p1X7BC2oMSPyffAepkFtCTW7zzOBGHLS2xe8xboCA6gU9UlHv3VhbjBSOJa22dWiBIRiX0v 3jFOYBSahWTSLCSTZiGZNAtJywJGllWMoqkFyQXFSem5hnrFibnFpXnpesn5uZsYwangmdQO xpUNFocYBTgYlXh4O2YZBAmxJpYVV+YeYpTgYFYS4Y03NwwS4k1JrKxKLcqPLyrNSS0+xJgM 9OhEZinR5HxgmsoriTc0NjEzsjQyszAyMTcnTVhJnPdAq3WgkEB6YklqdmpqQWoRzBYmDk6p Bsb0lQriB0v0LLRPrfF4sPfhnW+PQoJ1/xzhfG5z92ftpZ2Hu/Z3hrAuUyrYbrlgx1arpZUh Bz8tOXfE+ZT3MdkMQ6+ZE69Ncl+6XaeazcDzg7Bx2iGeBZErRSQ32aRxXFjPO8XsgaKrHecH 7i8HlANFijZpJfT4GOz6uKO599NfVtXW80pT365UYinOSDTUYi4qTgQA9fO7ekkDAAA= DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected Sender: linux-fbdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fbdev@vger.kernel.org X-Spam-Status: No, score=-7.8 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP The driver core clears the driver data to NULL after device_release or on probe failure. Thus, it is not needed to manually clear the device driver data to NULL. Signed-off-by: Jingoo Han --- drivers/video/savage/savagefb_driver.c | 6 ------ 1 file changed, 6 deletions(-) diff --git a/drivers/video/savage/savagefb_driver.c b/drivers/video/savage/savagefb_driver.c index 741b239..4dbf45f 100644 --- a/drivers/video/savage/savagefb_driver.c +++ b/drivers/video/savage/savagefb_driver.c @@ -2362,12 +2362,6 @@ static void savagefb_remove(struct pci_dev *dev) kfree(info->pixmap.addr); pci_release_regions(dev); framebuffer_release(info); - - /* - * Ensure that the driver data is no longer - * valid. - */ - pci_set_drvdata(dev, NULL); } }