From patchwork Thu Sep 12 07:00:58 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jingoo Han X-Patchwork-Id: 2876531 Return-Path: X-Original-To: patchwork-linux-fbdev@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork2.web.kernel.org (Postfix) with ESMTP id D637DBF43F for ; Thu, 12 Sep 2013 07:01:05 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 54E0D20103 for ; Thu, 12 Sep 2013 07:01:01 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 33CE0200F0 for ; Thu, 12 Sep 2013 07:01:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752995Ab3ILHA7 (ORCPT ); Thu, 12 Sep 2013 03:00:59 -0400 Received: from mailout1.samsung.com ([203.254.224.24]:29844 "EHLO mailout1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751591Ab3ILHA7 (ORCPT ); Thu, 12 Sep 2013 03:00:59 -0400 Received: from epcpsbgr1.samsung.com (u141.gpu120.samsung.co.kr [203.254.230.141]) by mailout1.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTP id <0MT000LZ23GUB8Q0@mailout1.samsung.com> for linux-fbdev@vger.kernel.org; Thu, 12 Sep 2013 16:00:58 +0900 (KST) Received: from epcpsbgm1.samsung.com ( [203.254.230.51]) by epcpsbgr1.samsung.com (EPCPMTA) with SMTP id F9.0A.30629.AA661325; Thu, 12 Sep 2013 16:00:58 +0900 (KST) X-AuditID: cbfee68d-b7fe86d0000077a5-12-523166aa3e2a Received: from epmmp1.local.host ( [203.254.227.16]) by epcpsbgm1.samsung.com (EPCPMTA) with SMTP id CB.37.09055.9A661325; Thu, 12 Sep 2013 16:00:58 +0900 (KST) Received: from DOJG1HAN03 ([12.23.120.99]) by mmp1.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTPA id <0MT00028L3HLG5L0@mmp1.samsung.com>; Thu, 12 Sep 2013 16:00:57 +0900 (KST) From: Jingoo Han To: 'Jingoo Han' , 'Jean-Christophe PLAGNIOL-VILLARD' Cc: 'Tomi Valkeinen' , linux-fbdev@vger.kernel.org References: <001a01ceaf84$32c52d90$984f88b0$%han@samsung.com> In-reply-to: <001a01ceaf84$32c52d90$984f88b0$%han@samsung.com> Subject: [PATCH 19/21] video: tdfxfb: remove unnecessary pci_set_drvdata() Date: Thu, 12 Sep 2013 16:00:58 +0900 Message-id: <002d01ceaf85$d540fbc0$7fc2f340$%han@samsung.com> MIME-version: 1.0 Content-type: text/plain; charset=us-ascii Content-transfer-encoding: 7bit X-Mailer: Microsoft Office Outlook 12.0 Thread-index: Ac6vhDKuTCwbnQ4aTDC9KoLwWMziagAAY6PQ Content-language: ko x-cr-hashedpuzzle: DIqD DLh8 ENro FS74 HriV JH5f W53/ b3AU fkKz jDit jkLy jo8w l/6G nakk ojLp q4Nv; 4; agBnADEALgBoAGEAbgBAAHMAYQBtAHMAdQBuAGcALgBjAG8AbQA7AGwAaQBuAHUAeAAtAGYAYgBkAGUAdgBAAHYAZwBlAHIALgBrAGUAcgBuAGUAbAAuAG8AcgBnADsAcABsAGEAZwBuAGkAbwBqAEAAagBjAHIAbwBzAG8AZgB0AC4AYwBvAG0AOwB0AG8AbQBpAC4AdgBhAGwAawBlAGkAbgBlAG4AQAB0AGkALgBjAG8AbQA=; Sosha1_v1; 7; {456FB285-5000-41BC-92D3-45BD01FAC3C8}; agBnADEALgBoAGEAbgBAAHMAYQBtAHMAdQBuAGcALgBjAG8AbQA=; Thu, 12 Sep 2013 07:00:51 GMT; WwBQAEEAVABDAEgAIAAxADkALwAyADEAXQAgAHYAaQBkAGUAbwA6ACAAdABkAGYAeABmAGIAOgAgAHIAZQBtAG8AdgBlACAAdQBuAG4AZQBjAGUAcwBzAGEAcgB5ACAAcABjAGkAXwBzAGUAdABfAGQAcgB2AGQAYQB0AGEAKAApAA== x-cr-puzzleid: {456FB285-5000-41BC-92D3-45BD01FAC3C8} X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrGIsWRmVeSWpSXmKPExsVy+t8zY91VaYZBBn0z2CwuL7zEanGi7wOr xbqHL5gs1s+/xebA4vHqwh0Wj74tqxg9jt/YzuTxeZNcAEsUl01Kak5mWWqRvl0CV8bCQzvY Cz6xVhx9epaxgfEtSxcjJ4eEgIlEw4MFbBC2mMSFe+uBbC4OIYFljBIb1x9n6mLkACtq3ywJ EV/EKHHoylqool+MEvve7WEE6WYTUJP48uUwO4gtIpAiMfdpL1icWcBTYsKfflYQW0jAVmLp m9tgmzkF7CS+HFsItllYwEui591UZhCbRUBVYu+7LUwgNi9Q/Z1TrxkhbEGJH5PvsUDM1JJY v/M4E4QtL7F5zVtmiEPVJR791YU4wUji8f/XUOUiEvtevGMEuVlCYAarxKG/ZxkhPjaV+LOp mQUi8ZZdYvvap6wQRwhIfJt8iAViqKzEpgPMEPWSEgdX3GCZwCg1C8lJs5CcNAvJSbOQ7F7A yLKKUTS1ILmgOCm9yFCvODG3uDQvXS85P3cTIySOe3cw3j5gfYgxGWj9RGYp0eR8YBrIK4k3 NDYzsjA1MTU2Mrc0I01YSZxXrcU6UEggPbEkNTs1tSC1KL6oNCe1+BAjEwenVANj4lMr45D4 pdz/17Y97xCJ2X2i+Wr2J42pVwwy//qfuPkx2lvh3+p/i3UTGFcURBjd1yg4knywLnWKhqGs 7hJNjwIFtZt7FmWe3rdqUqO8wesc9ay3P1IEsh5sk3zXk82gUJ7SdlL8+7fz851n31Pf0/ui /rdyUE2A8pS2FcyqTC/KDTMPhCQrsRRnJBpqMRcVJwIA3y6AvvkCAAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFjrMKsWRmVeSWpSXmKPExsVy+t9jAd1VaYZBBgc3MllcXniJ1eJE3wdW i3UPXzBZrJ9/i82BxePVhTssHn1bVjF6HL+xncnj8ya5AJaoBkabjNTElNQihdS85PyUzLx0 WyXv4HjneFMzA0NdQ0sLcyWFvMTcVFslF58AXbfMHKCdSgpliTmlQKGAxOJiJX07TBNCQ9x0 LWAaI3R9Q4LgeowM0EDCOsaMhYd2sBd8Yq04+vQsYwPjW5YuRg4OCQETifbNkl2MnECmmMSF e+vZuhi5OIQEFjFKHLqyFsr5xSix790eRpAqNgE1iS9fDrOD2CICKRJzn/aCxZkFPCUm/Oln BbGFBGwllr65zQJicwrYSXw5tpANxBYW8JLoeTeVGcRmEVCV2PtuCxOIzQtUf+fUa0YIW1Di x+R7LBAztSTW7zzOBGHLS2xe85YZ4mh1iUd/dSFOMJJ4/P81VLmIxL4X7xhBbpYQmMEqcejv WUaIz0wl/mxqZpnAKDILyYpZSFbMQrJiFpJZCxhZVjGKphYkFxQnpeca6hUn5haX5qXrJefn bmIEJ4lnUjsYVzZYHGIU4GBU4uHtmGUQJMSaWFZcmXuIUYKDWUmEN97cMEiINyWxsiq1KD++ qDQntfgQYzIwBCYyS4km5wMTWF5JvKGxiZmRpZGZhZGJuTlpwkrivAdarQOFBNITS1KzU1ML UotgtjBxcEo1MFY9Ym3Yu/o0w/Yus8eqZ+8t4w/2fOVSeXrmd47qN3kd/JGL5765nvtjydlc EUHn3UweATq7d7KrCNet5P1btHFmQWviDJmQnxmBpjl6a5fN59ydqGu5psWei/HGxqMW4gxP Nl5lYOHnP7rilvtm9wqFxd/vvEur2fbUe70Pv7nRp52TLZj3PFRiKc5INNRiLipOBAABA2nf VgMAAA== DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected Sender: linux-fbdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fbdev@vger.kernel.org X-Spam-Status: No, score=-7.8 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP The driver core clears the driver data to NULL after device_release or on probe failure. Thus, it is not needed to manually clear the device driver data to NULL. Signed-off-by: Jingoo Han --- drivers/video/tdfxfb.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/video/tdfxfb.c b/drivers/video/tdfxfb.c index 64bc28b..f761fe3 100644 --- a/drivers/video/tdfxfb.c +++ b/drivers/video/tdfxfb.c @@ -1646,7 +1646,6 @@ static void tdfxfb_remove(struct pci_dev *pdev) pci_resource_len(pdev, 1)); release_mem_region(pci_resource_start(pdev, 0), pci_resource_len(pdev, 0)); - pci_set_drvdata(pdev, NULL); fb_dealloc_cmap(&info->cmap); framebuffer_release(info); }