From patchwork Thu Sep 12 07:01:18 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jingoo Han X-Patchwork-Id: 2876541 Return-Path: X-Original-To: patchwork-linux-fbdev@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 0A98FBF43F for ; Thu, 12 Sep 2013 07:01:27 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id E59E720103 for ; Thu, 12 Sep 2013 07:01:25 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 0CD56200F0 for ; Thu, 12 Sep 2013 07:01:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753399Ab3ILHBU (ORCPT ); Thu, 12 Sep 2013 03:01:20 -0400 Received: from mailout3.samsung.com ([203.254.224.33]:65075 "EHLO mailout3.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752801Ab3ILHBU (ORCPT ); Thu, 12 Sep 2013 03:01:20 -0400 Received: from epcpsbgr1.samsung.com (u141.gpu120.samsung.co.kr [203.254.230.141]) by mailout3.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTP id <0MT000DWT3I62960@mailout3.samsung.com> for linux-fbdev@vger.kernel.org; Thu, 12 Sep 2013 16:01:18 +0900 (KST) Received: from epcpsbgm2.samsung.com ( [203.254.230.49]) by epcpsbgr1.samsung.com (EPCPMTA) with SMTP id DC.2A.30629.EB661325; Thu, 12 Sep 2013 16:01:18 +0900 (KST) X-AuditID: cbfee68d-b7fe86d0000077a5-22-523166be97f8 Received: from epmmp2 ( [203.254.227.17]) by epcpsbgm2.samsung.com (EPCPMTA) with SMTP id D8.02.05832.EB661325; Thu, 12 Sep 2013 16:01:18 +0900 (KST) Received: from DOJG1HAN03 ([12.23.120.99]) by mmp2.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTPA id <0MT000KA13I68Z00@mmp2.samsung.com>; Thu, 12 Sep 2013 16:01:18 +0900 (KST) From: Jingoo Han To: 'Jean-Christophe PLAGNIOL-VILLARD' Cc: 'Tomi Valkeinen' , linux-fbdev@vger.kernel.org, 'Jingoo Han' References: <001a01ceaf84$32c52d90$984f88b0$%han@samsung.com> In-reply-to: <001a01ceaf84$32c52d90$984f88b0$%han@samsung.com> Subject: [PATCH 20/21] video: tridentfb: remove unnecessary pci_set_drvdata() Date: Thu, 12 Sep 2013 16:01:18 +0900 Message-id: <002e01ceaf85$e18453a0$a48cfae0$%han@samsung.com> MIME-version: 1.0 Content-type: text/plain; charset=us-ascii Content-transfer-encoding: 7bit X-Mailer: Microsoft Office Outlook 12.0 Thread-index: Ac6vhDKuTCwbnQ4aTDC9KoLwWMziagAAZ+ow Content-language: ko X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFjrNIsWRmVeSWpSXmKPExsVy+t8zQ919aYZBBp/va1tcXniJ1eJE3wdW i3UPXzBZrJ9/i82BxePVhTssHn1bVjF6HL+xncnj8ya5AJYoLpuU1JzMstQifbsEroxNjyYx Flxmqzh5bCZrA+MN1i5GTg4JAROJzUuXskHYYhIX7q0Hs4UEljFKHDxg1cXIAVbz/hpHFyMX UHg6o8S3C6dYIWp+MUpsWcoOYrMJqEl8+XIYzBYRsJNYePESWA2zQL7EliVtUPW2Ekvf3GYB sTmBar4cWwi2S1jAV+JI90awOIuAqsSJe3cZQWxeoPoF8/qZIGxBiR+T77FAzNSSWL/zOBOE LS+xec1bZog71SUe/dWFOMFI4nXzV6gSEYl9L94xgtwvIXCMXeLxkiNQuwQkvk0+xALRKyux 6QAzJBgkJQ6uuMEygVFiFpLNs5BsnoVk8ywkKxYwsqxiFE0tSC4oTkovMtQrTswtLs1L10vO z93ECInI3h2Mtw9YH2JMBlo/kVlKNDkfGNF5JfGGxmZGFqYmpsZG5pZmpAkrifOqtVgHCgmk J5akZqemFqQWxReV5qQWH2Jk4uCUamDUWGD1cONxnY5p8krlrGGHWwV/9z7gnS1i4nv3eoDN 8U0bq6cvdqmelliw7MzdA0ZRbMn3T9ty9C69fkTx5Zqt54q5tfhW2KdxTttz9dMjpvhtHvnP l23bLWu5ZE7Wtf6q8zOd+JKf88pnrXg4a4v6Kv5/fw53eiqFruCQNA4Sm7lkj47Cz9e6SizF GYmGWsxFxYkAkculfd4CAAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrJKsWRmVeSWpSXmKPExsVy+t9jQd19aYZBBt/ma1hcXniJ1eJE3wdW i3UPXzBZrJ9/i82BxePVhTssHn1bVjF6HL+xncnj8ya5AJaoBkabjNTElNQihdS85PyUzLx0 WyXv4HjneFMzA0NdQ0sLcyWFvMTcVFslF58AXbfMHKCdSgpliTmlQKGAxOJiJX07TBNCQ9x0 LWAaI3R9Q4LgeowM0EDCOsaMTY8mMRZcZqs4eWwmawPjDdYuRg4OCQETiffXOLoYOYFMMYkL 99azdTFycQgJTGeU+HbhFCtIQkjgF6PElqXsIDabgJrEly+HwWwRATuJhRcvgdUwC+RLbFnS BlVvK7H0zW0WEJsTqObLsYVsILawgK/Eke6NYHEWAVWJE/fuMoLYvED1C+b1M0HYghI/Jt9j gZipJbF+53EmCFteYvOat8wQN6tLPPqrC3GCkcTr5q9QJSIS+168Y5zAKDQLyaRZSCbNQjJp FpKWBYwsqxhFUwuSC4qT0nON9IoTc4tL89L1kvNzNzGCI/6Z9A7GVQ0WhxgFOBiVeHg7ZhkE CbEmlhVX5h5ilOBgVhLhjTc3DBLiTUmsrEotyo8vKs1JLT7EmAz06ERmKdHkfGAyyiuJNzQ2 MTOyNDKzMDIxNydNWEmc92CrdaCQQHpiSWp2ampBahHMFiYOTqkGxrVGLub/vCfr+5j80Eq5 5PRk+f7ayn/WC9J+lpQLTI2zeSlnf1OCKfyoRY/OVIXA775yH6b+eDpni//h0IMajPMN2X8+ rZxt+U/4d9ddSa5Pe5veHzcoUW8X9bMS6Qw96iWsWb/s5ffV0fFq/9ISW6uu7qq/J6owtW3n VXfJ1WmdO9jeaT7WVWIpzkg01GIuKk4EAOyZ6uc8AwAA DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected Sender: linux-fbdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fbdev@vger.kernel.org X-Spam-Status: No, score=-7.8 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP The driver core clears the driver data to NULL after device_release or on probe failure. Thus, it is not needed to manually clear the device driver data to NULL. Signed-off-by: Jingoo Han --- drivers/video/tridentfb.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/video/tridentfb.c b/drivers/video/tridentfb.c index ab57d38..7ed9a22 100644 --- a/drivers/video/tridentfb.c +++ b/drivers/video/tridentfb.c @@ -1553,7 +1553,6 @@ static void trident_pci_remove(struct pci_dev *dev) iounmap(info->screen_base); release_mem_region(tridentfb_fix.smem_start, tridentfb_fix.smem_len); release_mem_region(tridentfb_fix.mmio_start, tridentfb_fix.mmio_len); - pci_set_drvdata(dev, NULL); kfree(info->pixmap.addr); fb_dealloc_cmap(&info->cmap); framebuffer_release(info);