From patchwork Mon Dec 8 02:17:39 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jingoo Han X-Patchwork-Id: 5453721 Return-Path: X-Original-To: patchwork-linux-fbdev@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 7668D9F30B for ; Mon, 8 Dec 2014 02:16:18 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 8A99C2012B for ; Mon, 8 Dec 2014 02:16:17 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 2F7CC20125 for ; Mon, 8 Dec 2014 02:16:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752703AbaLHCQO (ORCPT ); Sun, 7 Dec 2014 21:16:14 -0500 Received: from mailout1.samsung.com ([203.254.224.24]:26573 "EHLO mailout1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751072AbaLHCQN (ORCPT ); Sun, 7 Dec 2014 21:16:13 -0500 Received: from epcpsbgr3.samsung.com (u143.gpu120.samsung.co.kr [203.254.230.143]) by mailout1.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTP id <0NG80045XRMZU460@mailout1.samsung.com> for linux-fbdev@vger.kernel.org; Mon, 08 Dec 2014 11:16:11 +0900 (KST) Received: from epcpsbgm1.samsung.com ( [203.254.230.47]) by epcpsbgr3.samsung.com (EPCPMTA) with SMTP id 3A.2F.18484.BE905845; Mon, 08 Dec 2014 11:16:11 +0900 (KST) X-AuditID: cbfee68f-f791c6d000004834-a5-548509eb7682 Received: from epmmp1.local.host ( [203.254.227.16]) by epcpsbgm1.samsung.com (EPCPMTA) with SMTP id AE.8C.20081.AE905845; Mon, 08 Dec 2014 11:16:10 +0900 (KST) Received: from DOJG1HAN03 ([10.89.38.123]) by mmp1.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTPA id <0NG800239RMYZ440@mmp1.samsung.com>; Mon, 08 Dec 2014 11:16:10 +0900 (KST) From: Jingoo Han To: 'Sean Paul' Cc: milo.kim@ti.com, linux-fbdev@vger.kernel.org, arnd@arndb.de, lee.jones@linaro.org, cooloney@gmail.com, 'Jingoo Han' References: <1417805069-20441-1-git-send-email-seanpaul@chromium.org> <1417805069-20441-4-git-send-email-seanpaul@chromium.org> In-reply-to: <1417805069-20441-4-git-send-email-seanpaul@chromium.org> Subject: Re: [PATCH 4/4] backlight/lp855x: Remove CONFIG_OF ifdef in favor of Kconfig depends Date: Mon, 08 Dec 2014 11:17:39 +0900 Message-id: <003601d0128d$23c70a80$6b551f80$%han@samsung.com> MIME-version: 1.0 Content-type: text/plain; charset=us-ascii Content-transfer-encoding: 7bit X-Mailer: Microsoft Office Outlook 12.0 Thread-index: AdAQu4nE4VZ3AaqiQYOMRsOrohLXngB0UKkA Content-language: ko X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFrrEIsWRmVeSWpSXmKPExsVy+t8zfd3XnK0hBiuvslj8nXSM3eLozolM FpcXXmK1uP/1KKPFib4PrBbLf61jsbi74SyjA7vH71+TGD1mN1xk8dg56y67x51re9g8+ras YvQ4fmM7k8fnTXIB7FFcNimpOZllqUX6dglcGc++LWcsuCxY8XXDRpYGxo18XYycHBICJhJN R6ewQNhiEhfurWfrYuTiEBJYxijxu2EnC0zRl6kTWEFsIYFFjBIH+/whin4xSuz/tAIswSag JvHly2F2EFtEQF3i2t/tLCBFzAL9jBJrnvyCGtvIKHHtxiOwsZwCbhI3m68wg9jCAvESB45t AJvEIqAqseLsJTCbV8BWonfaDkYIW1Dix+R7YL3MAloS63ceZ4Kw5SU2r3kLNIcD6FR1iUd/ dSGOMJLY8Q9iDLOAiMS+F+8YQW6QEPjLLvF6z1moXQIS3yYfYoHolZXYdIAZ4mNJiYMrbrBM YJSYhWTzLCSbZyHZPAvJigWMLKsYRVMLkguKk9KLjPWKE3OLS/PS9ZLzczcxQqK6fwfj3QPW hxgFOBiVeHgXPGgJEWJNLCuuzD3EaAp00URmKdHkfGDqyCuJNzQ2M7IwNTE1NjK3NFMS510o 9TNYSCA9sSQ1OzW1ILUovqg0J7X4ECMTB6dUA+PBC6u/RR2NaV+5N8o1Y+3/cibtT1fcJCQ2 Wab9jPydWZil47yY+86K7Q/q50rlSmRf+P3Npoula9Zts/W8wslTJBROBjcLL1l+LGL+LyZ1 6YY1JQzVAi8F/nuoOp/ku7jJojPniOfD9M+6xz6fTmY40f34nYTHt5xXimvuT0vwWxyTx5Rj ekCJpTgj0VCLuag4EQCIq6sE5QIAAA== X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFprDKsWRmVeSWpSXmKPExsVy+t9jAd1XnK0hBv+f2lj8nXSM3eLozolM FpcXXmK1uP/1KKPFib4PrBbLf61jsbi74SyjA7vH71+TGD1mN1xk8dg56y67x51re9g8+ras YvQ4fmM7k8fnTXIB7FENjDYZqYkpqUUKqXnJ+SmZeem2St7B8c7xpmYGhrqGlhbmSgp5ibmp tkouPgG6bpk5QBcpKZQl5pQChQISi4uV9O0wTQgNcdO1gGmM0PUNCYLrMTJAAwnrGDOefVvO WHBZsOLrho0sDYwb+boYOTkkBEwkvkydwAphi0lcuLeeDcQWEljEKHGwz7+LkQvI/sUosf/T CrAiNgE1iS9fDrOD2CIC6hLX/m5nASliFuhnlFjz5BcbREcjo8S1G49YQKo4BdwkbjZfYQax hQXiJQ4c2wA2iUVAVWLF2UtgNq+ArUTvtB2MELagxI/J98B6mQW0JNbvPM4EYctLbF7zFmgO B9Cp6hKP/upCHGEkseMfxBhmARGJfS/eMU5gFJqFZNIsJJNmIZk0C0nLAkaWVYyiqQXJBcVJ 6bmGesWJucWleel6yfm5mxjBKeOZ1A7GlQ0WhxgFOBiVeHgXPGgJEWJNLCuuzD3EKMHBrCTC u/wzUIg3JbGyKrUoP76oNCe1+BCjKdCjE5mlRJPzgeksryTe0NjEzMjSyMzCyMTcXEmc98bN 3BAhgfTEktTs1NSC1CKYPiYOTqkGxjbtjXM64k7M/ZF+vIXhTPbpzUkrtrredZ1uc3qVzttv wj3dzQq3f04TSueojjqUExy/Q3e/xKOf6+J6Xm9ryTWadzdvrt/Ev4uf5j31fya9x2SPpth8 O8VP/Q9l4824bp3gfrhTuir+x12HYzo3VBLtlM+6PbpyInL209/vPuwQXs4q9F/1A7MSS3FG oqEWc1FxIgARfQK2LwMAAA== DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected Sender: linux-fbdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fbdev@vger.kernel.org X-Spam-Status: No, score=-6.9 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, T_RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP On Saturday, December 06, 2014 3:44 AM, Sean Paul wrote: > > Now that we've removed all traces of pdata, remove the CONFIG_OF ifdef > from lp855x and instead make the driver depend on OF. > > Signed-off-by: Sean Paul > --- > drivers/video/backlight/Kconfig | 2 +- > drivers/video/backlight/lp855x_bl.c | 7 ------- > 2 files changed, 1 insertion(+), 8 deletions(-) > > diff --git a/drivers/video/backlight/Kconfig b/drivers/video/backlight/Kconfig > index 8d03924..113c8b3 100644 > --- a/drivers/video/backlight/Kconfig > +++ b/drivers/video/backlight/Kconfig > @@ -384,7 +384,7 @@ config BACKLIGHT_LM3639 > > config BACKLIGHT_LP855X > tristate "Backlight driver for TI LP855X" > - depends on BACKLIGHT_CLASS_DEVICE && I2C && PWM > + depends on BACKLIGHT_CLASS_DEVICE && I2C && PWM && OF > help > This supports TI LP8550, LP8551, LP8552, LP8553, LP8555, LP8556 and > LP8557 backlight driver. > diff --git a/drivers/video/backlight/lp855x_bl.c b/drivers/video/backlight/lp855x_bl.c > index 8b81d8e..3d3b8cf 100644 > --- a/drivers/video/backlight/lp855x_bl.c > +++ b/drivers/video/backlight/lp855x_bl.c > @@ -379,7 +379,6 @@ static const struct attribute_group lp855x_attr_group = { > .attrs = lp855x_attributes, > }; > > -#ifdef CONFIG_OF > static int lp855x_parse_dt(struct lp855x *lp) > { > struct device *dev = lp->dev; > @@ -425,12 +424,6 @@ static int lp855x_parse_dt(struct lp855x *lp) > > return 0; > } > -#else > -static int lp855x_parse_dt(struct lp855x *lp) > -{ > - return -EINVAL; > -} > -#endif > > static int lp855x_probe(struct i2c_client *cl, const struct i2c_device_id *id) > { One more thin, in this case, of_match_ptr() is redundant; thus, of_match_ptr() can be also removed as follows. Best regards, Jingoo Han > -- > 2.2.0.rc0.207.ga3a616c --- To unsubscribe from this list: send the line "unsubscribe linux-fbdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html --- a/drivers/video/backlight/lp855x_bl.c +++ b/drivers/video/backlight/lp855x_bl.c @@ -487,7 +487,7 @@ MODULE_DEVICE_TABLE(i2c, lp855x_ids); static struct i2c_driver lp855x_driver = { .driver = { .name = "lp855x", - .of_match_table = of_match_ptr(lp855x_dt_ids), + .of_match_table = lp855x_dt_ids, }, .probe = lp855x_probe, .remove = lp855x_remove,