From patchwork Tue Apr 8 04:53:10 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jingoo Han X-Patchwork-Id: 3947741 Return-Path: X-Original-To: patchwork-linux-fbdev@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 244D29F371 for ; Tue, 8 Apr 2014 04:53:21 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 5553C2022A for ; Tue, 8 Apr 2014 04:53:20 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id E506520225 for ; Tue, 8 Apr 2014 04:53:18 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1750768AbaDHExS (ORCPT ); Tue, 8 Apr 2014 00:53:18 -0400 Received: from mailout3.samsung.com ([203.254.224.33]:31960 "EHLO mailout3.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750710AbaDHExQ (ORCPT ); Tue, 8 Apr 2014 00:53:16 -0400 Received: from epcpsbgr2.samsung.com (u142.gpu120.samsung.co.kr [203.254.230.142]) by mailout3.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTP id <0N3P003F648RTFC0@mailout3.samsung.com> for linux-fbdev@vger.kernel.org; Tue, 08 Apr 2014 13:53:15 +0900 (KST) Received: from epcpsbgm1.samsung.com ( [203.254.230.50]) by epcpsbgr2.samsung.com (EPCPMTA) with SMTP id 3A.FD.09028.BB083435; Tue, 08 Apr 2014 13:53:15 +0900 (KST) X-AuditID: cbfee68e-b7f566d000002344-b2-534380bbc169 Received: from epmmp1.local.host ( [203.254.227.16]) by epcpsbgm1.samsung.com (EPCPMTA) with SMTP id 12.82.29263.AB083435; Tue, 08 Apr 2014 13:53:14 +0900 (KST) Received: from DOJG1HAN03 ([12.36.166.146]) by mmp1.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTPA id <0N3P0064V48MNV20@mmp1.samsung.com>; Tue, 08 Apr 2014 13:53:14 +0900 (KST) From: Jingoo Han To: 'Tomi Valkeinen' Cc: linux-fbdev@vger.kernel.org, 'Jean-Christophe Plagniol-Villard' , 'Dan Carpenter' , 'Daniel Mack' , 'Jingoo Han' References: <001c01cf4ed1$07117630$15346290$%han@samsung.com> In-reply-to: <001c01cf4ed1$07117630$15346290$%han@samsung.com> Subject: [PATCH V2] video: pxa3xx-gcu: use devm_ioremap_resource() Date: Tue, 08 Apr 2014 13:53:10 +0900 Message-id: <008201cf52e6$7314ea60$593ebf20$%han@samsung.com> MIME-version: 1.0 Content-type: text/plain; charset=us-ascii Content-transfer-encoding: 7bit X-Mailer: Microsoft Office Outlook 12.0 Thread-index: Ac9O0QDJZ8YZ/z2bTumK/gpT+tfNqAEFVUiw Content-language: ko x-cr-hashedpuzzle: Bhnz FasQ KWHV MuwK XbWi flcE hPLp jhzo pOrp wve/ 2ecb 2i6g 5WDs 8sM/ AAHwcA== AA/jbA==; 6; ZABhAG4ALgBjAGEAcgBwAGUAbgB0AGUAcgBAAG8AcgBhAGMAbABlAC4AYwBvAG0AOwBqAGcAMQAuAGgAYQBuAEAAcwBhAG0AcwB1AG4AZwAuAGMAbwBtADsAbABpAG4AdQB4AC0AZgBiAGQAZQB2AEAAdgBnAGUAcgAuAGsAZQByAG4AZQBsAC4AbwByAGcAOwBwAGwAYQBnAG4AaQBvAGoAQABqAGMAcgBvAHMAbwBmAHQALgBjAG8AbQA7AHQAbwBtAGkALgB2AGEAbABrAGUAaQBuAGUAbgBAAHQAaQAuAGMAbwBtADsAegBvAG4AcQB1AGUAQABnAG0AYQBpAGwALgBjAG8AbQA=; Sosha1_v1; 7; {5DD94685-8084-4694-98B2-2F64CA6E2564}; agBnADEALgBoAGEAbgBAAHMAYQBtAHMAdQBuAGcALgBjAG8AbQA=; Tue, 08 Apr 2014 04:53:00 GMT; WwBQAEEAVABDAEgAIABWADIAXQAgAHYAaQBkAGUAbwA6ACAAcAB4AGEAMwB4AHgALQBnAGMAdQA6ACAAdQBzAGUAIABkAGUAdgBtAF8AaQBvAHIAZQBtAGEAcABfAHIAZQBzAG8AdQByAGMAZQAoACkA x-cr-puzzleid: {5DD94685-8084-4694-98B2-2F64CA6E2564} X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFvrJIsWRmVeSWpSXmKPExsVy+t8zI93dDc7BBm1XeS1e/5vOYnF54SVW ixN9H1gt1j18wWSxfv4tNovOGeuZHNg8ds66y+7x6sIdFo+PT2+xePRtWcXocfzGdiaPz5vk AtiiuGxSUnMyy1KL9O0SuDLWLv3PWLCMs2L3m7ksDYzv2bsYOTkkBEwkJj37wQJhi0lcuLee DcQWEljGKHH5eAZMzd9tM5i6GLmA4osYJY7u38oO4fxmlNh6dRYjSBWbgJrEly+HwaaKCOhI TFrUwwxiMwtcZpRov+oEMdVWYsGsjWAbOAXsJG5f/QdWLyzgJLFnIcRmFgFViR2dd8B6eYHq G34tgbIFJX5MvscCMVNLYv3O40wQtrzE5jVvgWo4gC5Vl3j0VxfiBCOJOee+sUGUiEjse/GO EeKZH6wSLz44QtimErePfmcE+UVCoJFDYsPr+ewQNwhIfJt8iAVipqzEpgPMEPWSEgdX3GCZ wCg1C8lFs5BcNAvJRbOQrF7AyLKKUTS1ILmgOCm9yEivODG3uDQvXS85P3cTIyTa+3Yw3jxg fYgxGWj9RGYp0eR8YLLIK4k3NDYzsjA1MTU2Mrc0I01YSZx30cOkICGB9MSS1OzU1ILUovii 0pzU4kOMTBycUg2MCluV636kzDoQP+lz87LrIr8vfuqrjTmbLXuY4dlJ7ad7BS2nP9t66dGO GTWRL59tvBLn1hkSM/FMlXi+j8VLCZ6ZKuLdUlPSo2b4nbvmfUz9YqFQ0SPtt1c6e541vfV9 +/Q6y44P6nNveFybqtnV8Hj2hem1k9c7VbL9EAhYnFjddU1n+svJm5RYijMSDbWYi4oTAeTr ASkMAwAA X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFrrOKsWRmVeSWpSXmKPExsVy+t9jAd1dDc7BBh8/y1m8/jedxeLywkus Fif6PrBarHv4gsli/fxbbBadM9YzObB57Jx1l93j1YU7LB4fn95i8ejbsorR4/iN7UwenzfJ BbBFNTDaZKQmpqQWKaTmJeenZOal2yp5B8c7x5uaGRjqGlpamCsp5CXmptoqufgE6Lpl5gDd oaRQlphTChQKSCwuVtK3wzQhNMRN1wKmMULXNyQIrsfIAA0krGPMWLv0P2PBMs6K3W/msjQw vmfvYuTkkBAwkfi7bQYThC0mceHeerYuRi4OIYFFjBJH929lh3B+M0psvTqLEaSKTUBN4suX w2DdIgI6EpMW9TCD2MwClxkl2q86gdhCArYSC2ZtZAOxOQXsJG5f/QdWLyzgJLFn4XqwOIuA qsSOzjtgvbxA9Q2/lkDZghI/Jt9jgZipJbF+53EmCFteYvOat0A1HECXqks8+qsLcYKRxJxz 39ggSkQk9r14xwjxzA9WiRcfHCFsU4nbR78zTmAUmYVkwywkG2Yh2TALyagFjCyrGEVTC5IL ipPScw31ihNzi0vz0vWS83M3MYKTyTOpHYwrGywOMQpwMCrx8FYecQoWYk0sK67MPcQowcGs JMKb4uwcLMSbklhZlVqUH19UmpNafIgxGRgAE5mlRJPzgYkuryTe0NjEzMjSyMzCyMTcnDRh JXHeA63WgUIC6YklqdmpqQWpRTBbmDg4pRoYHdSlxbbc42K0PjVv3Xprdf6f2wMUnkzgmaKQ baBxX9LrjvbaZmMPjzn/Vd4ZKc/YyXLsf9mCOwcUWWNr2dbsNg//lsZ8Y67WvG7rWXosnoWS eu9/Ch4s3sjYz/pHmvERf4rsj34dq49Oi4LlcmsrSncuk/7xcFfE31xdjekf5Swjd7rlpyxW YinOSDTUYi4qTgQApJkswGoDAAA= DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected Sender: linux-fbdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fbdev@vger.kernel.org X-Spam-Status: No, score=-7.2 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Use devm_ioremap_resource() because devm_request_and_ioremap() is obsoleted by devm_ioremap_resource(). Signed-off-by: Jingoo Han Cc: Daniel Mack Cc: Dan Carpenter --- Changes since v1: - remove unnecessary error message, because devm_ioremap_resource() already prints one in all failure cases. drivers/video/fbdev/pxa3xx-gcu.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/video/fbdev/pxa3xx-gcu.c b/drivers/video/fbdev/pxa3xx-gcu.c index 417f9a2..4df3657 100644 --- a/drivers/video/fbdev/pxa3xx-gcu.c +++ b/drivers/video/fbdev/pxa3xx-gcu.c @@ -612,11 +612,9 @@ static int pxa3xx_gcu_probe(struct platform_device *pdev) /* handle IO resources */ r = platform_get_resource(pdev, IORESOURCE_MEM, 0); - priv->mmio_base = devm_request_and_ioremap(dev, r); - if (IS_ERR(priv->mmio_base)) { - dev_err(dev, "failed to map I/O memory\n"); + priv->mmio_base = devm_ioremap_resource(dev, r); + if (IS_ERR(priv->mmio_base)) return PTR_ERR(priv->mmio_base); - } /* enable the clock */ priv->clk = devm_clk_get(dev, NULL);