From patchwork Thu Aug 25 19:51:57 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ajay Kumar X-Patchwork-Id: 1096422 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by demeter2.kernel.org (8.14.4/8.14.4) with ESMTP id p7PDsmIF015693 for ; Thu, 25 Aug 2011 13:54:51 GMT Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751398Ab1HYNyv (ORCPT ); Thu, 25 Aug 2011 09:54:51 -0400 Received: from mailout2.samsung.com ([203.254.224.25]:23837 "EHLO mailout2.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750846Ab1HYNyu (ORCPT ); Thu, 25 Aug 2011 09:54:50 -0400 Received: from epcpsbgm1.samsung.com (mailout2.samsung.com [203.254.224.25]) by mailout2.samsung.com (Oracle Communications Messaging Exchange Server 7u4-19.01 64bit (built Sep 7 2010)) with ESMTP id <0LQH00ISYLB94JU0@mailout2.samsung.com>; Thu, 25 Aug 2011 22:54:49 +0900 (KST) X-AuditID: cbfee61a-b7cf1ae00000208e-78-4e565429f0bb Received: from epmmp1 ( [203.254.227.16]) by epcpsbgm1.samsung.com (MMPCPMTA) with SMTP id 12.32.08334.924565E4; Thu, 25 Aug 2011 22:54:49 +0900 (KST) Received: from localhost.localdomain ([107.108.73.106]) by mmp1.samsung.com (iPlanet Messaging Server 5.2 Patch 2 (built Jul 14 2004)) with ESMTPA id <0LQH00D1NLB42L@mmp1.samsung.com>; Thu, 25 Aug 2011 22:54:49 +0900 (KST) Date: Thu, 25 Aug 2011 15:51:57 -0400 From: Ajay Kumar Subject: [PATCH 2/2] video: s3c-fb: Modify s3c-fb driver to support window positioning In-reply-to: <1314301917-9938-1-git-send-email-ajaykumar.rs@samsung.com> To: linux-samsung-soc@vger.kernel.org, linux-fbdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org Cc: FlorianSchandinat@gmx.de, lethal@linux-sh.org, jg1.han@samsung.com, m.szyprowski@samsung.com, ben-linux@fluff.org, banajit.g@samsung.com Message-id: <1314301917-9938-3-git-send-email-ajaykumar.rs@samsung.com> X-Mailer: git-send-email 1.7.0.4 Content-transfer-encoding: 7BIT References: <1314301917-9938-1-git-send-email-ajaykumar.rs@samsung.com> X-Brightmail-Tracker: AAAAAA== Sender: linux-fbdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fbdev@vger.kernel.org X-Greylist: IP, sender and recipient auto-whitelisted, not delayed by milter-greylist-4.2.6 (demeter2.kernel.org [140.211.167.43]); Thu, 25 Aug 2011 13:54:51 +0000 (UTC) This patch modifies the existing s3c-fb driver to provide flexibility to the user to reposition the framebuffer windows. Signed-off-by: Ajay Kumar Signed-off-by: Banajit Goswami --- drivers/video/s3c-fb.c | 37 ++++++++++++++++++++++++++++++++----- 1 files changed, 32 insertions(+), 5 deletions(-) diff --git a/drivers/video/s3c-fb.c b/drivers/video/s3c-fb.c index 0fda252..41179d7 100644 --- a/drivers/video/s3c-fb.c +++ b/drivers/video/s3c-fb.c @@ -442,6 +442,7 @@ static int s3c_fb_set_par(struct fb_info *info) struct fb_var_screeninfo *var = &info->var; struct s3c_fb_win *win = info->par; struct s3c_fb *sfb = win->parent; + struct s3cfb_window_pos *winpos = &win->windata->winpos; void __iomem *regs = sfb->regs; void __iomem *buf = regs; int win_no = win->index; @@ -539,12 +540,13 @@ static int s3c_fb_set_par(struct fb_info *info) /* write 'OSD' registers to control position of framebuffer */ - data = VIDOSDxA_TOPLEFT_X(0) | VIDOSDxA_TOPLEFT_Y(0); + data = VIDOSDxA_TOPLEFT_X(winpos->win_pos_x) | + VIDOSDxA_TOPLEFT_Y(winpos->win_pos_y); writel(data, regs + VIDOSD_A(win_no, sfb->variant)); - data = VIDOSDxB_BOTRIGHT_X(s3c_fb_align_word(var->bits_per_pixel, - var->xres - 1)) | - VIDOSDxB_BOTRIGHT_Y(var->yres - 1); + data = VIDOSDxB_BOTRIGHT_X((s3c_fb_align_word(var->bits_per_pixel, + (winpos->win_pos_x + var->xres - 1)))) | + VIDOSDxB_BOTRIGHT_Y((winpos->win_pos_y + var->yres - 1)); writel(data, regs + VIDOSD_B(win_no, sfb->variant)); @@ -999,8 +1001,10 @@ static int s3c_fb_ioctl(struct fb_info *info, unsigned int cmd, { struct s3c_fb_win *win = info->par; struct s3c_fb *sfb = win->parent; - int ret; + struct s3cfb_window_pos *winpos = &win->windata->winpos; + int ret = 0; u32 crtc; + u32 data; switch (cmd) { case FBIO_WAITFORVSYNC: @@ -1011,6 +1015,29 @@ static int s3c_fb_ioctl(struct fb_info *info, unsigned int cmd, ret = s3c_fb_wait_for_vsync(sfb, crtc); break; + case S3CFB_WIN_POSITION: + if (copy_from_user(winpos, (u32 __user *)arg, + sizeof(struct s3cfb_window_pos))) { + ret = -EFAULT; + break; + } + + shadow_protect_win(win, 1); + + /* write 'OSD' registers to set position of the window */ + data = VIDOSDxA_TOPLEFT_X(winpos->win_pos_x) | + VIDOSDxA_TOPLEFT_Y(winpos->win_pos_y); + writel(data, sfb->regs + VIDOSD_A(win->index, sfb->variant)); + + data = VIDOSDxB_BOTRIGHT_X( + s3c_fb_align_word(info->var.bits_per_pixel, + (winpos->win_pos_x + info->var.xres - 1))); + data |= VIDOSDxB_BOTRIGHT_Y(winpos->win_pos_y + + info->var.yres - 1); + writel(data, sfb->regs + VIDOSD_B(win->index, sfb->variant)); + + shadow_protect_win(win, 0); + break; default: ret = -ENOTTY; }