From patchwork Wed Aug 31 13:23:19 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tomi Valkeinen X-Patchwork-Id: 1116092 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by demeter1.kernel.org (8.14.4/8.14.4) with ESMTP id p7VDNvQ8023643 for ; Wed, 31 Aug 2011 13:23:58 GMT Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755798Ab1HaNXx (ORCPT ); Wed, 31 Aug 2011 09:23:53 -0400 Received: from na3sys009aog118.obsmtp.com ([74.125.149.244]:59138 "EHLO na3sys009aog118.obsmtp.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755773Ab1HaNXu (ORCPT ); Wed, 31 Aug 2011 09:23:50 -0400 Received: from mail-wy0-f172.google.com ([74.125.82.172]) (using TLSv1) by na3sys009aob118.postini.com ([74.125.148.12]) with SMTP ID DSNKTl415D4EP/ApdJoy0J7v5qQlNE+d1yWD@postini.com; Wed, 31 Aug 2011 06:23:50 PDT Received: by mail-wy0-f172.google.com with SMTP id 8so727792wyg.17 for ; Wed, 31 Aug 2011 06:23:48 -0700 (PDT) Received: by 10.227.27.194 with SMTP id j2mr375266wbc.96.1314797028373; Wed, 31 Aug 2011 06:23:48 -0700 (PDT) Received: from localhost.localdomain (a62-248-128-208.elisa-laajakaista.fi [62.248.128.208]) by mx.google.com with ESMTPS id fm9sm5476855wbb.27.2011.08.31.06.23.46 (version=SSLv3 cipher=OTHER); Wed, 31 Aug 2011 06:23:47 -0700 (PDT) From: Tomi Valkeinen To: linux-omap@vger.kernel.org, linux-fbdev@vger.kernel.org Cc: archit@ti.com, mythripk@ti.com, Tomi Valkeinen Subject: [PATCH 08/12] OMAP: DSS2: HDMI: remove error prints in check_timings Date: Wed, 31 Aug 2011 16:23:19 +0300 Message-Id: <1314797003-17638-9-git-send-email-tomi.valkeinen@ti.com> X-Mailer: git-send-email 1.7.4.1 In-Reply-To: <1314797003-17638-1-git-send-email-tomi.valkeinen@ti.com> References: <1314797003-17638-1-git-send-email-tomi.valkeinen@ti.com> Sender: linux-fbdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fbdev@vger.kernel.org X-Greylist: IP, sender and recipient auto-whitelisted, not delayed by milter-greylist-4.2.6 (demeter1.kernel.org [140.211.167.41]); Wed, 31 Aug 2011 13:23:58 +0000 (UTC) check_timings() is supposed to be used to verify if timings are ok or not. Currently the HDMI driver prints error messages if the timings are not ok. This is not right, as it is no error to give invalid timings to check_timings(). Remove the error prints. Signed-off-by: Tomi Valkeinen --- drivers/video/omap2/dss/hdmi.c | 1 - drivers/video/omap2/dss/hdmi_omap4_panel.c | 6 +----- 2 files changed, 1 insertions(+), 6 deletions(-) diff --git a/drivers/video/omap2/dss/hdmi.c b/drivers/video/omap2/dss/hdmi.c index 34e05ee..55edbd2 100644 --- a/drivers/video/omap2/dss/hdmi.c +++ b/drivers/video/omap2/dss/hdmi.c @@ -1105,7 +1105,6 @@ int omapdss_hdmi_display_check_timing(struct omap_dss_device *dssdev, cm = hdmi_get_code(timings); if (cm.code == -1) { - DSSERR("Invalid timing entered\n"); return -EINVAL; } diff --git a/drivers/video/omap2/dss/hdmi_omap4_panel.c b/drivers/video/omap2/dss/hdmi_omap4_panel.c index 5e314e8..ffea8d3 100644 --- a/drivers/video/omap2/dss/hdmi_omap4_panel.c +++ b/drivers/video/omap2/dss/hdmi_omap4_panel.c @@ -170,11 +170,7 @@ static int hdmi_check_timings(struct omap_dss_device *dssdev, mutex_lock(&hdmi.hdmi_lock); r = omapdss_hdmi_display_check_timing(dssdev, timings); - if (r) { - DSSERR("Timing cannot be applied\n"); - goto err; - } -err: + mutex_unlock(&hdmi.hdmi_lock); return r; }