From patchwork Wed Aug 8 03:54:15 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sean Paul X-Patchwork-Id: 1292331 Return-Path: X-Original-To: patchwork-linux-fbdev@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork2.kernel.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by patchwork2.kernel.org (Postfix) with ESMTP id 79F73DF223 for ; Wed, 8 Aug 2012 03:54:36 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751370Ab2HHDyg (ORCPT ); Tue, 7 Aug 2012 23:54:36 -0400 Received: from mail-pb0-f46.google.com ([209.85.160.46]:48841 "EHLO mail-pb0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756127Ab2HHDyf (ORCPT ); Tue, 7 Aug 2012 23:54:35 -0400 Received: by mail-pb0-f46.google.com with SMTP id rr13so760482pbb.19 for ; Tue, 07 Aug 2012 20:54:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:to:cc:subject:date:message-id:x-mailer:in-reply-to:references; bh=vB/7PNROf6E1enGJ+GuQenbtJFnrSYTeljnA0cBp79U=; b=IYtmC2KKYNBmQv0ZYbaeImQUWEJQdXuhvETM0F0DgoQk7SzOlZDtANGfdTU+RWAnLq iCs3cI5KC1Fykrxo31K5AzqMdoxOxO7YvzJG3C2xQW7WNsQ6qw1o2lwUWO3koDaIKV5c g1sDTpRC0ZwgV5kz251s/WbgpKIovQq2c/tKs= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=from:to:cc:subject:date:message-id:x-mailer:in-reply-to:references :x-gm-message-state; bh=vB/7PNROf6E1enGJ+GuQenbtJFnrSYTeljnA0cBp79U=; b=lHerCM8uUQXsikaXNEe6tp14FW89tFbe3WDTGuorxs/emUL0sdUq+5ILUk2kc1rceL 3MMFGw3SRaSO35mk2R/lq0SmkkLc2r8ZeWKOlppHRNVZTZf0LUrjetOrC3K02YFFT5sX 0TnYXauA7VEJZ9ou68t47KofTsfMJF4/yLAcFWOici0K1VFl0Ki9yhlSrE+1wpAL5gmM /+0dO4UWy/5+r/81q2/LwodMh/mOcq1fvW+MsR7pGRbTS9Wn2+Vl9m3hV++l/le+1VOc d3l3bNoBSIyZbblqmV6mCSvE/L+ZK7fsmLktJC9a9rWxAGHeva7wCuGN71KOiCo+qUEb KsXw== Received: by 10.66.75.162 with SMTP id d2mr30700966paw.59.1344398075110; Tue, 07 Aug 2012 20:54:35 -0700 (PDT) Received: from anush.mtv.corp.google.com (anush.mtv.corp.google.com [172.22.73.28]) by mx.google.com with ESMTPS id hx9sm12461756pbc.68.2012.08.07.20.54.34 (version=TLSv1/SSLv3 cipher=OTHER); Tue, 07 Aug 2012 20:54:34 -0700 (PDT) From: Sean Paul To: jg1.han@samsung.com, linux-fbdev@vger.kernel.org Cc: Sean Paul Subject: [PATCH 01/10] video: exynos_dp: Change aux transaction failures Date: Tue, 7 Aug 2012 20:54:15 -0700 Message-Id: <1344398064-13563-2-git-send-email-seanpaul@chromium.org> X-Mailer: git-send-email 1.7.7.3 In-Reply-To: <1344398064-13563-1-git-send-email-seanpaul@chromium.org> References: <1344398064-13563-1-git-send-email-seanpaul@chromium.org> X-Gm-Message-State: ALoCoQkYzDzBgAyNUeWExjn448ua64/lzddRFWgPpVcuxZb5AeU6GTgk3/TC7ezTGxjMrfjEXUoq Sender: linux-fbdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fbdev@vger.kernel.org This patch adds the function name to aux transaction failure messages so we can tell which transaction is failing. It also changes the level of Aux Transaction fail messages from error to debug. We retry the transactions a few times and will report errors if warranted outside of this function. Signed-off-by: Sean Paul Reviewed-by: Doug Anderson Reviewed-by: Bernie Thompson Acked-by: Jingoo Han --- drivers/video/exynos/exynos_dp_reg.c | 21 ++++++++++++++------- 1 files changed, 14 insertions(+), 7 deletions(-) diff --git a/drivers/video/exynos/exynos_dp_reg.c b/drivers/video/exynos/exynos_dp_reg.c index ce401c8..a121bed 100644 --- a/drivers/video/exynos/exynos_dp_reg.c +++ b/drivers/video/exynos/exynos_dp_reg.c @@ -471,7 +471,8 @@ int exynos_dp_write_byte_to_dpcd(struct exynos_dp_device *dp, if (retval == 0) break; else - dev_err(dp->dev, "Aux Transaction fail!\n"); + dev_dbg(dp->dev, "%s: Aux Transaction fail!\n", + __func__); } return retval; @@ -511,7 +512,8 @@ int exynos_dp_read_byte_from_dpcd(struct exynos_dp_device *dp, if (retval == 0) break; else - dev_err(dp->dev, "Aux Transaction fail!\n"); + dev_dbg(dp->dev, "%s: Aux Transaction fail!\n", + __func__); } /* Read data buffer */ @@ -575,7 +577,8 @@ int exynos_dp_write_bytes_to_dpcd(struct exynos_dp_device *dp, if (retval == 0) break; else - dev_err(dp->dev, "Aux Transaction fail!\n"); + dev_dbg(dp->dev, "%s: Aux Transaction fail!\n", + __func__); } start_offset += cur_data_count; @@ -632,7 +635,8 @@ int exynos_dp_read_bytes_from_dpcd(struct exynos_dp_device *dp, if (retval == 0) break; else - dev_err(dp->dev, "Aux Transaction fail!\n"); + dev_dbg(dp->dev, "%s: Aux Transaction fail!\n", + __func__); } for (cur_data_idx = 0; cur_data_idx < cur_data_count; @@ -677,7 +681,7 @@ int exynos_dp_select_i2c_device(struct exynos_dp_device *dp, /* Start AUX transaction */ retval = exynos_dp_start_aux_transaction(dp); if (retval != 0) - dev_err(dp->dev, "Aux Transaction fail!\n"); + dev_dbg(dp->dev, "%s: Aux Transaction fail!\n", __func__); return retval; } @@ -717,7 +721,8 @@ int exynos_dp_read_byte_from_i2c(struct exynos_dp_device *dp, if (retval == 0) break; else - dev_err(dp->dev, "Aux Transaction fail!\n"); + dev_dbg(dp->dev, "%s: Aux Transaction fail!\n", + __func__); } /* Read data */ @@ -777,7 +782,9 @@ int exynos_dp_read_bytes_from_i2c(struct exynos_dp_device *dp, if (retval == 0) break; else - dev_err(dp->dev, "Aux Transaction fail!\n"); + dev_dbg(dp->dev, + "%s: Aux Transaction fail!\n", + __func__); } /* Check if Rx sends defer */ reg = readl(dp->reg_base + EXYNOS_DP_AUX_RX_COMM);