From patchwork Tue Aug 21 06:09:48 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tomi Valkeinen X-Patchwork-Id: 1352381 Return-Path: X-Original-To: patchwork-linux-fbdev@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork1.kernel.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by patchwork1.kernel.org (Postfix) with ESMTP id 17EE840210 for ; Tue, 21 Aug 2012 06:10:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753469Ab2HUGKj (ORCPT ); Tue, 21 Aug 2012 02:10:39 -0400 Received: from na3sys009aog126.obsmtp.com ([74.125.149.155]:35593 "EHLO na3sys009aog126.obsmtp.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752663Ab2HUGKh (ORCPT ); Tue, 21 Aug 2012 02:10:37 -0400 Received: from mail-lb0-f171.google.com ([209.85.217.171]) (using TLSv1) by na3sys009aob126.postini.com ([74.125.148.12]) with SMTP ID DSNKUDMmWy3MsFtbnRIFnyN09n/bLumEc2zD@postini.com; Mon, 20 Aug 2012 23:10:37 PDT Received: by lbol12 with SMTP id l12so3616463lbo.2 for ; Mon, 20 Aug 2012 23:10:34 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=from:to:cc:subject:date:message-id:x-mailer:in-reply-to:references :x-gm-message-state; bh=ickd6cUkwK0NWxo4jAZkrRphEZJsH/Or6yctI2+k8do=; b=F5Ek1xt9jSF8HWrF23eiqHFy5X4LprkLAj2UDHtEBJvo5DhTteohzWRLAFwY1gQ3Tt PZlUhMguJ6tGLuBHN5T2uI0Du5f5XNxHqEyeBM47p26pReD/vMYSYAI13JgebI4UTOtA vdcMQ4kjv1qZOKGYcNZCmNTXUURf4x9UBCe49CPZB+P1CQVvuLvivuL4lnBtzkXMU6S2 kvxdVAGAMAleRvS8tfGZgxhNaXkn1OaeBAXcTVmlcVRfnoyU1ipLZwa7FlF+lquVvsHh Tkg3lgDEwrBMZ6qUj64ldq3xDzy5t71YvRidOLBf0maDFmu7Xh/UWZvka5fA2zX1UDlb TckQ== Received: by 10.152.112.234 with SMTP id it10mr16182705lab.36.1345529434012; Mon, 20 Aug 2012 23:10:34 -0700 (PDT) Received: from localhost.localdomain (a91-156-160-115.elisa-laajakaista.fi. [91.156.160.115]) by mx.google.com with ESMTPS id ta2sm562054lab.15.2012.08.20.23.10.32 (version=SSLv3 cipher=OTHER); Mon, 20 Aug 2012 23:10:33 -0700 (PDT) From: Tomi Valkeinen To: Florian Tobias Schandinat Cc: linux-fbdev@vger.kernel.org, linux-omap@vger.kernel.org, Grazvydas Ignotas , Tomi Valkeinen Subject: [PATCH 2/2] OMAPFB: fix framebuffer console colors Date: Tue, 21 Aug 2012 09:09:48 +0300 Message-Id: <1345529388-3509-3-git-send-email-tomi.valkeinen@ti.com> X-Mailer: git-send-email 1.7.9.5 In-Reply-To: <1345529388-3509-1-git-send-email-tomi.valkeinen@ti.com> References: <1345529388-3509-1-git-send-email-tomi.valkeinen@ti.com> X-Gm-Message-State: ALoCoQn9ELX9ynkT/hD1dkP8m81bxhEsObkx/AasRHoSClLq8Kp2xgcUK4mTbyJKz3vKRyIAMjuw Sender: linux-fbdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fbdev@vger.kernel.org From: Grazvydas Ignotas omapfb does not currently set pseudo palette correctly for color depths above 16bpp, making red text invisible, command like echo -e '\e[0;31mRED' > /dev/tty1 will display nothing on framebuffer console in 24bpp mode. This is because temporary variable is declared incorrectly, fix it. Signed-off-by: Grazvydas Ignotas Cc: stable@vger.kernel.org # v3.x Signed-off-by: Tomi Valkeinen --- drivers/video/omap2/omapfb/omapfb-main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/video/omap2/omapfb/omapfb-main.c b/drivers/video/omap2/omapfb/omapfb-main.c index 08ec1a7..fc671d3 100644 --- a/drivers/video/omap2/omapfb/omapfb-main.c +++ b/drivers/video/omap2/omapfb/omapfb-main.c @@ -1192,7 +1192,7 @@ static int _setcolreg(struct fb_info *fbi, u_int regno, u_int red, u_int green, break; if (regno < 16) { - u16 pal; + u32 pal; pal = ((red >> (16 - var->red.length)) << var->red.offset) | ((green >> (16 - var->green.length)) <<