From patchwork Thu Aug 23 13:45:10 2012
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
X-Patchwork-Submitter: Tomi Valkeinen <tomi.valkeinen@ti.com>
X-Patchwork-Id: 1367221
Return-Path: <linux-fbdev-owner@vger.kernel.org>
X-Original-To: patchwork-linux-fbdev@patchwork.kernel.org
Delivered-To: patchwork-process-083081@patchwork2.kernel.org
Received: from vger.kernel.org (vger.kernel.org [209.132.180.67])
	by patchwork2.kernel.org (Postfix) with ESMTP id EF541DF2AB
	for <patchwork-linux-fbdev@patchwork.kernel.org>;
	Thu, 23 Aug 2012 13:45:43 +0000 (UTC)
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S933878Ab2HWNpm (ORCPT
	<rfc822;patchwork-linux-fbdev@patchwork.kernel.org>);
	Thu, 23 Aug 2012 09:45:42 -0400
Received: from na3sys009aog128.obsmtp.com ([74.125.149.141]:41452 "EHLO
	na3sys009aog128.obsmtp.com" rhost-flags-OK-OK-OK-OK)
	by vger.kernel.org with ESMTP id S933655Ab2HWNpl (ORCPT
	<rfc822;linux-fbdev@vger.kernel.org>);
	Thu, 23 Aug 2012 09:45:41 -0400
Received: from mail-lb0-f177.google.com ([209.85.217.177]) (using TLSv1) by
	na3sys009aob128.postini.com ([74.125.148.12]) with SMTP
	ID DSNKUDY0BFajJFl0P5jEs71AsxjwyX2gEuHL@postini.com;
	Thu, 23 Aug 2012 06:45:40 PDT
Received: by lbbgf7 with SMTP id gf7so514765lbb.8
	for <linux-fbdev@vger.kernel.org>;
	Thu, 23 Aug 2012 06:45:38 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
	d=google.com; s=20120113;
	h=from:to:cc:subject:date:message-id:x-mailer:in-reply-to:references
	:x-gm-message-state;
	bh=dQJpbE85vgHiK4Gy5CXE1uukaw7llz9w+ZzjlO/hcKQ=;
	b=TDcAbpJkUtOaj/uSDrf9Wte7xZgxi/PpBgwAcFD0/h6DYZHO7RwKm9u9xBK5aFTWN5
	MXz6YEkmbYlZp5GO5iWbB35etxy+ds0SDgIuvEYNoVQMi/s/1iyquCDmbeKN2kf63DNb
	8oI5GaYYpORWgTy9nqb7UJVCndR2ADLizdjM+7VjqEp9pINXGH7CvH8AkR7CopXI5JE6
	elqaYSjeSIomejzM0FkQ55g10YHfpsPtnhf8IXqlUwR5okAYtO0K29DoJzdrx1QWHNO+
	DXNFpTsPJ3zr/gQoZIkefOHhxPz/BRqJLRalA4yaLvskgdUc7ByqEpCRpWpiv15ljHTB
	39uw==
Received: by 10.112.28.7 with SMTP id x7mr937402lbg.54.1345729538434;
	Thu, 23 Aug 2012 06:45:38 -0700 (PDT)
Received: from localhost.localdomain (a91-156-160-115.elisa-laajakaista.fi.
	[91.156.160.115])
	by mx.google.com with ESMTPS id fz8sm466816lbb.9.2012.08.23.06.45.36
	(version=SSLv3 cipher=OTHER); Thu, 23 Aug 2012 06:45:37 -0700 (PDT)
From: Tomi Valkeinen <tomi.valkeinen@ti.com>
To: archit@ti.com
Cc: linux-omap@vger.kernel.org, linux-fbdev@vger.kernel.org,
	Tomi Valkeinen <tomi.valkeinen@ti.com>
Subject: [PATCH 4/8] OMAPDSS: HDMI: use vdda_hdmi_dac
Date: Thu, 23 Aug 2012 16:45:10 +0300
Message-Id: <1345729514-2441-5-git-send-email-tomi.valkeinen@ti.com>
X-Mailer: git-send-email 1.7.9.5
In-Reply-To: <1345729514-2441-1-git-send-email-tomi.valkeinen@ti.com>
References: <1345729514-2441-1-git-send-email-tomi.valkeinen@ti.com>
X-Gm-Message-State: 
 ALoCoQmYCQvpsn2U0TSDRgQT+u7zgtsYbCMe/k1JJUGlSPuFf3zoz8MHzc3K2U0S3+Z9gLmArFpt
Sender: linux-fbdev-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-fbdev.vger.kernel.org>
X-Mailing-List: linux-fbdev@vger.kernel.org

The HDMI driver requires vdda_hdmi_dac power for operation, but does not
enable it. This has worked because the regulator has been always
enabled.

But this may not always be the case, as I encountered when implementing
HDMI device tree support.

This patch changes the HDMI driver to use the vdda_hdmi_dac.

Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ti.com>
---
 drivers/video/omap2/dss/hdmi.c |   23 +++++++++++++++++++++++
 1 file changed, 23 insertions(+)

diff --git a/drivers/video/omap2/dss/hdmi.c b/drivers/video/omap2/dss/hdmi.c
index 96a6e29..ccfc677 100644
--- a/drivers/video/omap2/dss/hdmi.c
+++ b/drivers/video/omap2/dss/hdmi.c
@@ -33,6 +33,7 @@
 #include <linux/pm_runtime.h>
 #include <linux/clk.h>
 #include <linux/gpio.h>
+#include <linux/regulator/consumer.h>
 #include <video/omapdss.h>
 
 #include "ti_hdmi.h"
@@ -62,6 +63,7 @@ static struct {
 	struct hdmi_ip_data ip_data;
 
 	struct clk *sys_clk;
+	struct regulator *vdda_hdmi_dac_reg;
 
 	int ct_cp_hpd_gpio;
 	int ls_oe_gpio;
@@ -331,6 +333,19 @@ static int __init hdmi_init_display(struct omap_dss_device *dssdev)
 
 	dss_init_hdmi_ip_ops(&hdmi.ip_data);
 
+	if (hdmi.vdda_hdmi_dac_reg == NULL) {
+		struct regulator *reg;
+
+		reg = devm_regulator_get(&hdmi.pdev->dev, "vdda_hdmi_dac");
+
+		if (IS_ERR(reg)) {
+			DSSERR("can't get VDDA_HDMI_DAC regulator\n");
+			return PTR_ERR(reg);
+		}
+
+		hdmi.vdda_hdmi_dac_reg = reg;
+	}
+
 	r = gpio_request_array(gpios, ARRAY_SIZE(gpios));
 	if (r)
 		return r;
@@ -495,6 +510,10 @@ static int hdmi_power_on(struct omap_dss_device *dssdev)
 	/* wait 300us after CT_CP_HPD for the 5V power output to reach 90% */
 	udelay(300);
 
+	r = regulator_enable(hdmi.vdda_hdmi_dac_reg);
+	if (r)
+		goto err_vdac_enable;
+
 	r = hdmi_runtime_get();
 	if (r)
 		goto err_runtime_get;
@@ -562,6 +581,8 @@ err_phy_enable:
 err_pll_enable:
 	hdmi_runtime_put();
 err_runtime_get:
+	regulator_disable(hdmi.vdda_hdmi_dac_reg);
+err_vdac_enable:
 	gpio_set_value(hdmi.ct_cp_hpd_gpio, 0);
 	gpio_set_value(hdmi.ls_oe_gpio, 0);
 	return -EIO;
@@ -576,6 +597,8 @@ static void hdmi_power_off(struct omap_dss_device *dssdev)
 	hdmi.ip_data.ops->pll_disable(&hdmi.ip_data);
 	hdmi_runtime_put();
 
+	regulator_disable(hdmi.vdda_hdmi_dac_reg);
+
 	gpio_set_value(hdmi.ct_cp_hpd_gpio, 0);
 	gpio_set_value(hdmi.ls_oe_gpio, 0);
 }