| Message ID | 1382333533-32740-1-git-send-email-sachin.kamat@linaro.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Monday 21 October 2013 11:02 AM, Sachin Kamat wrote: > 'pdev' is not used anymore (Removed vide commit 7e0be9f9 "video: > exynos_mipi_dsim: Use the generic PHY driver"). Remove it and > silence the following compilation warning: > drivers/video/exynos/exynos_mipi_dsi.c:144:26: warning: > unused variable ‘pdev’ [-Wunused-variable] > > Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org> Reviewed-by: Kishon Vijay Abraham I <kishon@ti.com> > --- > drivers/video/exynos/exynos_mipi_dsi.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/video/exynos/exynos_mipi_dsi.c b/drivers/video/exynos/exynos_mipi_dsi.c > index 00b3a52..cee9602 100644 > --- a/drivers/video/exynos/exynos_mipi_dsi.c > +++ b/drivers/video/exynos/exynos_mipi_dsi.c > @@ -141,7 +141,6 @@ static int exynos_mipi_dsi_early_blank_mode(struct mipi_dsim_device *dsim, > > static int exynos_mipi_dsi_blank_mode(struct mipi_dsim_device *dsim, int power) > { > - struct platform_device *pdev = to_platform_device(dsim->dev); > struct mipi_dsim_lcd_driver *client_drv = dsim->dsim_lcd_drv; > struct mipi_dsim_lcd_device *client_dev = dsim->dsim_lcd_dev; > > -- To unsubscribe from this list: send the line "unsubscribe linux-fbdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 24 October 2013 21:25, Kishon Vijay Abraham I <kishon@ti.com> wrote: > On Monday 21 October 2013 11:02 AM, Sachin Kamat wrote: >> 'pdev' is not used anymore (Removed vide commit 7e0be9f9 "video: >> exynos_mipi_dsim: Use the generic PHY driver"). Remove it and >> silence the following compilation warning: >> drivers/video/exynos/exynos_mipi_dsi.c:144:26: warning: >> unused variable ‘pdev’ [-Wunused-variable] >> >> Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org> > Reviewed-by: Kishon Vijay Abraham I <kishon@ti.com> Thanks Kishon. I believe this patch should go through Greg's tree as your other patches are lined up there?
On Fri, Oct 25, 2013 at 10:51:48AM +0530, Sachin Kamat wrote: > On 24 October 2013 21:25, Kishon Vijay Abraham I <kishon@ti.com> wrote: > > On Monday 21 October 2013 11:02 AM, Sachin Kamat wrote: > >> 'pdev' is not used anymore (Removed vide commit 7e0be9f9 "video: > >> exynos_mipi_dsim: Use the generic PHY driver"). Remove it and > >> silence the following compilation warning: > >> drivers/video/exynos/exynos_mipi_dsi.c:144:26: warning: > >> unused variable ‘pdev’ [-Wunused-variable] > >> > >> Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org> > > Reviewed-by: Kishon Vijay Abraham I <kishon@ti.com> > > Thanks Kishon. > > I believe this patch should go through Greg's tree as your other > patches are lined up there? I don't take drivers/video/* patches now, am I? greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-fbdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 30 October 2013 04:30, Greg Kroah-Hartman <gregkh@linuxfoundation.org> wrote: > On Fri, Oct 25, 2013 at 10:51:48AM +0530, Sachin Kamat wrote: >> On 24 October 2013 21:25, Kishon Vijay Abraham I <kishon@ti.com> wrote: >> > On Monday 21 October 2013 11:02 AM, Sachin Kamat wrote: >> >> 'pdev' is not used anymore (Removed vide commit 7e0be9f9 "video: >> >> exynos_mipi_dsim: Use the generic PHY driver"). Remove it and >> >> silence the following compilation warning: >> >> drivers/video/exynos/exynos_mipi_dsi.c:144:26: warning: >> >> unused variable ‘pdev’ [-Wunused-variable] >> >> >> >> Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org> >> > Reviewed-by: Kishon Vijay Abraham I <kishon@ti.com> >> >> Thanks Kishon. >> >> I believe this patch should go through Greg's tree as your other >> patches are lined up there? > > I don't take drivers/video/* patches now, am I? Actually the patch that introduced this warning is lined up in your usb-next tree [1] as part of the phy series patches sent by Kishon. That is the reason I thought this one should go though your (usb) tree as well for now. Alternatively we can wait for rc-1 and then send it through the video tree if you prefer it that way. [1] https://git.kernel.org/cgit/linux/kernel/git/gregkh/usb.git/commit/?h=usb-next&id=7e0be9f9f7cba3356f75b86737dbe3a005da067e
On Wed, Oct 30, 2013 at 08:42:12AM +0530, Sachin Kamat wrote: > On 30 October 2013 04:30, Greg Kroah-Hartman <gregkh@linuxfoundation.org> wrote: > > On Fri, Oct 25, 2013 at 10:51:48AM +0530, Sachin Kamat wrote: > >> On 24 October 2013 21:25, Kishon Vijay Abraham I <kishon@ti.com> wrote: > >> > On Monday 21 October 2013 11:02 AM, Sachin Kamat wrote: > >> >> 'pdev' is not used anymore (Removed vide commit 7e0be9f9 "video: > >> >> exynos_mipi_dsim: Use the generic PHY driver"). Remove it and > >> >> silence the following compilation warning: > >> >> drivers/video/exynos/exynos_mipi_dsi.c:144:26: warning: > >> >> unused variable ‘pdev’ [-Wunused-variable] > >> >> > >> >> Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org> > >> > Reviewed-by: Kishon Vijay Abraham I <kishon@ti.com> > >> > >> Thanks Kishon. > >> > >> I believe this patch should go through Greg's tree as your other > >> patches are lined up there? > > > > I don't take drivers/video/* patches now, am I? > > Actually the patch that introduced this warning is lined up in your > usb-next tree [1] > as part of the phy series patches sent by Kishon. That is the reason I > thought this > one should go though your (usb) tree as well for now. Alternatively we > can wait for > rc-1 and then send it through the video tree if you prefer it that way. > > [1] https://git.kernel.org/cgit/linux/kernel/git/gregkh/usb.git/commit/?h=usb-next&id=7e0be9f9f7cba3356f75b86737dbe3a005da067e Please send it after 3.13-rc1 is out, as this isn't a big deal. That way you can go through the "normal" tree. thanks, greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-fbdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi Tomi, On 24 October 2013 21:25, Kishon Vijay Abraham I <kishon@ti.com> wrote: > On Monday 21 October 2013 11:02 AM, Sachin Kamat wrote: >> 'pdev' is not used anymore (Removed vide commit 7e0be9f9 "video: >> exynos_mipi_dsim: Use the generic PHY driver"). Remove it and >> silence the following compilation warning: >> drivers/video/exynos/exynos_mipi_dsi.c:144:26: warning: >> unused variable ‘pdev’ [-Wunused-variable] >> >> Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org> > Reviewed-by: Kishon Vijay Abraham I <kishon@ti.com> Now that phy patchset and your tree is already merged into Linus' tree, please queue this patch in your tree.
diff --git a/drivers/video/exynos/exynos_mipi_dsi.c b/drivers/video/exynos/exynos_mipi_dsi.c index 00b3a52..cee9602 100644 --- a/drivers/video/exynos/exynos_mipi_dsi.c +++ b/drivers/video/exynos/exynos_mipi_dsi.c @@ -141,7 +141,6 @@ static int exynos_mipi_dsi_early_blank_mode(struct mipi_dsim_device *dsim, static int exynos_mipi_dsi_blank_mode(struct mipi_dsim_device *dsim, int power) { - struct platform_device *pdev = to_platform_device(dsim->dev); struct mipi_dsim_lcd_driver *client_drv = dsim->dsim_lcd_drv; struct mipi_dsim_lcd_device *client_dev = dsim->dsim_lcd_dev;
'pdev' is not used anymore (Removed vide commit 7e0be9f9 "video: exynos_mipi_dsim: Use the generic PHY driver"). Remove it and silence the following compilation warning: drivers/video/exynos/exynos_mipi_dsi.c:144:26: warning: unused variable ‘pdev’ [-Wunused-variable] Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org> --- drivers/video/exynos/exynos_mipi_dsi.c | 1 - 1 file changed, 1 deletion(-)