From patchwork Tue Oct 22 17:26:52 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Johan Hovold X-Patchwork-Id: 3084201 Return-Path: X-Original-To: patchwork-linux-fbdev@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 9CCB4BF924 for ; Tue, 22 Oct 2013 17:29:33 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 8879F20211 for ; Tue, 22 Oct 2013 17:29:32 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 2907520251 for ; Tue, 22 Oct 2013 17:29:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753861Ab3JVR24 (ORCPT ); Tue, 22 Oct 2013 13:28:56 -0400 Received: from mail-la0-f49.google.com ([209.85.215.49]:53600 "EHLO mail-la0-f49.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753739Ab3JVR1P (ORCPT ); Tue, 22 Oct 2013 13:27:15 -0400 Received: by mail-la0-f49.google.com with SMTP id eh20so2036242lab.8 for ; Tue, 22 Oct 2013 10:27:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=n/7KOLN5qb/Zs2zpc3sQ6Ew0Za/fSd3epu0WRnOwGGs=; b=d0UCRWdmXK+Nj4zSvvqK/OaqtsEPMH0O3Y/r/7aCo1evNMC5I0o1kBA9Q5vTO+4sK8 KysolKJc63fBpJIrEw5tZ+jYOMGmbpdusW+DfNs+pyUFynYIooLaaQ+CcF6D+ou6iCTm s6CkbPAM5PGLaopEsBH1kB8iw41I6nC9fsrffzoOdcI2FZV2M+wfSP6flFA06qQ73b+3 cuF+6KyMeOU0Zga/8A0i5TXRzM2vsYs4rFNzhqQSwHcOpYB9hAlfPSkQvZeYNpvWEfOB 5WGyf3MjX8GY5/57Fc0Usd99BtkPY9JpPuTnMsVWg5OPyImMSZ6koV2+sh4tcegZGTqq Dbkg== X-Received: by 10.112.52.225 with SMTP id w1mr6232316lbo.31.1382462833841; Tue, 22 Oct 2013 10:27:13 -0700 (PDT) Received: from xi.terra (c193-14-141-227.cust.tele2.se. [193.14.141.227]) by mx.google.com with ESMTPSA id pw4sm16437892lbb.9.2013.10.22.10.27.11 for (version=TLSv1.2 cipher=RC4-SHA bits=128/128); Tue, 22 Oct 2013 10:27:11 -0700 (PDT) Received: from johan by xi.terra with local (Exim 4.80.1) (envelope-from ) id 1VYfja-0007Rt-3P; Tue, 22 Oct 2013 19:27:10 +0200 From: Johan Hovold To: Richard Purdie , Jingoo Han Cc: Nicolas Ferre , linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org, Johan Hovold , stable@vger.kernel.org Subject: [PATCH 2/9] backlight: atmel-pwm-bl: fix gpio polarity in remove Date: Tue, 22 Oct 2013 19:26:52 +0200 Message-Id: <1382462819-28576-3-git-send-email-jhovold@gmail.com> X-Mailer: git-send-email 1.8.4 In-Reply-To: <1382462819-28576-1-git-send-email-jhovold@gmail.com> References: <1382462819-28576-1-git-send-email-jhovold@gmail.com> Sender: linux-fbdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fbdev@vger.kernel.org X-Spam-Status: No, score=-7.2 required=5.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, T_DKIM_INVALID, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Make sure to honour gpio polarity also at remove so that the backlight is actually disabled on boards with active-low enable pin. Cc: stable@vger.kernel.org Signed-off-by: Johan Hovold Acked-by: Jingoo Han --- drivers/video/backlight/atmel-pwm-bl.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/video/backlight/atmel-pwm-bl.c b/drivers/video/backlight/atmel-pwm-bl.c index 8aac273..3cb0094 100644 --- a/drivers/video/backlight/atmel-pwm-bl.c +++ b/drivers/video/backlight/atmel-pwm-bl.c @@ -205,8 +205,10 @@ static int atmel_pwm_bl_remove(struct platform_device *pdev) { struct atmel_pwm_bl *pwmbl = platform_get_drvdata(pdev); - if (pwmbl->gpio_on != -1) - gpio_set_value(pwmbl->gpio_on, 0); + if (pwmbl->gpio_on != -1) { + gpio_set_value(pwmbl->gpio_on, + 0 ^ pwmbl->pdata->on_active_low); + } pwm_channel_disable(&pwmbl->pwmc); pwm_channel_free(&pwmbl->pwmc);