From patchwork Wed Oct 23 09:55:36 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Johan Hovold X-Patchwork-Id: 3087541 Return-Path: X-Original-To: patchwork-linux-fbdev@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork1.web.kernel.org (Postfix) with ESMTP id F10A69F2B7 for ; Wed, 23 Oct 2013 09:59:26 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id E8345202E6 for ; Wed, 23 Oct 2013 09:59:25 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id C950C20138 for ; Wed, 23 Oct 2013 09:59:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752531Ab3JWJ7C (ORCPT ); Wed, 23 Oct 2013 05:59:02 -0400 Received: from mail-lb0-f172.google.com ([209.85.217.172]:44666 "EHLO mail-lb0-f172.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752834Ab3JWJ4B (ORCPT ); Wed, 23 Oct 2013 05:56:01 -0400 Received: by mail-lb0-f172.google.com with SMTP id c11so520074lbj.31 for ; Wed, 23 Oct 2013 02:55:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=F04AZGY8zTR2CT/ZjsJCe1SpiRWn+BsPrwab2/GPiAo=; b=BMc7igWiLK1l2r1njGmImDxQNK9UXcKTKJabBVeGDIWuGwq1zf8u0F6RMvVkEVPnJo EQaMxpZ2+VLWmcQNZkSykRRq/Qe7WK1Alnu88SP1PAiEQ567Me3L39+fZ645XH4JxeDC tJ7m5Ztk9DhUhdZS8qTgF0YDpWWa1ABuJcyX1wVg6FOGmPv5I4Rojls7sN4sxJSBrDjO /2Euo4F+6KLZYPjTP3ARf+ObdMg7CO51WnTUjmQnPbeD321flNRv0VPdw+Qw+WpgkIgh Ujrdp//rj6g87Ajl08z5RAKRjNgo6f8CXo3nCahC+R6QsUwTOw6iH4J7KywZcyqZjGqk 5u9A== X-Received: by 10.152.23.137 with SMTP id m9mr548341laf.17.1382522159041; Wed, 23 Oct 2013 02:55:59 -0700 (PDT) Received: from xi.terra (c193-14-141-227.cust.tele2.se. [193.14.141.227]) by mx.google.com with ESMTPSA id w10sm18792437lbv.6.2013.10.23.02.55.56 for (version=TLSv1.2 cipher=RC4-SHA bits=128/128); Wed, 23 Oct 2013 02:55:56 -0700 (PDT) Received: from johan by xi.terra with local (Exim 4.80.1) (envelope-from ) id 1VYvAP-0008MI-Mo; Wed, 23 Oct 2013 11:55:53 +0200 From: Johan Hovold To: Richard Purdie , Jingoo Han Cc: Nicolas Ferre , Tomi Valkeinen , Jean-Christophe Plagniol-Villard , Andrew Morton , linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org, Johan Hovold , stable@vger.kernel.org Subject: [PATCH 2/9] backlight: atmel-pwm-bl: fix gpio polarity in remove Date: Wed, 23 Oct 2013 11:55:36 +0200 Message-Id: <1382522143-32072-3-git-send-email-jhovold@gmail.com> X-Mailer: git-send-email 1.8.4 In-Reply-To: <1382522143-32072-1-git-send-email-jhovold@gmail.com> References: <1382522143-32072-1-git-send-email-jhovold@gmail.com> Sender: linux-fbdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fbdev@vger.kernel.org X-Spam-Status: No, score=-7.2 required=5.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, T_DKIM_INVALID, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Make sure to honour gpio polarity also at remove so that the backlight is actually disabled on boards with active-low enable pin. Cc: stable@vger.kernel.org Acked-by: Jingoo Han Signed-off-by: Johan Hovold --- drivers/video/backlight/atmel-pwm-bl.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/video/backlight/atmel-pwm-bl.c b/drivers/video/backlight/atmel-pwm-bl.c index 8aac273..3cb0094 100644 --- a/drivers/video/backlight/atmel-pwm-bl.c +++ b/drivers/video/backlight/atmel-pwm-bl.c @@ -205,8 +205,10 @@ static int atmel_pwm_bl_remove(struct platform_device *pdev) { struct atmel_pwm_bl *pwmbl = platform_get_drvdata(pdev); - if (pwmbl->gpio_on != -1) - gpio_set_value(pwmbl->gpio_on, 0); + if (pwmbl->gpio_on != -1) { + gpio_set_value(pwmbl->gpio_on, + 0 ^ pwmbl->pdata->on_active_low); + } pwm_channel_disable(&pwmbl->pwmc); pwm_channel_free(&pwmbl->pwmc);