From patchwork Tue Oct 29 16:27:44 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Johan Hovold X-Patchwork-Id: 3109491 Return-Path: X-Original-To: patchwork-linux-fbdev@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 79ECBBF924 for ; Tue, 29 Oct 2013 16:30:01 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 5D8C42035D for ; Tue, 29 Oct 2013 16:30:00 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 25E0E200D5 for ; Tue, 29 Oct 2013 16:29:59 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758363Ab3J2Q3c (ORCPT ); Tue, 29 Oct 2013 12:29:32 -0400 Received: from mail-la0-f46.google.com ([209.85.215.46]:54924 "EHLO mail-la0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758327Ab3J2Q2O (ORCPT ); Tue, 29 Oct 2013 12:28:14 -0400 Received: by mail-la0-f46.google.com with SMTP id hp15so79018lab.19 for ; Tue, 29 Oct 2013 09:28:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=BLvxWRyEv4Uo8Ac5dXkWko3m30N/fTCrxqPaRHxtJ9A=; b=rF8hSbjMV3oeI6su7++1pEfgwbYiJtJ63arAQWoYxCLzmZWsRO02ih5s3lAr3ns93e OHJyfHlJxp0/PQXg7bAX1M+Ju5RfFUMuE93M52f0NDqpJds3qU6Dbkcyvv/TahnL4fEO lkUc4gM3oRvX6wDTf7lyL94UMsQDXX5BiY+cChr3EGkYyPzfPsjDmt2aTIDJYf3fzhQL ngYf5fXMn+hkDXcQQwpq8y5OJwrPURgL8xH9MgeIC8KApB03SqJkah1fy1je5YDTOpZ2 /fEOE0h8EeU5au+WeD0Jye2PaQ9WDAkRWMmF78FnC2S6a/qMBOvDOnbpK5gJ4wSHWOlv oDsA== X-Received: by 10.152.87.79 with SMTP id v15mr270528laz.14.1383064093211; Tue, 29 Oct 2013 09:28:13 -0700 (PDT) Received: from xi.terra (c193-14-141-227.cust.tele2.se. [193.14.141.227]) by mx.google.com with ESMTPSA id o1sm26766249lah.8.2013.10.29.09.28.09 for (version=TLSv1.2 cipher=RC4-SHA bits=128/128); Tue, 29 Oct 2013 09:28:10 -0700 (PDT) Received: from johan by xi.terra with local (Exim 4.80.1) (envelope-from ) id 1VbC9G-0001KB-U4; Tue, 29 Oct 2013 17:28:06 +0100 From: Johan Hovold To: Richard Purdie , Jingoo Han Cc: Nicolas Ferre , Tomi Valkeinen , Jean-Christophe Plagniol-Villard , Andrew Morton , linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org, Johan Hovold Subject: [PATCH v2 9/9] backlight: atmel-pwm-bl: use gpio_request_one Date: Tue, 29 Oct 2013 17:27:44 +0100 Message-Id: <1383064064-4983-10-git-send-email-jhovold@gmail.com> X-Mailer: git-send-email 1.8.4.2 In-Reply-To: <1383064064-4983-1-git-send-email-jhovold@gmail.com> References: <1382522143-32072-1-git-send-email-jhovold@gmail.com> <1383064064-4983-1-git-send-email-jhovold@gmail.com> Sender: linux-fbdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fbdev@vger.kernel.org X-Spam-Status: No, score=-7.3 required=5.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, T_DKIM_INVALID, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Use devm_gpio_request_one rather than requesting and setting direction in two calls. Acked-by: Jingoo Han Signed-off-by: Johan Hovold --- drivers/video/backlight/atmel-pwm-bl.c | 15 ++++++++------- 1 file changed, 8 insertions(+), 7 deletions(-) diff --git a/drivers/video/backlight/atmel-pwm-bl.c b/drivers/video/backlight/atmel-pwm-bl.c index bd1ed34..03b5f3b 100644 --- a/drivers/video/backlight/atmel-pwm-bl.c +++ b/drivers/video/backlight/atmel-pwm-bl.c @@ -124,6 +124,7 @@ static int atmel_pwm_bl_probe(struct platform_device *pdev) const struct atmel_pwm_bl_platform_data *pdata; struct backlight_device *bldev; struct atmel_pwm_bl *pwmbl; + int flags; int retval; pdata = dev_get_platdata(&pdev->dev); @@ -149,14 +150,14 @@ static int atmel_pwm_bl_probe(struct platform_device *pdev) return retval; if (gpio_is_valid(pwmbl->gpio_on)) { - retval = devm_gpio_request(&pdev->dev, pwmbl->gpio_on, - "gpio_atmel_pwm_bl"); - if (retval) - goto err_free_pwm; - /* Turn display off by default. */ - retval = gpio_direction_output(pwmbl->gpio_on, - 0 ^ pdata->on_active_low); + if (pdata->on_active_low) + flags = GPIOF_OUT_INIT_HIGH; + else + flags = GPIOF_OUT_INIT_LOW; + + retval = devm_gpio_request_one(&pdev->dev, pwmbl->gpio_on, + flags, "gpio_atmel_pwm_bl"); if (retval) goto err_free_pwm; }