From patchwork Tue Oct 29 16:27:37 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Johan Hovold X-Patchwork-Id: 3109451 Return-Path: X-Original-To: patchwork-linux-fbdev@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork2.web.kernel.org (Postfix) with ESMTP id E5680BF924 for ; Tue, 29 Oct 2013 16:29:20 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id CD7132035D for ; Tue, 29 Oct 2013 16:29:19 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id A51C8200D5 for ; Tue, 29 Oct 2013 16:29:18 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758447Ab3J2Q2R (ORCPT ); Tue, 29 Oct 2013 12:28:17 -0400 Received: from mail-la0-f43.google.com ([209.85.215.43]:49503 "EHLO mail-la0-f43.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756925Ab3J2Q2N (ORCPT ); Tue, 29 Oct 2013 12:28:13 -0400 Received: by mail-la0-f43.google.com with SMTP id el20so80250lab.2 for ; Tue, 29 Oct 2013 09:28:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=pE9tBcXyZK9mD+jpBqSQdFCwGUVmqndRS/zulXn0Ddo=; b=eWaJ1kBu17N92Kmb2lMC0+A8vbuYx3mIRWW58j8AZZBDvSqBoLg42re46k4SCZRmy4 t1224/9hpx6ObeLwfsm8xG8Gh7IfjZ9u+HpKoJpfqQLVj79AKKiTHdj1Gx/zprFBn3Gf 7ZQAVNqFu3MMem3ycT1mG836gZKxvuoWWJDpUmcF5QrPA0RpnAc2ZnFH15QEtLOJ2UUl pD+A7RwM5MbXDWR7uYjOU2yl0r40DMixwqBS77MWUa6EKrsl4SbaVwi3HkLG/O+PfH6l uweh2mF+uZYk/6vOuPLgurNWByRj4G81QSh0rnzDrh1zJwGIwK6uA5Zd4yr9YzPZUrTZ tp0Q== X-Received: by 10.152.10.34 with SMTP id f2mr232977lab.64.1383064091438; Tue, 29 Oct 2013 09:28:11 -0700 (PDT) Received: from xi.terra (c193-14-141-227.cust.tele2.se. [193.14.141.227]) by mx.google.com with ESMTPSA id e4sm16988449lba.15.2013.10.29.09.28.09 for (version=TLSv1.2 cipher=RC4-SHA bits=128/128); Tue, 29 Oct 2013 09:28:10 -0700 (PDT) Received: from johan by xi.terra with local (Exim 4.80.1) (envelope-from ) id 1VbC9G-0001JU-Nn; Tue, 29 Oct 2013 17:28:06 +0100 From: Johan Hovold To: Richard Purdie , Jingoo Han Cc: Nicolas Ferre , Tomi Valkeinen , Jean-Christophe Plagniol-Villard , Andrew Morton , linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org, Johan Hovold , stable@vger.kernel.org Subject: [PATCH v2 2/9] backlight: atmel-pwm-bl: fix gpio polarity in remove Date: Tue, 29 Oct 2013 17:27:37 +0100 Message-Id: <1383064064-4983-3-git-send-email-jhovold@gmail.com> X-Mailer: git-send-email 1.8.4.2 In-Reply-To: <1383064064-4983-1-git-send-email-jhovold@gmail.com> References: <1382522143-32072-1-git-send-email-jhovold@gmail.com> <1383064064-4983-1-git-send-email-jhovold@gmail.com> Sender: linux-fbdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fbdev@vger.kernel.org X-Spam-Status: No, score=-7.3 required=5.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, T_DKIM_INVALID, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Make sure to honour gpio polarity also at remove so that the backlight is actually disabled on boards with active-low enable pin. Cc: stable@vger.kernel.org Acked-by: Jingoo Han Signed-off-by: Johan Hovold --- drivers/video/backlight/atmel-pwm-bl.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/video/backlight/atmel-pwm-bl.c b/drivers/video/backlight/atmel-pwm-bl.c index 0971a8e..e21beb6 100644 --- a/drivers/video/backlight/atmel-pwm-bl.c +++ b/drivers/video/backlight/atmel-pwm-bl.c @@ -205,8 +205,10 @@ static int atmel_pwm_bl_remove(struct platform_device *pdev) { struct atmel_pwm_bl *pwmbl = platform_get_drvdata(pdev); - if (pwmbl->gpio_on != -1) - gpio_set_value(pwmbl->gpio_on, 0); + if (pwmbl->gpio_on != -1) { + gpio_set_value(pwmbl->gpio_on, + 0 ^ pwmbl->pdata->on_active_low); + } pwm_channel_disable(&pwmbl->pwmc); pwm_channel_free(&pwmbl->pwmc);