From patchwork Tue Oct 29 16:27:40 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Johan Hovold X-Patchwork-Id: 3109391 Return-Path: X-Original-To: patchwork-linux-fbdev@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 81AD2BF924 for ; Tue, 29 Oct 2013 16:28:25 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 691782037D for ; Tue, 29 Oct 2013 16:28:24 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id C7F172035D for ; Tue, 29 Oct 2013 16:28:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753033Ab3J2Q2P (ORCPT ); Tue, 29 Oct 2013 12:28:15 -0400 Received: from mail-la0-f47.google.com ([209.85.215.47]:48530 "EHLO mail-la0-f47.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756783Ab3J2Q2M (ORCPT ); Tue, 29 Oct 2013 12:28:12 -0400 Received: by mail-la0-f47.google.com with SMTP id ep20so76419lab.34 for ; Tue, 29 Oct 2013 09:28:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=hkSnOCkCZ6F7LenTtTlx6eS9f7N0kZR5862zJk7W968=; b=dfTDvTxVAcUiM9ks8+biywsVDl02wBrrwu9lVHtetWX/Yq4k4NjqYb0z+r5tfcxHiP 4FVsAdk7hd8IfAIlY7ROUr/TJ0OjmfrcSu1P6oPR5GBbGCeF1PN8QSvkFbPl/AVO5l5r gai6RYr1T8nnjLmLd1Ba5dYRaopC3f3v17fBUuCWRUBcig09mMsoXFE/9ITJptofT0UB a/OBV4JrsIDzw2aj9Yp901sG0SOmWFpkWSTDzE4CKLgoL66J/jfi7tCba5x5w4udq7E5 o7ENd6Um/VKXN4HYNtQR5Ugqm3W0yeW7WQCl5xq6j6v0wNZzr+rb8XPNf/OY4e8FdLf1 HgcQ== X-Received: by 10.152.18.131 with SMTP id w3mr171537lad.47.1383064091016; Tue, 29 Oct 2013 09:28:11 -0700 (PDT) Received: from xi.terra (c193-14-141-227.cust.tele2.se. [193.14.141.227]) by mx.google.com with ESMTPSA id vk8sm17017448lbb.0.2013.10.29.09.28.09 for (version=TLSv1.2 cipher=RC4-SHA bits=128/128); Tue, 29 Oct 2013 09:28:09 -0700 (PDT) Received: from johan by xi.terra with local (Exim 4.80.1) (envelope-from ) id 1VbC9G-0001Jn-QO; Tue, 29 Oct 2013 17:28:06 +0100 From: Johan Hovold To: Richard Purdie , Jingoo Han Cc: Nicolas Ferre , Tomi Valkeinen , Jean-Christophe Plagniol-Villard , Andrew Morton , linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org, Johan Hovold Subject: [PATCH v2 5/9] backlight: atmel-pwm-bl: clean up get_intensity Date: Tue, 29 Oct 2013 17:27:40 +0100 Message-Id: <1383064064-4983-6-git-send-email-jhovold@gmail.com> X-Mailer: git-send-email 1.8.4.2 In-Reply-To: <1383064064-4983-1-git-send-email-jhovold@gmail.com> References: <1382522143-32072-1-git-send-email-jhovold@gmail.com> <1383064064-4983-1-git-send-email-jhovold@gmail.com> Sender: linux-fbdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fbdev@vger.kernel.org X-Spam-Status: No, score=-7.3 required=5.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, T_DKIM_INVALID, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Clean up get_intensity to increase readability. Acked-by: Jingoo Han Signed-off-by: Johan Hovold --- drivers/video/backlight/atmel-pwm-bl.c | 13 ++++++------- 1 file changed, 6 insertions(+), 7 deletions(-) diff --git a/drivers/video/backlight/atmel-pwm-bl.c b/drivers/video/backlight/atmel-pwm-bl.c index 01af5c2..abfaada 100644 --- a/drivers/video/backlight/atmel-pwm-bl.c +++ b/drivers/video/backlight/atmel-pwm-bl.c @@ -70,15 +70,14 @@ static int atmel_pwm_bl_set_intensity(struct backlight_device *bd) static int atmel_pwm_bl_get_intensity(struct backlight_device *bd) { struct atmel_pwm_bl *pwmbl = bl_get_data(bd); + u32 cdty; u32 intensity; - if (pwmbl->pdata->pwm_active_low) { - intensity = pwm_channel_readl(&pwmbl->pwmc, PWM_CDTY) - - pwmbl->pdata->pwm_duty_min; - } else { - intensity = pwmbl->pdata->pwm_duty_max - - pwm_channel_readl(&pwmbl->pwmc, PWM_CDTY); - } + cdty = pwm_channel_readl(&pwmbl->pwmc, PWM_CDTY); + if (pwmbl->pdata->pwm_active_low) + intensity = cdty - pwmbl->pdata->pwm_duty_min; + else + intensity = pwmbl->pdata->pwm_duty_max - cdty; return intensity & 0xffff; }