From patchwork Tue Oct 29 16:27:42 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Johan Hovold X-Patchwork-Id: 3109511 Return-Path: X-Original-To: patchwork-linux-fbdev@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork1.web.kernel.org (Postfix) with ESMTP id D12A09F2B7 for ; Tue, 29 Oct 2013 16:30:10 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id BBFD32035D for ; Tue, 29 Oct 2013 16:30:09 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 13DB7200D5 for ; Tue, 29 Oct 2013 16:30:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758159Ab3J2QaA (ORCPT ); Tue, 29 Oct 2013 12:30:00 -0400 Received: from mail-la0-f48.google.com ([209.85.215.48]:54425 "EHLO mail-la0-f48.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758279Ab3J2Q2O (ORCPT ); Tue, 29 Oct 2013 12:28:14 -0400 Received: by mail-la0-f48.google.com with SMTP id ev20so79502lab.7 for ; Tue, 29 Oct 2013 09:28:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=fn0Ahtl/ByaHaGAXIC2p1Qz8yfhYNY8gnX5EEhzzqyg=; b=T7cZp+QFAPPX6ukzMukIV2PsQND4M+jqN5zK3stXyxbnEcHSw6dwUVpXJeAtjXb7dT 5xY72irQOIBUfiXggx4GdN9EEnF6CT4RqfQ83oH4v3Qeows++PkAj2HGjsg6IYg5NPCU 25sSVL2D5jBSQ7aOODVOf14fmFQyWG3LcXtQ0bp1xxWtuJMKGzDSZL6UctDJygjesMFr bv/dc78izK4cteVr4/K77DLPS7Ql5gKQj0Q4SMtre3Ww1p36eX+Sl3xMzmIKapJ/T9ah apHn5XZUgxZK2TAs+c3AgFkpdKIzyQ2ID2blMNNupWe0M74OAfdEJQhzNcLo5zgFIai3 wvJQ== X-Received: by 10.112.145.105 with SMTP id st9mr648166lbb.46.1383064092804; Tue, 29 Oct 2013 09:28:12 -0700 (PDT) Received: from xi.terra (c193-14-141-227.cust.tele2.se. [193.14.141.227]) by mx.google.com with ESMTPSA id 8sm26737802laq.5.2013.10.29.09.28.09 for (version=TLSv1.2 cipher=RC4-SHA bits=128/128); Tue, 29 Oct 2013 09:28:10 -0700 (PDT) Received: from johan by xi.terra with local (Exim 4.80.1) (envelope-from ) id 1VbC9G-0001Jz-SY; Tue, 29 Oct 2013 17:28:06 +0100 From: Johan Hovold To: Richard Purdie , Jingoo Han Cc: Nicolas Ferre , Tomi Valkeinen , Jean-Christophe Plagniol-Villard , Andrew Morton , linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org, Johan Hovold Subject: [PATCH v2 7/9] backlight: atmel-pwm-bl: use gpio_is_valid Date: Tue, 29 Oct 2013 17:27:42 +0100 Message-Id: <1383064064-4983-8-git-send-email-jhovold@gmail.com> X-Mailer: git-send-email 1.8.4.2 In-Reply-To: <1383064064-4983-1-git-send-email-jhovold@gmail.com> References: <1382522143-32072-1-git-send-email-jhovold@gmail.com> <1383064064-4983-1-git-send-email-jhovold@gmail.com> Sender: linux-fbdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fbdev@vger.kernel.org X-Spam-Status: No, score=-7.3 required=5.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, T_DKIM_INVALID, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Use gpio_is_valid rather than open coding the more restrictive != -1 test. Acked-by: Jingoo Han Signed-off-by: Johan Hovold --- drivers/video/backlight/atmel-pwm-bl.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/video/backlight/atmel-pwm-bl.c b/drivers/video/backlight/atmel-pwm-bl.c index bfd6a96..c254209 100644 --- a/drivers/video/backlight/atmel-pwm-bl.c +++ b/drivers/video/backlight/atmel-pwm-bl.c @@ -48,7 +48,7 @@ static int atmel_pwm_bl_set_intensity(struct backlight_device *bd) pwm_duty = pwmbl->pdata->pwm_duty_min; if (!intensity) { - if (pwmbl->gpio_on != -1) { + if (gpio_is_valid(pwmbl->gpio_on)) { gpio_set_value(pwmbl->gpio_on, 0 ^ pwmbl->pdata->on_active_low); } @@ -57,7 +57,7 @@ static int atmel_pwm_bl_set_intensity(struct backlight_device *bd) } else { pwm_channel_enable(&pwmbl->pwmc); pwm_channel_writel(&pwmbl->pwmc, PWM_CUPD, pwm_duty); - if (pwmbl->gpio_on != -1) { + if (gpio_is_valid(pwmbl->gpio_on)) { gpio_set_value(pwmbl->gpio_on, 1 ^ pwmbl->pdata->on_active_low); } @@ -146,7 +146,7 @@ static int atmel_pwm_bl_probe(struct platform_device *pdev) if (retval) return retval; - if (pwmbl->gpio_on != -1) { + if (gpio_is_valid(pwmbl->gpio_on)) { retval = devm_gpio_request(&pdev->dev, pwmbl->gpio_on, "gpio_atmel_pwm_bl"); if (retval) @@ -196,7 +196,7 @@ static int atmel_pwm_bl_remove(struct platform_device *pdev) { struct atmel_pwm_bl *pwmbl = platform_get_drvdata(pdev); - if (pwmbl->gpio_on != -1) { + if (gpio_is_valid(pwmbl->gpio_on)) { gpio_set_value(pwmbl->gpio_on, 0 ^ pwmbl->pdata->on_active_low); }