From patchwork Thu Oct 31 17:57:44 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Johan Hovold X-Patchwork-Id: 3121571 Return-Path: X-Original-To: patchwork-linux-fbdev@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork1.web.kernel.org (Postfix) with ESMTP id F15E39F3E2 for ; Thu, 31 Oct 2013 17:53:26 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id B2777202AE for ; Thu, 31 Oct 2013 17:59:16 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id E9F5F2027D for ; Thu, 31 Oct 2013 17:59:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754927Ab3JaR6X (ORCPT ); Thu, 31 Oct 2013 13:58:23 -0400 Received: from mail-lb0-f181.google.com ([209.85.217.181]:45379 "EHLO mail-lb0-f181.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754662Ab3JaR6V (ORCPT ); Thu, 31 Oct 2013 13:58:21 -0400 Received: by mail-lb0-f181.google.com with SMTP id x18so2713787lbi.12 for ; Thu, 31 Oct 2013 10:58:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=00Sjm6B78UA/+4UM3K/eB9XOin6SBgdU5ouDjCKs12M=; b=xBiIy3AVsbRuPlQ1rAewzBj8OXdOmG/giqE5u3bzDa8wqe7kSp5Gf55HBsRiblSoHA /sF5GWo6DdhSlyveRNrdnXZ/ERqdAGlczThbKsfhNCXywobRWBtAxHmMQtV4/1SXBaNg es5j8SPMlJjtPi22Ky7n1WI4aYirdc0R9vSCB7qj2CHwS1/BpNOx30ZWVjUz451iR2ao zMqOC+ufAUpHJFl7DbyKRjkEa0yH4pVa/7dg2QnRvgyJua5Q5RK8p/JQpG0lc1OeSrgf 8Scs3d6eLXE12CnnUt4ECuXjHPWd6CjmZvvWTwhWPz6U1ZT9UlMio6roMYPP90DeurXz l+fA== X-Received: by 10.112.130.6 with SMTP id oa6mr287793lbb.62.1383242299414; Thu, 31 Oct 2013 10:58:19 -0700 (PDT) Received: from xi.terra (c193-14-141-227.cust.tele2.se. [193.14.141.227]) by mx.google.com with ESMTPSA id dm10sm3458055lbc.14.2013.10.31.10.58.15 for (version=TLSv1.2 cipher=RC4-SHA bits=128/128); Thu, 31 Oct 2013 10:58:16 -0700 (PDT) Received: from johan by xi.terra with local (Exim 4.80.1) (envelope-from ) id 1VbwVY-00021L-TC; Thu, 31 Oct 2013 18:58:12 +0100 From: Johan Hovold To: Richard Purdie , Jingoo Han Cc: Nicolas Ferre , Tomi Valkeinen , Jean-Christophe Plagniol-Villard , Andrew Morton , linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org, Johan Hovold Subject: [PATCH v3 9/9] backlight: atmel-pwm-bl: use gpio_request_one Date: Thu, 31 Oct 2013 18:57:44 +0100 Message-Id: <1383242264-7652-10-git-send-email-jhovold@gmail.com> X-Mailer: git-send-email 1.8.4.2 In-Reply-To: <1383242264-7652-1-git-send-email-jhovold@gmail.com> References: <1383064064-4983-1-git-send-email-jhovold@gmail.com> <1383242264-7652-1-git-send-email-jhovold@gmail.com> Sender: linux-fbdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fbdev@vger.kernel.org X-Spam-Status: No, score=-7.3 required=5.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, T_DKIM_INVALID, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Use devm_gpio_request_one rather than requesting and setting direction in two calls. Cc: Jingoo Han Signed-off-by: Johan Hovold --- drivers/video/backlight/atmel-pwm-bl.c | 15 ++++++++------- 1 file changed, 8 insertions(+), 7 deletions(-) diff --git a/drivers/video/backlight/atmel-pwm-bl.c b/drivers/video/backlight/atmel-pwm-bl.c index bd1ed34..261b1a4 100644 --- a/drivers/video/backlight/atmel-pwm-bl.c +++ b/drivers/video/backlight/atmel-pwm-bl.c @@ -124,6 +124,7 @@ static int atmel_pwm_bl_probe(struct platform_device *pdev) const struct atmel_pwm_bl_platform_data *pdata; struct backlight_device *bldev; struct atmel_pwm_bl *pwmbl; + unsigned long flags; int retval; pdata = dev_get_platdata(&pdev->dev); @@ -149,14 +150,14 @@ static int atmel_pwm_bl_probe(struct platform_device *pdev) return retval; if (gpio_is_valid(pwmbl->gpio_on)) { - retval = devm_gpio_request(&pdev->dev, pwmbl->gpio_on, - "gpio_atmel_pwm_bl"); - if (retval) - goto err_free_pwm; - /* Turn display off by default. */ - retval = gpio_direction_output(pwmbl->gpio_on, - 0 ^ pdata->on_active_low); + if (pdata->on_active_low) + flags = GPIOF_OUT_INIT_HIGH; + else + flags = GPIOF_OUT_INIT_LOW; + + retval = devm_gpio_request_one(&pdev->dev, pwmbl->gpio_on, + flags, "gpio_atmel_pwm_bl"); if (retval) goto err_free_pwm; }