| Message ID | 1386160133-24026-16-git-send-email-tomi.valkeinen@ti.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Hi Tomi, On Wed, Dec 4, 2013 at 1:28 PM, Tomi Valkeinen <tomi.valkeinen@ti.com> wrote: > Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ti.com> > --- > arch/arm/boot/dts/omap4-panda-common.dtsi | 102 ++++++++++++++++++++++++++++++ > 1 file changed, 102 insertions(+) > > diff --git a/arch/arm/boot/dts/omap4-panda-common.dtsi b/arch/arm/boot/dts/omap4-panda-common.dtsi > index 298e85020e1b..51a79756e67e 100644 > --- a/arch/arm/boot/dts/omap4-panda-common.dtsi > +++ b/arch/arm/boot/dts/omap4-panda-common.dtsi > @@ -409,3 +409,105 @@ > &usbhsehci { > phys = <&hsusb1_phy>; > }; > + > +&dpi { > + dpi_out: endpoint { > + remote-endpoint = <&tfp410_in>; > + data-lines = <24>; > + }; > +}; > + > +&dsi1 { > + vdds_dsi-supply = <&vcxio>; > +}; > + > +&dsi2 { > + vdds_dsi-supply = <&vcxio>; > +}; > + > +&hdmi { > + vdda_hdmi_dac-supply = <&vdac>; > + > + hdmi_out: endpoint { > + remote-endpoint = <&tpd12s015_in>; > + }; > +}; > + > +/ { > + aliases { > + display0 = &dvi0; > + display1 = &hdmi0; > + }; > + > + tfp410: encoder@0 { > + compatible = "ti,tfp410"; > + gpios = <&gpio1 0 0>; /* 0, power-down */ > + Please use the constants from include/dt-bindings/ instead of magic numbers, i.e: gpios = <&gpio1 0 GPIO_ACTIVE_HIGH>; /* 0, power-down */ > + ports { > + #address-cells = <1>; > + #size-cells = <0>; > + > + port@0 { > + reg = <0>; > + > + tfp410_in: endpoint@0 { > + remote-endpoint = <&dpi_out>; > + }; > + }; > + > + port@1 { > + reg = <1>; > + > + tfp410_out: endpoint@1 { > + remote-endpoint = <&dvi_connector_in>; > + }; > + }; > + }; > + }; > + > + dvi0: connector@0 { > + compatible = "ti,dvi-connector"; > + i2c-bus = <&i2c3>; > + > + dvi_connector_in: endpoint { > + remote-endpoint = <&tfp410_out>; > + }; > + }; > + > + tpd12s015: encoder@1 { > + compatible = "ti,tpd12s015"; > + > + gpios = <&gpio2 28 0>, /* 60, CT CP HPD */ > + <&gpio2 9 0>, /* 41, LS OE */ > + <&gpio2 31 0>; /* 63, HPD */ > + > + ports { > + #address-cells = <1>; > + #size-cells = <0>; > + > + port@0 { > + reg = <0>; > + > + tpd12s015_in: endpoint@0 { > + remote-endpoint = <&hdmi_out>; > + }; > + }; > + > + port@1 { > + reg = <1>; > + > + tpd12s015_out: endpoint@1 { > + remote-endpoint = <&hdmi_connector_in>; > + }; > + }; > + }; > + }; > + > + hdmi0: connector@1 { > + compatible = "ti,hdmi-connector"; > + > + hdmi_connector_in: endpoint { > + remote-endpoint = <&tpd12s015_out>; > + }; > + }; > +}; > -- > 1.8.3.2 > Best regards, Javier -- To unsubscribe from this list: send the line "unsubscribe linux-fbdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 2013-12-06 10:57, Javier Martinez Canillas wrote: >> + tfp410: encoder@0 { >> + compatible = "ti,tfp410"; >> + gpios = <&gpio1 0 0>; /* 0, power-down */ >> + > > Please use the constants from include/dt-bindings/ instead of magic > numbers, i.e: > > gpios = <&gpio1 0 GPIO_ACTIVE_HIGH>; /* 0, power-down */ Thanks, fixed now (for all .dts files) However... The TFP410 gpio is "power-down". I think we should actually mark it as GPIO_ACTIVE_LOW, as setting it to 0 powers down the device. Tomi
Hi Tomi, On Mon, Dec 9, 2013 at 1:56 PM, Tomi Valkeinen <tomi.valkeinen@ti.com> wrote: > On 2013-12-06 10:57, Javier Martinez Canillas wrote: > >>> + tfp410: encoder@0 { >>> + compatible = "ti,tfp410"; >>> + gpios = <&gpio1 0 0>; /* 0, power-down */ >>> + >> >> Please use the constants from include/dt-bindings/ instead of magic >> numbers, i.e: >> >> gpios = <&gpio1 0 GPIO_ACTIVE_HIGH>; /* 0, power-down */ > > Thanks, fixed now (for all .dts files) > > However... The TFP410 gpio is "power-down". I think we should actually > mark it as GPIO_ACTIVE_LOW, as setting it to 0 powers down the device. > yes, I looked at the TFP410 datasheet [0] and the Power Down pin is indeed an active-low, I just replaced to GPIO_ACTIVE_HIGH since you were using a constant 0 and include/dt-bindings/gpio/gpio.h defines GPIO_ACTIVE_HIGH as 0. I just asked to Enric why we use GPIO_ACTIVE_HIGH for the PD pin on the IGEPv2 DTS instad and is because the IGEP board uses a hardware signal inverter but that is a special case. I don't know about the Panda board since I haven't looked at its datasheet. Thanks a lot and best regards, Javier [0]: http://www.ti.com/lit/ds/slds145b/slds145b.pdf -- To unsubscribe from this list: send the line "unsubscribe linux-fbdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 2013-12-09 17:09, Javier Martinez Canillas wrote: > Hi Tomi, > > On Mon, Dec 9, 2013 at 1:56 PM, Tomi Valkeinen <tomi.valkeinen@ti.com> wrote: >> On 2013-12-06 10:57, Javier Martinez Canillas wrote: >> >>>> + tfp410: encoder@0 { >>>> + compatible = "ti,tfp410"; >>>> + gpios = <&gpio1 0 0>; /* 0, power-down */ >>>> + >>> >>> Please use the constants from include/dt-bindings/ instead of magic >>> numbers, i.e: >>> >>> gpios = <&gpio1 0 GPIO_ACTIVE_HIGH>; /* 0, power-down */ >> >> Thanks, fixed now (for all .dts files) >> >> However... The TFP410 gpio is "power-down". I think we should actually >> mark it as GPIO_ACTIVE_LOW, as setting it to 0 powers down the device. >> > > yes, I looked at the TFP410 datasheet [0] and the Power Down pin is > indeed an active-low, I just replaced to GPIO_ACTIVE_HIGH since you > were using a constant 0 and include/dt-bindings/gpio/gpio.h defines > GPIO_ACTIVE_HIGH as 0. > > I just asked to Enric why we use GPIO_ACTIVE_HIGH for the PD pin on > the IGEPv2 DTS instad and is because the IGEP board uses a hardware > signal inverter but that is a special case. I don't know about the > Panda board since I haven't looked at its datasheet. Oh. Does it work on igep? The TFP410 driver always handles the PD GPIO as it were active-low. The flag is ignored. Tomi
Hi Tomi, On Mon, Dec 9, 2013 at 4:30 PM, Tomi Valkeinen <tomi.valkeinen@ti.com> wrote: > On 2013-12-09 17:09, Javier Martinez Canillas wrote: >> Hi Tomi, >> >> On Mon, Dec 9, 2013 at 1:56 PM, Tomi Valkeinen <tomi.valkeinen@ti.com> wrote: >>> On 2013-12-06 10:57, Javier Martinez Canillas wrote: >>> >>>>> + tfp410: encoder@0 { >>>>> + compatible = "ti,tfp410"; >>>>> + gpios = <&gpio1 0 0>; /* 0, power-down */ >>>>> + >>>> >>>> Please use the constants from include/dt-bindings/ instead of magic >>>> numbers, i.e: >>>> >>>> gpios = <&gpio1 0 GPIO_ACTIVE_HIGH>; /* 0, power-down */ >>> >>> Thanks, fixed now (for all .dts files) >>> >>> However... The TFP410 gpio is "power-down". I think we should actually >>> mark it as GPIO_ACTIVE_LOW, as setting it to 0 powers down the device. >>> >> >> yes, I looked at the TFP410 datasheet [0] and the Power Down pin is >> indeed an active-low, I just replaced to GPIO_ACTIVE_HIGH since you >> were using a constant 0 and include/dt-bindings/gpio/gpio.h defines >> GPIO_ACTIVE_HIGH as 0. >> >> I just asked to Enric why we use GPIO_ACTIVE_HIGH for the PD pin on >> the IGEPv2 DTS instad and is because the IGEP board uses a hardware >> signal inverter but that is a special case. I don't know about the >> Panda board since I haven't looked at its datasheet. > > Oh. Does it work on igep? The TFP410 driver always handles the PD GPIO > as it were active-low. The flag is ignored. > How weird, it does work on the IGEPv2 but you are right I just looked at at drivers/video/omap2/displays-new/encoder-tfp410.c and I see that it indeed just does: r = devm_gpio_request_one(&pdev->dev, ddata->pd_gpio, GPIOF_OUT_INIT_LOW, "tfp410 PD"); So I don't know how it is working... I'm on the road and won't have access to my IGEPv2 to dig further on this. Maybe Enric can shed more light on this. > Tomi > > Thanks a lot and best regards, Javier -- To unsubscribe from this list: send the line "unsubscribe linux-fbdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/arch/arm/boot/dts/omap4-panda-common.dtsi b/arch/arm/boot/dts/omap4-panda-common.dtsi index 298e85020e1b..51a79756e67e 100644 --- a/arch/arm/boot/dts/omap4-panda-common.dtsi +++ b/arch/arm/boot/dts/omap4-panda-common.dtsi @@ -409,3 +409,105 @@ &usbhsehci { phys = <&hsusb1_phy>; }; + +&dpi { + dpi_out: endpoint { + remote-endpoint = <&tfp410_in>; + data-lines = <24>; + }; +}; + +&dsi1 { + vdds_dsi-supply = <&vcxio>; +}; + +&dsi2 { + vdds_dsi-supply = <&vcxio>; +}; + +&hdmi { + vdda_hdmi_dac-supply = <&vdac>; + + hdmi_out: endpoint { + remote-endpoint = <&tpd12s015_in>; + }; +}; + +/ { + aliases { + display0 = &dvi0; + display1 = &hdmi0; + }; + + tfp410: encoder@0 { + compatible = "ti,tfp410"; + gpios = <&gpio1 0 0>; /* 0, power-down */ + + ports { + #address-cells = <1>; + #size-cells = <0>; + + port@0 { + reg = <0>; + + tfp410_in: endpoint@0 { + remote-endpoint = <&dpi_out>; + }; + }; + + port@1 { + reg = <1>; + + tfp410_out: endpoint@1 { + remote-endpoint = <&dvi_connector_in>; + }; + }; + }; + }; + + dvi0: connector@0 { + compatible = "ti,dvi-connector"; + i2c-bus = <&i2c3>; + + dvi_connector_in: endpoint { + remote-endpoint = <&tfp410_out>; + }; + }; + + tpd12s015: encoder@1 { + compatible = "ti,tpd12s015"; + + gpios = <&gpio2 28 0>, /* 60, CT CP HPD */ + <&gpio2 9 0>, /* 41, LS OE */ + <&gpio2 31 0>; /* 63, HPD */ + + ports { + #address-cells = <1>; + #size-cells = <0>; + + port@0 { + reg = <0>; + + tpd12s015_in: endpoint@0 { + remote-endpoint = <&hdmi_out>; + }; + }; + + port@1 { + reg = <1>; + + tpd12s015_out: endpoint@1 { + remote-endpoint = <&hdmi_connector_in>; + }; + }; + }; + }; + + hdmi0: connector@1 { + compatible = "ti,hdmi-connector"; + + hdmi_connector_in: endpoint { + remote-endpoint = <&tpd12s015_out>; + }; + }; +};
Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ti.com> --- arch/arm/boot/dts/omap4-panda-common.dtsi | 102 ++++++++++++++++++++++++++++++ 1 file changed, 102 insertions(+)