| Message ID | 1387205794-32246-3-git-send-email-tomi.valkeinen@ti.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
* Tomi Valkeinen <tomi.valkeinen@ti.com> [131216 06:59]: > For booting Panda and 4430SDP with DT, while DSS did not support DT, we > had to had small hacks in the omapdss driver to get the regulators. With > DT now supported in DSS, we can remove those hacks. This too we should probably keep for a while and remove after we've converted DSS over to DT? Regards, Tony -- To unsubscribe from this list: send the line "unsubscribe linux-fbdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 2013-12-16 20:42, Tony Lindgren wrote: > * Tomi Valkeinen <tomi.valkeinen@ti.com> [131216 06:59]: >> For booting Panda and 4430SDP with DT, while DSS did not support DT, we >> had to had small hacks in the omapdss driver to get the regulators. With >> DT now supported in DSS, we can remove those hacks. > > This too we should probably keep for a while and remove after we've > converted DSS over to DT? Hmm, yes, this one can be moved at the end of the series, as at that point the DT is supported for Panda and 4430SDP. Tomi
diff --git a/drivers/video/omap2/dss/dsi.c b/drivers/video/omap2/dss/dsi.c index 1cd3e47fd43f..18b5e84165bb 100644 --- a/drivers/video/omap2/dss/dsi.c +++ b/drivers/video/omap2/dss/dsi.c @@ -1124,11 +1124,6 @@ static int dsi_regulator_init(struct platform_device *dsidev) return 0; vdds_dsi = devm_regulator_get(&dsi->pdev->dev, "vdds_dsi"); - - /* DT HACK: try VCXIO to make omapdss work for o4 sdp/panda */ - if (IS_ERR(vdds_dsi)) - vdds_dsi = devm_regulator_get(&dsi->pdev->dev, "VCXIO"); - if (IS_ERR(vdds_dsi)) { DSSERR("can't get VDDS_DSI regulator\n"); return PTR_ERR(vdds_dsi); diff --git a/drivers/video/omap2/dss/hdmi4.c b/drivers/video/omap2/dss/hdmi4.c index e14009614338..16e598787522 100644 --- a/drivers/video/omap2/dss/hdmi4.c +++ b/drivers/video/omap2/dss/hdmi4.c @@ -90,10 +90,6 @@ static int hdmi_init_regulator(void) reg = devm_regulator_get(&hdmi.pdev->dev, "vdda_hdmi_dac"); - /* DT HACK: try VDAC to make omapdss work for o4 sdp/panda */ - if (IS_ERR(reg)) - reg = devm_regulator_get(&hdmi.pdev->dev, "VDAC"); - if (IS_ERR(reg)) { DSSERR("can't get VDDA_HDMI_DAC regulator\n"); return PTR_ERR(reg);
For booting Panda and 4430SDP with DT, while DSS did not support DT, we had to had small hacks in the omapdss driver to get the regulators. With DT now supported in DSS, we can remove those hacks. Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ti.com> --- drivers/video/omap2/dss/dsi.c | 5 ----- drivers/video/omap2/dss/hdmi4.c | 4 ---- 2 files changed, 9 deletions(-)