From patchwork Thu Dec 19 16:18:30 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: David Herrmann X-Patchwork-Id: 3383241 Return-Path: X-Original-To: patchwork-linux-fbdev@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 4A44CC0D4A for ; Thu, 19 Dec 2013 16:19:06 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id A10CA20689 for ; Thu, 19 Dec 2013 16:19:01 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 0DA6620675 for ; Thu, 19 Dec 2013 16:18:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755699Ab3LSQS4 (ORCPT ); Thu, 19 Dec 2013 11:18:56 -0500 Received: from mail-ee0-f43.google.com ([74.125.83.43]:40547 "EHLO mail-ee0-f43.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753926Ab3LSQSz (ORCPT ); Thu, 19 Dec 2013 11:18:55 -0500 Received: by mail-ee0-f43.google.com with SMTP id c13so579311eek.2 for ; Thu, 19 Dec 2013 08:18:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=PqfWMYnqlIvQdLkYng5/LQRFy4etZ2pt+HF5JZKC4Yg=; b=UYMfPMWT1v97bPnvgvv98/x1nYjT/V0hNTK4d2EKT6yijdcIIlkbU73ioCZngKuZAS xflK7tXtwfRK/q5luH46RvLWI6HXWHguLj72viJDijAtZK/BHgWD95+YNBdlXdlCEmxS TOqMPwL2Qk4LGfYc8OBxQ2X0y7LiNNrWV4P/UzL76lpSP/nNb5nkVmfafF/kNb3CWEkC 6HMkQI2EIeaxPlaxi+011n7YG8pWb7Vs/RU3+YLLHJSzsDpiLiOLMQLFobuE6aotWUzz 3yJ+JyeBteO8lmG3rV0tE3sN07/Mtkx/fvXhX8TUdu4jCAFHV0oUGXNGCgoU84Mgf1te aY4Q== X-Received: by 10.14.0.201 with SMTP id 49mr665943eeb.38.1387469934055; Thu, 19 Dec 2013 08:18:54 -0800 (PST) Received: from david-ub.localdomain (stgt-5f719d74.pool.mediaWays.net. [95.113.157.116]) by mx.google.com with ESMTPSA id p45sm10659938eeg.1.2013.12.19.08.18.51 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Thu, 19 Dec 2013 08:18:53 -0800 (PST) From: David Herrmann To: linux-kernel@vger.kernel.org Cc: "H. Peter Anvin" , Thomas Gleixner , Ingo Molnar , , , David Herrmann , Subject: [PATCH v2] x86: sysfb: fool-proof CONFIG_X86_SYSFB Date: Thu, 19 Dec 2013 17:18:30 +0100 Message-Id: <1387469910-24560-1-git-send-email-dh.herrmann@gmail.com> X-Mailer: git-send-email 1.8.5.1 In-Reply-To: <1387460330-13989-1-git-send-email-dh.herrmann@gmail.com> References: <1387460330-13989-1-git-send-email-dh.herrmann@gmail.com> Sender: linux-fbdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fbdev@vger.kernel.org X-Spam-Status: No, score=-7.3 required=5.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, T_DKIM_INVALID, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Turns out, people do not read help-texts of new config-options and enable them nonetheless. So several reports came in with X86_SYSFB=y and FB_SIMPLE=n, which in almost all situations prevents firmware-fbs from being probed. X86_SYSFB clearly states that it turns legacy vesa/efi framebuffers into a format compatible to simplefb (and does nothing else..). So to avoid further complaints about missing gfx-support during boot, simply depend on FB_SIMPLE now. As FB_SIMPLE is disabled by default and usually only enabled on selected ARM architectures, x86 users should thus never see the X86_SYSFB config-option. And if they do, everything is fine as simplefb will be available. Note that most of the sysfb code is enabled independently of X86_SYSFB. The config option only selects a compatibility mode for simplefb. It was introduced to ease the transition to SimpleDRM and disabling fbdev. As this is still ongoing, there's no need for non-developers to care for X86_SYSFB so we can safely hide it behind FB_SIMPLE. Cc: # 3.11+ Signed-off-by: David Herrmann --- v2: - keep the "If unsure, say Y" - (FB_SIMPLE = y) => FB_SIMPLE - adjust commit-msg arch/x86/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/x86/Kconfig b/arch/x86/Kconfig index e903c71..c9d2952 100644 --- a/arch/x86/Kconfig +++ b/arch/x86/Kconfig @@ -2298,6 +2298,7 @@ source "drivers/rapidio/Kconfig" config X86_SYSFB bool "Mark VGA/VBE/EFI FB as generic system framebuffer" + depends on FB_SIMPLE help Firmwares often provide initial graphics framebuffers so the BIOS, bootloader or kernel can show basic video-output during boot for