| Message ID | 1389933172-22991-2-git-send-email-sachin.kamat@linaro.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On 2014-01-17 06:32, Sachin Kamat wrote: > Enable S6E8AX0 LCD driver only if LCD_CLASS_DEVICE is a built-in driver. > Else we get the following errors due to missing symbols: > drivers/built-in.o: In function `s6e8ax0_probe': > :(.text+0x51aec): undefined reference to `lcd_device_register' > :(.text+0x51c44): undefined reference to `lcd_device_unregister' > > Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org> > --- > drivers/video/exynos/Kconfig | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/video/exynos/Kconfig b/drivers/video/exynos/Kconfig > index 976594d578a9..7e19b467b8f7 100644 > --- a/drivers/video/exynos/Kconfig > +++ b/drivers/video/exynos/Kconfig > @@ -22,7 +22,8 @@ config EXYNOS_MIPI_DSI > > config EXYNOS_LCD_S6E8AX0 > bool "S6E8AX0 MIPI AMOLED LCD Driver" > - depends on (EXYNOS_MIPI_DSI && BACKLIGHT_CLASS_DEVICE && LCD_CLASS_DEVICE) > + depends on EXYNOS_MIPI_DSI && BACKLIGHT_CLASS_DEVICE > + depends on (LCD_CLASS_DEVICE != m) Hmm, doesn't that say that LCD_CLASS_DEVICE can be y or n (i.e. != m), so it could be disabled also? Tomi
On 17 January 2014 15:52, Tomi Valkeinen <tomi.valkeinen@ti.com> wrote: > On 2014-01-17 06:32, Sachin Kamat wrote: >> Enable S6E8AX0 LCD driver only if LCD_CLASS_DEVICE is a built-in driver. >> Else we get the following errors due to missing symbols: >> drivers/built-in.o: In function `s6e8ax0_probe': >> :(.text+0x51aec): undefined reference to `lcd_device_register' >> :(.text+0x51c44): undefined reference to `lcd_device_unregister' >> >> Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org> >> --- >> drivers/video/exynos/Kconfig | 3 ++- >> 1 file changed, 2 insertions(+), 1 deletion(-) >> >> diff --git a/drivers/video/exynos/Kconfig b/drivers/video/exynos/Kconfig >> index 976594d578a9..7e19b467b8f7 100644 >> --- a/drivers/video/exynos/Kconfig >> +++ b/drivers/video/exynos/Kconfig >> @@ -22,7 +22,8 @@ config EXYNOS_MIPI_DSI >> >> config EXYNOS_LCD_S6E8AX0 >> bool "S6E8AX0 MIPI AMOLED LCD Driver" >> - depends on (EXYNOS_MIPI_DSI && BACKLIGHT_CLASS_DEVICE && LCD_CLASS_DEVICE) >> + depends on EXYNOS_MIPI_DSI && BACKLIGHT_CLASS_DEVICE >> + depends on (LCD_CLASS_DEVICE != m) > > Hmm, doesn't that say that LCD_CLASS_DEVICE can be y or n (i.e. != m), > so it could be disabled also? Yes you are right. Not sure how I got it right while testing. Thanks for catching. It should just be (LCD_CLASS_DEVICE = y). Will resend.
diff --git a/drivers/video/exynos/Kconfig b/drivers/video/exynos/Kconfig index 976594d578a9..7e19b467b8f7 100644 --- a/drivers/video/exynos/Kconfig +++ b/drivers/video/exynos/Kconfig @@ -22,7 +22,8 @@ config EXYNOS_MIPI_DSI config EXYNOS_LCD_S6E8AX0 bool "S6E8AX0 MIPI AMOLED LCD Driver" - depends on (EXYNOS_MIPI_DSI && BACKLIGHT_CLASS_DEVICE && LCD_CLASS_DEVICE) + depends on EXYNOS_MIPI_DSI && BACKLIGHT_CLASS_DEVICE + depends on (LCD_CLASS_DEVICE != m) default n help If you have an S6E8AX0 MIPI AMOLED LCD Panel, say Y to enable its
Enable S6E8AX0 LCD driver only if LCD_CLASS_DEVICE is a built-in driver. Else we get the following errors due to missing symbols: drivers/built-in.o: In function `s6e8ax0_probe': :(.text+0x51aec): undefined reference to `lcd_device_register' :(.text+0x51c44): undefined reference to `lcd_device_unregister' Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org> --- drivers/video/exynos/Kconfig | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)