From patchwork Thu Jan 23 14:14:53 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: David Herrmann X-Patchwork-Id: 3528981 Return-Path: X-Original-To: patchwork-linux-fbdev@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 650C59F1C3 for ; Thu, 23 Jan 2014 14:15:55 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id C2A76201B6 for ; Thu, 23 Jan 2014 14:15:49 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 975D920181 for ; Thu, 23 Jan 2014 14:15:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753379AbaAWOPs (ORCPT ); Thu, 23 Jan 2014 09:15:48 -0500 Received: from mail-wg0-f42.google.com ([74.125.82.42]:47514 "EHLO mail-wg0-f42.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752977AbaAWOPr (ORCPT ); Thu, 23 Jan 2014 09:15:47 -0500 Received: by mail-wg0-f42.google.com with SMTP id l18so639082wgh.3 for ; Thu, 23 Jan 2014 06:15:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=Ol+2p527wXR3B+dnx5Sb9YNcwRK7DXXwxVXPodiwmSY=; b=SiFyZfRNdkXlsLMdXHHb6FTZn5v+HMSWJToG1EXn53IzOTv3Zwy3tK94yUPULfc4Pd o9ttCKA0PebclFXXN1T3N1oEIZ0mPGScQaZ6PiGDSWiIQ6FH31hdITKshJjR17NIG/7I UO5qEcf9+kQxXCsYxIV/EkgAnl1pkUFh4FedyG+PQrYgXlIzZi//lZ/f2CjqnEwLSHt+ 5YaMPRDp3VpQ6fH4PLWUsORMUNgAviFbtqfmfd+NragaJ3LmWNM0/Sqomy5Bc0Mj+jpL gY7mzMlpCYwuu3C71yKPVEC3oYmzj5kpKttQbBXWlA1sA8VMVT7lWr+/iIUXDDmbmQDk DirA== X-Received: by 10.194.83.9 with SMTP id m9mr3785701wjy.39.1390486545962; Thu, 23 Jan 2014 06:15:45 -0800 (PST) Received: from david-ub.localdomain (stgt-5f71be19.pool.mediaWays.net. [95.113.190.25]) by mx.google.com with ESMTPSA id ci4sm22667871wjc.21.2014.01.23.06.15.44 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Thu, 23 Jan 2014 06:15:44 -0800 (PST) From: David Herrmann To: dri-devel@lists.freedesktop.org Cc: Ingo Molnar , linux-fbdev@vger.kernel.org, Dave Airlie , Daniel Vetter , Tomi Valkeinen , linux-kernel@vger.kernel.org, Tom Gundersen , David Herrmann Subject: [PATCH 01/11] x86: sysfb: fool-proof CONFIG_X86_SYSFB Date: Thu, 23 Jan 2014 15:14:53 +0100 Message-Id: <1390486503-1504-2-git-send-email-dh.herrmann@gmail.com> X-Mailer: git-send-email 1.8.5.3 In-Reply-To: <1390486503-1504-1-git-send-email-dh.herrmann@gmail.com> References: <1390486503-1504-1-git-send-email-dh.herrmann@gmail.com> Sender: linux-fbdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fbdev@vger.kernel.org X-Spam-Status: No, score=-7.3 required=5.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, T_DKIM_INVALID, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Turns out, people do not read help-texts of new config-options and enable them nonetheless. So several reports came in with X86_SYSFB=y and FB_SIMPLE=n, which in almost all situations prevents firmware-fbs from being probed. X86_SYSFB clearly states that it turns legacy vesa/efi framebuffers into a format compatible to simplefb (and does nothing else..). So to avoid further complaints about missing gfx-support during boot, simply depend on FB_SIMPLE now. As FB_SIMPLE is disabled by default and usually only enabled on selected ARM architectures, x86 users should thus never see the X86_SYSFB config-option. And if they do, everything is fine as simplefb will be available. Note that most of the sysfb code is enabled independently of X86_SYSFB. The config option only selects a compatibility mode for simplefb. It was introduced to ease the transition to SimpleDRM and disabling fbdev. As this is still ongoing, there's no need for non-developers to care for X86_SYSFB so we can safely hide it behind FB_SIMPLE. Signed-off-by: David Herrmann --- arch/x86/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/x86/Kconfig b/arch/x86/Kconfig index 0952ecd..098228e 100644 --- a/arch/x86/Kconfig +++ b/arch/x86/Kconfig @@ -2299,6 +2299,7 @@ source "drivers/rapidio/Kconfig" config X86_SYSFB bool "Mark VGA/VBE/EFI FB as generic system framebuffer" + depends on FB_SIMPLE help Firmwares often provide initial graphics framebuffers so the BIOS, bootloader or kernel can show basic video-output during boot for