From patchwork Mon Feb 3 08:33:02 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sachin Kamat X-Patchwork-Id: 3568571 Return-Path: X-Original-To: patchwork-linux-fbdev@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork2.web.kernel.org (Postfix) with ESMTP id D1F94C02DC for ; Mon, 3 Feb 2014 08:37:59 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 1C18B201BC for ; Mon, 3 Feb 2014 08:37:59 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 4B43820149 for ; Mon, 3 Feb 2014 08:37:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1750900AbaBCIh6 (ORCPT ); Mon, 3 Feb 2014 03:37:58 -0500 Received: from mail-pb0-f43.google.com ([209.85.160.43]:56043 "EHLO mail-pb0-f43.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750884AbaBCIh5 (ORCPT ); Mon, 3 Feb 2014 03:37:57 -0500 Received: by mail-pb0-f43.google.com with SMTP id md12so6792326pbc.2 for ; Mon, 03 Feb 2014 00:37:57 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=49nE/mS+5SD7/EfxhP7pjMO3E6KZW1a8kScC8YyqZx4=; b=gPkgdRzzHG8G+YFnlFq/hXRo0X8xSSZVZzdeny+kFRKmzGMsLAneRJDDb3HJtKSoMr CZDIue+BxPEyMcRoBY9XJ5Z/GcHGYdyqSll17BOZ1U5T3Fn7tyQp2J0oXkAYrhVx4M51 EbPwFrPV0M9evKFzV3aTY80L/oD2DUZmJajKFT6PFz/B+eajEtybdXGLPnoPm3UZ4xHe DtC3s1Afhc/N3rmay/GPUIjnE4B2vhTcuI+t7dhtuDOiyO/lNsxTGWCyEAGYRHBm62SX Q4Fskn4PU7rdHucA0sCBLPVbX0L7hNnFUFBrYzT+8f0C1jgQPXzDLxp0sRA8vstyaUFY ThuQ== X-Gm-Message-State: ALoCoQnAnn+qYoHgx5/TyYCZf4u/spHDMMy+P0e7/aKUw4VrI2eVbWI33rp6OzXyQpvB7DVx5Ja+ X-Received: by 10.68.133.163 with SMTP id pd3mr1270480pbb.166.1391416677129; Mon, 03 Feb 2014 00:37:57 -0800 (PST) Received: from linaro.sisodomain.com ([115.113.119.130]) by mx.google.com with ESMTPSA id g6sm139230185pat.2.2014.02.03.00.37.55 for (version=TLSv1.1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Mon, 03 Feb 2014 00:37:56 -0800 (PST) From: Sachin Kamat To: linux-fbdev@vger.kernel.org Cc: tomi.valkeinen@ti.com, sachin.kamat@linaro.org Subject: [PATCH Resend 2/2] video: exynos: Fix S6E8AX0 LCD driver build error Date: Mon, 3 Feb 2014 14:03:02 +0530 Message-Id: <1391416382-25285-2-git-send-email-sachin.kamat@linaro.org> X-Mailer: git-send-email 1.7.9.5 In-Reply-To: <1391416382-25285-1-git-send-email-sachin.kamat@linaro.org> References: <1391416382-25285-1-git-send-email-sachin.kamat@linaro.org> Sender: linux-fbdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fbdev@vger.kernel.org X-Spam-Status: No, score=-7.4 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Enable S6E8AX0 LCD driver only if LCD_CLASS_DEVICE is a built-in driver. Else we get the following errors due to missing symbols: drivers/built-in.o: In function `s6e8ax0_probe': :(.text+0x51aec): undefined reference to `lcd_device_register' :(.text+0x51c44): undefined reference to `lcd_device_unregister' Signed-off-by: Sachin Kamat --- drivers/video/exynos/Kconfig | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/video/exynos/Kconfig b/drivers/video/exynos/Kconfig index 976594d578a9..eb6f2b059821 100644 --- a/drivers/video/exynos/Kconfig +++ b/drivers/video/exynos/Kconfig @@ -22,7 +22,8 @@ config EXYNOS_MIPI_DSI config EXYNOS_LCD_S6E8AX0 bool "S6E8AX0 MIPI AMOLED LCD Driver" - depends on (EXYNOS_MIPI_DSI && BACKLIGHT_CLASS_DEVICE && LCD_CLASS_DEVICE) + depends on EXYNOS_MIPI_DSI && BACKLIGHT_CLASS_DEVICE + depends on (LCD_CLASS_DEVICE = y) default n help If you have an S6E8AX0 MIPI AMOLED LCD Panel, say Y to enable its