From patchwork Thu Mar 20 15:16:00 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Paul Gortmaker X-Patchwork-Id: 3866761 Return-Path: X-Original-To: patchwork-linux-fbdev@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 0A0E89F334 for ; Thu, 20 Mar 2014 15:16:29 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 2AF1B20222 for ; Thu, 20 Mar 2014 15:16:28 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id AAA52201F4 for ; Thu, 20 Mar 2014 15:16:26 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757245AbaCTPQZ (ORCPT ); Thu, 20 Mar 2014 11:16:25 -0400 Received: from mail1.windriver.com ([147.11.146.13]:57645 "EHLO mail1.windriver.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757067AbaCTPQZ (ORCPT ); Thu, 20 Mar 2014 11:16:25 -0400 Received: from ALA-HCA.corp.ad.wrs.com (ala-hca.corp.ad.wrs.com [147.11.189.40]) by mail1.windriver.com (8.14.5/8.14.5) with ESMTP id s2KFGIVv018983 (version=TLSv1/SSLv3 cipher=AES128-SHA bits=128 verify=FAIL); Thu, 20 Mar 2014 08:16:19 -0700 (PDT) Received: from yow-dellw-pg2.corp.ad.wrs.com (128.224.56.7) by ALA-HCA.corp.ad.wrs.com (147.11.189.40) with Microsoft SMTP Server id 14.3.169.1; Thu, 20 Mar 2014 08:16:18 -0700 From: Paul Gortmaker To: Jean-Christophe Plagniol-Villard , Tomi Valkeinen CC: , , Jim Davis , Fengguang Wu , Paul Gortmaker Subject: [PATCH] drivers/video: fix mb862xx_i2c depends issue build failure Date: Thu, 20 Mar 2014 11:16:00 -0400 Message-ID: <1395328560-48497-1-git-send-email-paul.gortmaker@windriver.com> X-Mailer: git-send-email 1.9.0 MIME-Version: 1.0 Sender: linux-fbdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fbdev@vger.kernel.org X-Spam-Status: No, score=-6.9 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, T_RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Any randconfig that sets I2C=m and FB_MB862XX_I2C=y will encounter a final link failure that looks like this: drivers/built-in.o: In function `mb862xx_i2c_init': drivers/video/mb862xx/mb862xx-i2c.c:165: undefined reference to `i2c_add_adapter' drivers/built-in.o: In function `mb862xx_i2c_exit': drivers/video/mb862xx/mb862xx-i2c.c:176: undefined reference to `i2c_del_adapter' Since FB_MB862XX_I2C is a bool and not tristate, simply don't offer it at all if core I2C support is not built in. Reported-by: Jim Davis Reported-by: Fengguang Wu Signed-off-by: Paul Gortmaker diff --git a/drivers/video/Kconfig b/drivers/video/Kconfig index dade5b7699bc..aefd1b9a3cbd 100644 --- a/drivers/video/Kconfig +++ b/drivers/video/Kconfig @@ -2338,7 +2338,7 @@ endchoice config FB_MB862XX_I2C bool "Support I2C bus on MB862XX GDC" - depends on FB_MB862XX && I2C + depends on FB_MB862XX && I2C=y default y help Selecting this option adds Coral-P(A)/Lime GDC I2C bus adapter