diff mbox

fbdev: ssd1307fb: drop unused function ssd1307fb_write_data()

Message ID 1421090474-4243-1-git-send-email-prabhakar.csengg@gmail.com (mailing list archive)
State New, archived
Headers show

Commit Message

Prabhakar Jan. 12, 2015, 7:21 p.m. UTC
this patch drops the unused function ssd1307fb_write_data().

Signed-off-by: Lad, Prabhakar <prabhakar.csengg@gmail.com>
---
 drivers/video/fbdev/ssd1307fb.c | 17 -----------------
 1 file changed, 17 deletions(-)

Comments

Maxime Ripard Jan. 13, 2015, 1:43 p.m. UTC | #1
On Mon, Jan 12, 2015 at 07:21:14PM +0000, Lad, Prabhakar wrote:
> this patch drops the unused function ssd1307fb_write_data().
> 
> Signed-off-by: Lad, Prabhakar <prabhakar.csengg@gmail.com>

Acked-by: Maxime Ripard <maxime.ripard@free-electrons.com>

Maxime
Tomi Valkeinen Jan. 15, 2015, 11:26 a.m. UTC | #2
On 12/01/15 21:21, Lad, Prabhakar wrote:
> this patch drops the unused function ssd1307fb_write_data().
> 
> Signed-off-by: Lad, Prabhakar <prabhakar.csengg@gmail.com>
> ---
>  drivers/video/fbdev/ssd1307fb.c | 17 -----------------
>  1 file changed, 17 deletions(-)
> 
> diff --git a/drivers/video/fbdev/ssd1307fb.c b/drivers/video/fbdev/ssd1307fb.c
> index a7ecaa6..c891f11 100644
> --- a/drivers/video/fbdev/ssd1307fb.c
> +++ b/drivers/video/fbdev/ssd1307fb.c
> @@ -122,23 +122,6 @@ static inline int ssd1307fb_write_cmd(struct i2c_client *client, u8 cmd)
>  	return ret;
>  }
>  
> -static inline int ssd1307fb_write_data(struct i2c_client *client, u8 data)
> -{
> -	struct ssd1307fb_array *array;
> -	int ret;
> -
> -	array = ssd1307fb_alloc_array(1, SSD1307FB_DATA);
> -	if (!array)
> -		return -ENOMEM;
> -
> -	array->data[0] = data;
> -
> -	ret = ssd1307fb_write_array(client, array, 1);
> -	kfree(array);
> -
> -	return ret;
> -}
> -
>  static void ssd1307fb_update_display(struct ssd1307fb_par *par)
>  {
>  	struct ssd1307fb_array *array;
> 

Thanks, queued for 3.20.

 Tomi
diff mbox

Patch

diff --git a/drivers/video/fbdev/ssd1307fb.c b/drivers/video/fbdev/ssd1307fb.c
index a7ecaa6..c891f11 100644
--- a/drivers/video/fbdev/ssd1307fb.c
+++ b/drivers/video/fbdev/ssd1307fb.c
@@ -122,23 +122,6 @@  static inline int ssd1307fb_write_cmd(struct i2c_client *client, u8 cmd)
 	return ret;
 }
 
-static inline int ssd1307fb_write_data(struct i2c_client *client, u8 data)
-{
-	struct ssd1307fb_array *array;
-	int ret;
-
-	array = ssd1307fb_alloc_array(1, SSD1307FB_DATA);
-	if (!array)
-		return -ENOMEM;
-
-	array->data[0] = data;
-
-	ret = ssd1307fb_write_array(client, array, 1);
-	kfree(array);
-
-	return ret;
-}
-
 static void ssd1307fb_update_display(struct ssd1307fb_par *par)
 {
 	struct ssd1307fb_array *array;