From patchwork Sun Mar 8 17:40:11 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sudip Mukherjee X-Patchwork-Id: 5962561 Return-Path: X-Original-To: patchwork-linux-fbdev@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork2.web.kernel.org (Postfix) with ESMTP id B75B5BF6C3 for ; Sun, 8 Mar 2015 17:40:35 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id E6ECD202A1 for ; Sun, 8 Mar 2015 17:40:34 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 232A5202F0 for ; Sun, 8 Mar 2015 17:40:34 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932067AbbCHRkb (ORCPT ); Sun, 8 Mar 2015 13:40:31 -0400 Received: from mail-pa0-f53.google.com ([209.85.220.53]:43792 "EHLO mail-pa0-f53.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752936AbbCHRk2 (ORCPT ); Sun, 8 Mar 2015 13:40:28 -0400 Received: by pablj1 with SMTP id lj1so57425053pab.10; Sun, 08 Mar 2015 10:40:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=T0coiGgEJIBDbPFPZuumu/er9mqWzdhefucVDCXoF44=; b=s8mb31Lew64fBb7dMWTyhyekG7GR+AQceq5Iya6GOtE0R9kNv0tWV4QVDp/5o7N7j/ sDyJ9AjIpJ2irHqPa5fq2JbFlqiBx26sban22F878ljbsjgAaoV5ICZW1qGy5jzqNwFy O7lNA5w37utbLDjyHeAeukYzcouol6bb8l3JWG+sFWHFj2/s3tdemiLQivfbtEzWHwen C90k0qxN825jaGVSR5/dNH5YMFYdjy3TGgdJ4aGMvgd0OI9SD6bWTz1nb2GwHCzrW0Nq 9x7Rq8JNilkgOmxgXSYTGyHqyrfudHhT1UY/lxZ6isKl6CjlIkGWj6hKh3oguP9l/5VT UwqQ== X-Received: by 10.66.141.231 with SMTP id rr7mr39291716pab.72.1425836427855; Sun, 08 Mar 2015 10:40:27 -0700 (PDT) Received: from localhost.localdomain ([122.169.150.126]) by mx.google.com with ESMTPSA id iy2sm15246600pbb.22.2015.03.08.10.40.25 (version=TLSv1.1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Sun, 08 Mar 2015 10:40:27 -0700 (PDT) From: Sudip Mukherjee To: Greg Kroah-Hartman Cc: Sudip Mukherjee , linux-fbdev@vger.kernel.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: [PATCH 3/3] staging: sm7xxfb: change return of sm7xx_vga_setup Date: Sun, 8 Mar 2015 23:10:11 +0530 Message-Id: <1425836411-15481-3-git-send-email-sudipm.mukherjee@gmail.com> X-Mailer: git-send-email 1.8.1.2 In-Reply-To: <1425836411-15481-1-git-send-email-sudipm.mukherjee@gmail.com> References: <1425836411-15481-1-git-send-email-sudipm.mukherjee@gmail.com> Sender: linux-fbdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fbdev@vger.kernel.org X-Spam-Status: No, score=-6.8 required=5.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_HI, T_DKIM_INVALID, T_RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP change return type of sm7xx_vga_setup() to void as we are not using the return type anywhere. if this function fails we fall back to the default configuration. Signed-off-by: Sudip Mukherjee Reviewed-by: Dan Carpenter --- drivers/staging/sm7xxfb/sm7xxfb.c | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/drivers/staging/sm7xxfb/sm7xxfb.c b/drivers/staging/sm7xxfb/sm7xxfb.c index e93563f..abdb021 100644 --- a/drivers/staging/sm7xxfb/sm7xxfb.c +++ b/drivers/staging/sm7xxfb/sm7xxfb.c @@ -116,12 +116,12 @@ static struct screen_info smtc_scr_info; static char *mode_option; /* process command line options, get vga parameter */ -static int __init sm7xx_vga_setup(char *options) +static void __init sm7xx_vga_setup(char *options) { int i; if (!options || !*options) - return -EINVAL; + return; smtc_scr_info.lfb_width = 0; smtc_scr_info.lfb_height = 0; @@ -135,11 +135,9 @@ static int __init sm7xx_vga_setup(char *options) smtc_scr_info.lfb_height = vesa_mode_table[i].lfb_height; smtc_scr_info.lfb_depth = vesa_mode_table[i].lfb_depth; - return 0; + return; } } - - return -1; } static void sm712_setpalette(int regno, unsigned red, unsigned green,