From patchwork Tue Mar 10 17:16:57 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sudip Mukherjee X-Patchwork-Id: 5979541 Return-Path: X-Original-To: patchwork-linux-fbdev@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 32A46BF6C3 for ; Tue, 10 Mar 2015 17:17:48 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 6A3E6201F2 for ; Tue, 10 Mar 2015 17:17:47 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 7B3EE20220 for ; Tue, 10 Mar 2015 17:17:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752856AbbCJRR2 (ORCPT ); Tue, 10 Mar 2015 13:17:28 -0400 Received: from mail-pa0-f46.google.com ([209.85.220.46]:35614 "EHLO mail-pa0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752777AbbCJRR0 (ORCPT ); Tue, 10 Mar 2015 13:17:26 -0400 Received: by pabli10 with SMTP id li10so3882931pab.2; Tue, 10 Mar 2015 10:17:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=uxB5YfF1KzsWU5G09Q5LrqqhWdZz5waPG9HxAS6RE/c=; b=yxEp80n7Q+Fzm03Cx3mSnMeA4PkEJUIi5Xy8mMtUTwGEkp00cE+nwy/fE6W/76FCgf jE0ohC+u22YcaaytxEWXw4CR67Gx23P9/AQ1GonuUBWxce8DpyN8BSVM0n8DFHn76OXC MS0PWqUBe3WA0RmXgVIplA30Ak+UHI+/tdhZLqpw8vgkBlsaizq24BBOfsNxsVeHcxdM ab02WHG/sJn46O5KhExPMfjjL/DocSM6Bqk/GJ9OI0a87e8kmXKS/Pt9R/E46MKSBKHe A1xAI3mGW7pVyjAaUp3vGcVF2zsm4MdCRmFN+EkeLAost1AzfifNv24i6m5cp+/eZc+6 zYog== X-Received: by 10.70.109.135 with SMTP id hs7mr41925645pdb.133.1426007846113; Tue, 10 Mar 2015 10:17:26 -0700 (PDT) Received: from localhost.localdomain ([122.169.145.94]) by mx.google.com with ESMTPSA id kd9sm2087506pab.0.2015.03.10.10.17.23 (version=TLSv1.1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Tue, 10 Mar 2015 10:17:25 -0700 (PDT) From: Sudip Mukherjee To: Greg Kroah-Hartman Cc: linux-fbdev@vger.kernel.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, Sudip Mukherjee Subject: [PATCH 6/6] staging: sm750fb: correct integer comparison Date: Tue, 10 Mar 2015 22:46:57 +0530 Message-Id: <1426007817-1884-7-git-send-email-sudipm.mukherjee@gmail.com> X-Mailer: git-send-email 1.8.1.2 In-Reply-To: <1426007817-1884-1-git-send-email-sudipm.mukherjee@gmail.com> References: <1426007817-1884-1-git-send-email-sudipm.mukherjee@gmail.com> Sender: linux-fbdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fbdev@vger.kernel.org X-Spam-Status: No, score=-6.8 required=5.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_HI, T_DKIM_INVALID, T_RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP fixed the build warning about comparison of pointer and integer. end of string was being compared to NULL. Signed-off-by: Sudip Mukherjee --- drivers/staging/sm750fb/sm750.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/sm750fb/sm750.c b/drivers/staging/sm750fb/sm750.c index 021b863..5532a28 100644 --- a/drivers/staging/sm750fb/sm750.c +++ b/drivers/staging/sm750fb/sm750.c @@ -1000,7 +1000,7 @@ static void sm750fb_setup(struct lynx_share * share,char * src) goto NO_PARAM; } - while((opt = strsep(&src,":")) != NULL && *opt != NULL){ + while((opt = strsep(&src,":")) != NULL && *opt != 0){ pr_err("opt=%s\n",opt); pr_err("src=%s\n",src);