From patchwork Wed Apr 29 02:14:46 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Huacai Chen X-Patchwork-Id: 6293431 Return-Path: X-Original-To: patchwork-linux-fbdev@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 812BB9F373 for ; Wed, 29 Apr 2015 02:17:24 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id B064D20266 for ; Wed, 29 Apr 2015 02:17:23 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id D69AC2018E for ; Wed, 29 Apr 2015 02:17:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1031386AbbD2CRV (ORCPT ); Tue, 28 Apr 2015 22:17:21 -0400 Received: from smtpbgau1.qq.com ([54.206.16.166]:55466 "EHLO smtpbgau1.qq.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1031377AbbD2CRU (ORCPT ); Tue, 28 Apr 2015 22:17:20 -0400 X-QQ-mid: bizesmtp7t1430273819t206t253 Received: from localhost.localdomain (unknown [222.92.8.142]) by esmtp4.qq.com (ESMTP) with id ; Wed, 29 Apr 2015 10:16:07 +0800 (CST) X-QQ-SSF: 01100000002000F0FJ52000A0000000 X-QQ-FEAT: /peYvah/M2U15AbV2zjO1o/V95C9NyPe25aMMWWK8NL4Zwb9IMWfo9DZH3Oky XGDHM8Oe9kyPMIsYGITqyJMOXtutJdhBL5Iv10LdcpaXGP0N+4gtx8pB3QFU9Fdjh4l6Mwn 5JWAn35X6JgEUf8ozL+VyWulsj5vFJFm+P8DoPpJNtfDS2mHB1xhef8/oriOmP32vEXuVQ4 W+/DSUzCH3Vo3XpXLU7bpqQwXqbYI3nWzFCMH8TrPyA== X-QQ-GoodBg: 0 From: Huacai Chen To: Greg Kroah-Hartman Cc: linux-fbdev@vger.kernel.org, Binbin Zhou , Fuxin Zhang , Huacai Chen , Teddy Wang , Sudip Mukherjee Subject: [PATCH V3] staging: sm750: Fix lynxfb_ops_imageblit() if image->depth != 1 Date: Wed, 29 Apr 2015 10:14:46 +0800 Message-Id: <1430273686-21682-1-git-send-email-chenhc@lemote.com> X-Mailer: git-send-email 1.7.7.3 X-QQ-SENDSIZE: 520 X-QQ-Bgrelay: 1 Sender: linux-fbdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fbdev@vger.kernel.org X-Spam-Status: No, score=-6.9 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, T_RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP If image->depth != 1, lynxfb_ops_imageblit() should fallback to call cfb_imageblit(), not return directly. Otherwise it can't display the boot logo. Cc: Teddy Wang Cc: Sudip Mukherjee Signed-off-by: Huacai Chen Acked-by: Sudip Mukherhee --- V2: Coding style ajustment. V3: Add TODO comments. drivers/staging/sm750fb/TODO | 1 + drivers/staging/sm750fb/sm750.c | 3 +++ 2 files changed, 4 insertions(+), 0 deletions(-) diff --git a/drivers/staging/sm750fb/TODO b/drivers/staging/sm750fb/TODO index bc16172..f8698498 100644 --- a/drivers/staging/sm750fb/TODO +++ b/drivers/staging/sm750fb/TODO @@ -2,6 +2,7 @@ TODO: - lots of clechpatch cleanup - use kernel coding style - refine the code and remove unused code +- Implement hardware acceleration for imageblit if image->depth > 1 - check on hardware effects of removal of USE_HW_I2C and USE_DVICHIP (these two are supposed to be sample code which is given here if someone wants to use those functionalities) diff --git a/drivers/staging/sm750fb/sm750.c b/drivers/staging/sm750fb/sm750.c index 3c7ea95..6f78de3 100644 --- a/drivers/staging/sm750fb/sm750.c +++ b/drivers/staging/sm750fb/sm750.c @@ -279,7 +279,10 @@ static void lynxfb_ops_imageblit(struct fb_info *info, } goto _do_work; } + /* TODO: Implement hardware acceleration for image->depth > 1 */ + cfb_imageblit(info, image); return; + _do_work: /* * If not use spin_lock, system will die if user load driver