diff mbox

[V3,RESEND] staging: sm750: Fix lynxfb_ops_imageblit() if image->depth != 1

Message ID 1431075868-15746-1-git-send-email-chenhc@lemote.com (mailing list archive)
State New, archived
Headers show

Commit Message

Huacai Chen May 8, 2015, 9:04 a.m. UTC 
If image->depth != 1, lynxfb_ops_imageblit() should fallback to call
cfb_imageblit(), not return directly. Otherwise it can't display the
boot logo.

Cc: Teddy Wang <teddy.wang@siliconmotion.com>
Acked-by: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
Signed-off-by: Huacai Chen <chenhc@lemote.com>
---
 V2: Coding style ajustment.
 V3: Add TODO comments.

 drivers/staging/sm750fb/TODO    |    1 +
 drivers/staging/sm750fb/sm750.c |    3 +++
 2 files changed, 4 insertions(+), 0 deletions(-)

Comments

Sudip Mukherjee May 8, 2015, 9:43 a.m. UTC | #1 
On Fri, May 08, 2015 at 05:04:28PM +0800, Huacai Chen wrote:
> If image->depth != 1, lynxfb_ops_imageblit() should fallback to call
> cfb_imageblit(), not return directly. Otherwise it can't display the
> boot logo.

why resending? 

regards
sudip
--
To unsubscribe from this list: send the line "unsubscribe linux-fbdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Greg Kroah-Hartman May 10, 2015, 1:17 p.m. UTC | #2 
On Fri, May 08, 2015 at 05:04:28PM +0800, Huacai Chen wrote:
> If image->depth != 1, lynxfb_ops_imageblit() should fallback to call
> cfb_imageblit(), not return directly. Otherwise it can't display the
> boot logo.
> 
> Cc: Teddy Wang <teddy.wang@siliconmotion.com>
> Acked-by: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
> Signed-off-by: Huacai Chen <chenhc@lemote.com>
> ---
>  V2: Coding style ajustment.
>  V3: Add TODO comments.
> 
>  drivers/staging/sm750fb/TODO    |    1 +
>  drivers/staging/sm750fb/sm750.c |    3 +++
>  2 files changed, 4 insertions(+), 0 deletions(-)

Doesn't apply without fuzz, so something isn't synced up properly here.
Please refresh it against my tree and resend.

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-fbdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/drivers/staging/sm750fb/TODO b/drivers/staging/sm750fb/TODO
index bc16172..f8698498 100644
--- a/drivers/staging/sm750fb/TODO
+++ b/drivers/staging/sm750fb/TODO
@@ -2,6 +2,7 @@  TODO:
 - lots of clechpatch cleanup
 - use kernel coding style
 - refine the code and remove unused code
+- Implement hardware acceleration for imageblit if image->depth > 1
 - check on hardware effects of removal of USE_HW_I2C and USE_DVICHIP (these two
 	are supposed to be sample code which is given here if someone wants to
 	use those functionalities)
diff --git a/drivers/staging/sm750fb/sm750.c b/drivers/staging/sm750fb/sm750.c
index 3c7ea95..6f78de3 100644
--- a/drivers/staging/sm750fb/sm750.c
+++ b/drivers/staging/sm750fb/sm750.c
@@ -279,7 +279,10 @@  static void lynxfb_ops_imageblit(struct fb_info *info,
 		}
 		goto _do_work;
 	}
+	/* TODO: Implement hardware acceleration for image->depth > 1 */
+	cfb_imageblit(info, image);
 	return;
+
 _do_work:
 	/*
 	 * If not use spin_lock, system will die if user load driver