From patchwork Mon May 11 03:08:22 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Huacai Chen X-Patchwork-Id: 6372841 Return-Path: X-Original-To: patchwork-linux-fbdev@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork1.web.kernel.org (Postfix) with ESMTP id A88A69F1C2 for ; Mon, 11 May 2015 03:09:57 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 72B9C202B4 for ; Mon, 11 May 2015 03:09:56 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 8ED91203E1 for ; Mon, 11 May 2015 03:09:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752000AbbEKDJw (ORCPT ); Sun, 10 May 2015 23:09:52 -0400 Received: from smtpbg299.qq.com ([184.105.67.99]:51471 "EHLO smtpbg299.qq.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751378AbbEKDJv (ORCPT ); Sun, 10 May 2015 23:09:51 -0400 X-QQ-mid: bizesmtp3t1431313780t531t057 Received: from localhost.localdomain (unknown [222.92.8.142]) by esmtp4.qq.com (ESMTP) with id ; Mon, 11 May 2015 11:09:32 +0800 (CST) X-QQ-SSF: 01100000002000F0FJ62B00A0000000 X-QQ-FEAT: FRkVFvYdryXqC6R6DiuaZcxyw79ZVdGJHDtWzgxaRz14u6z0IB2HkloGjgs/X MHjpYfz9SPMVS8qUeOKlw8JLvlJQbwKIm9OLMUnUq4WuYnoneWqSmF1Fx9sxLc7NJQ3MZpf MDGg3J6Thj5Tkf+ZvtUuY9xGV0mA5S6f8TIAYXjNbJUNKOMpHOwcp0MfXFg8ySJEHxm/Kyc R49v0UTVAHoJpN6Dkeii3ODq73RPzLvZzcpbmBuAQww== X-QQ-GoodBg: 0 From: Huacai Chen To: Greg Kroah-Hartman Cc: devel@driverdev.osuosl.org, linux-fbdev@vger.kernel.org, Binbin Zhou , Fuxin Zhang , Huacai Chen , Teddy Wang Subject: [PATCH V4] staging: sm750: Fix lynxfb_ops_imageblit() if image->depth != 1 Date: Mon, 11 May 2015 11:08:22 +0800 Message-Id: <1431313702-14975-1-git-send-email-chenhc@lemote.com> X-Mailer: git-send-email 1.7.7.3 X-QQ-SENDSIZE: 520 X-QQ-FName: B0B9606DA8304C66916F34142B74DB41 X-QQ-LocalIP: 58.250.134.100 Sender: linux-fbdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fbdev@vger.kernel.org X-Spam-Status: No, score=-6.9 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, T_RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP If image->depth != 1, lynxfb_ops_imageblit() should fallback to call cfb_imageblit(), not return directly. Otherwise it can't display the boot logo. Cc: Teddy Wang Acked-by: Sudip Mukherjee Signed-off-by: Huacai Chen --- V2: Coding style ajustment. V3: Add TODO comments. V4: Rebase on latest code. drivers/staging/sm750fb/TODO | 1 + drivers/staging/sm750fb/sm750.c | 3 +++ 2 files changed, 4 insertions(+), 0 deletions(-) diff --git a/drivers/staging/sm750fb/TODO b/drivers/staging/sm750fb/TODO index bc16172..f8698498 100644 --- a/drivers/staging/sm750fb/TODO +++ b/drivers/staging/sm750fb/TODO @@ -2,6 +2,7 @@ TODO: - lots of checkpatch cleanup - use kernel coding style - refine the code and remove unused code +- Implement hardware acceleration for imageblit if image->depth > 1 - check on hardware effects of removal of USE_HW_I2C and USE_DVICHIP (these two are supposed to be sample code which is given here if someone wants to use those functionalities) diff --git a/drivers/staging/sm750fb/sm750.c b/drivers/staging/sm750fb/sm750.c index 3c7ea95..6f78de3 100644 --- a/drivers/staging/sm750fb/sm750.c +++ b/drivers/staging/sm750fb/sm750.c @@ -279,7 +279,10 @@ static void lynxfb_ops_imageblit(struct fb_info *info, } goto _do_work; } + /* TODO: Implement hardware acceleration for image->depth > 1 */ + cfb_imageblit(info, image); return; + _do_work: /* * If not use spin_lock, system will die if user load driver