[v6,2/4] drivers/video/fbdev/atyfb: Clarify ioremap() base and length used

Commit Message

Luis R. Rodriguez July 10, 2015, 1:24 a.m. UTC

From: "Luis R. Rodriguez" <[e-mail]>

Adjust the ioremap() call for the framebuffer to use the same values we
later use for the framebuffer. This will make it easier to review the
next change.

The size of the framebuffer varies but since this is for PCI we *know*
this defaults to 0x800000. atyfb_setup_generic() is *only* used on PCI
probe.

No functional change.

Signed-off-by: Luis R. Rodriguez <[e-mail]>
Cc: [e-mail]
Cc: Andrew Morton <[e-mail]>
Cc: Andrzej Hajda <[e-mail]>
Cc: Andy Lutomirski <[e-mail]>
Cc: Antonino Daplas <[e-mail]>
Cc: [e-mail]
Cc: Daniel Vetter <[e-mail]>
Cc: Dave Airlie <[e-mail]>
Cc: Davidlohr Bueso <[e-mail]>
Cc: H. Peter Anvin <[e-mail]>
Cc: Ingo Molnar <[e-mail]>
Cc: Jean-Christophe Plagniol-Villard <[e-mail]>
Cc: Juergen Gross <[e-mail]>
Cc: Linus Torvalds <[e-mail]>
Cc: [e-mail]
Cc: [e-mail]
Cc: Mathias Krause <[e-mail]>
Cc: Mel Gorman <[e-mail]>
Cc: [e-mail]
Cc: Rob Clark <[e-mail]>
Cc: Suresh Siddha <[e-mail]>
Cc: [e-mail]
Cc: Thomas Gleixner <[e-mail]>
Cc: Tomi Valkeinen <[e-mail]>
Cc: Toshi Kani <[e-mail]>
Cc: Ville Syrjälä <[e-mail]>
Cc: Vlastimil Babka <[e-mail]>
Signed-off-by: Borislav Petkov <[e-mail]>
---
 drivers/video/fbdev/aty/atyfb_base.c | 16 +++++++++++++++-
 1 file changed, 15 insertions(+), 1 deletion(-)

Patch

diff --git a/drivers/video/fbdev/aty/atyfb_base.c b/drivers/video/fbdev/aty/atyfb_base.c
index 16936bb1f865..513e58df9d3f 100644
--- a/drivers/video/fbdev/aty/atyfb_base.c
+++ b/drivers/video/fbdev/aty/atyfb_base.c
@@ -3489,7 +3489,21 @@  static int atyfb_setup_generic(struct pci_dev *pdev, struct fb_info *info,
 
 	/* Map in frame buffer */
 	info->fix.smem_start = addr;
-	info->screen_base = ioremap(addr, 0x800000);
+
+	/*
+	 * The framebuffer is not always 8 MiB that's just the size of the
+	 * PCI BAR. We temporarily abuse smem_len here to store the size
+	 * of the BAR. aty_init() will later correct it to match the actual
+	 * framebuffer size.
+	 *
+	 * On devices that don't have the auxiliary register aperture, the
+	 * registers are housed at the top end of the framebuffer PCI BAR.
+	 * aty_fudge_framebuffer_len() is used to reduce smem_len to not
+	 * overlap with the registers.
+	 */
+	info->fix.smem_len = 0x800000;
+
+	info->screen_base = ioremap(info->fix.smem_start, info->fix.smem_len);
 	if (info->screen_base == NULL) {
 		ret = -ENOMEM;
 		goto atyfb_setup_generic_fail;