From patchwork Mon Jul 27 15:41:41 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Rob Herring (Arm)" X-Patchwork-Id: 6875271 Return-Path: X-Original-To: patchwork-linux-fbdev@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 793709F358 for ; Mon, 27 Jul 2015 15:41:53 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id B651C206F8 for ; Mon, 27 Jul 2015 15:41:51 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 5246320612 for ; Mon, 27 Jul 2015 15:41:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753279AbbG0Plt (ORCPT ); Mon, 27 Jul 2015 11:41:49 -0400 Received: from mail-oi0-f48.google.com ([209.85.218.48]:33844 "EHLO mail-oi0-f48.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752691AbbG0Pls (ORCPT ); Mon, 27 Jul 2015 11:41:48 -0400 Received: by oigd21 with SMTP id d21so53662989oig.1; Mon, 27 Jul 2015 08:41:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:from:to:cc:subject:date:message-id; bh=WGezUp6ACx6TS3ZH4AadTqcZn3Ih8akZ+n04e/vsr64=; b=v1YyIoRCp6XgAuoBS3Vo8V5Eb7HCucX5GbqGWklC8JKtKlGl1zs9/YEmfmJSEEmhcx LUSOTwIpwxx5N/Fb4GcESmIVe2Co946kYnpjKpAlOEM/CJtCueI/j+Nje3FKrS6lxtF4 zNDULUNOIPiRx5ZihLPEwCZp/pdkSjSR5TGLNzE9OPcHUsUXymPGrZ/XhxMpy6W41/5e +mJ0IAKk1zNxKaHn6Y2PVRf17IH9ftBwK2YXdE4Ic1tegrNubgy6UxiIN3zvrqmNIubf /TtGl+nWWveMqmIJUzyUXHOuDTDwBpWQbS2eCEF9JT1L6LYP/LG/qNsshbpeudxe9yMS AY9w== X-Received: by 10.202.105.210 with SMTP id e201mr27454098oic.83.1438011707861; Mon, 27 Jul 2015 08:41:47 -0700 (PDT) Received: from rob-hp-laptop.herring.priv (72-48-98-129.dyn.grandenetworks.net. [72.48.98.129]) by smtp.googlemail.com with ESMTPSA id mu5sm10656641obc.4.2015.07.27.08.41.47 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Mon, 27 Jul 2015 08:41:47 -0700 (PDT) From: Rob Herring To: Tomi Valkeinen Cc: linux-kernel@vger.kernel.org, linux-fbdev@vger.kernel.org, Nicolas Ferre , Jean-Christophe Plagniol-Villard Subject: [PATCH] video: fbdev: atmel: fix warning for const return value Date: Mon, 27 Jul 2015 10:41:41 -0500 Message-Id: <1438011701-18423-1-git-send-email-robh@kernel.org> X-Mailer: git-send-email 2.1.0 Sender: linux-fbdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fbdev@vger.kernel.org X-Spam-Status: No, score=-8.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_HI,RP_MATCHES_RCVD,T_DKIM_INVALID,UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP A const on a return value is meaningless and generates a warning on some versions of gcc: drivers/video/fbdev/atmel_lcdfb.c:1003: warning: type qualifiers ignored on function return type This was found on 0-day with avr32 builds with CONFIG_OF enabled, but it doesn't seem to generate warnings for other arches. Reported-by: Fengguang Wu Signed-off-by: Rob Herring Cc: Nicolas Ferre Cc: Jean-Christophe Plagniol-Villard Cc: Tomi Valkeinen Acked-by: Nicolas Ferre --- drivers/video/fbdev/atmel_lcdfb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/video/fbdev/atmel_lcdfb.c b/drivers/video/fbdev/atmel_lcdfb.c index abadc49..66f4b70 100644 --- a/drivers/video/fbdev/atmel_lcdfb.c +++ b/drivers/video/fbdev/atmel_lcdfb.c @@ -999,7 +999,7 @@ static const char *atmel_lcdfb_wiring_modes[] = { [ATMEL_LCDC_WIRING_RGB] = "RGB", }; -const int atmel_lcdfb_get_of_wiring_modes(struct device_node *np) +int atmel_lcdfb_get_of_wiring_modes(struct device_node *np) { const char *mode; int err, i;