From patchwork Tue May 19 21:40:12 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Thierry Reding X-Patchwork-Id: 6440681 Return-Path: X-Original-To: patchwork-linux-fbdev@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork2.web.kernel.org (Postfix) with ESMTP id DC5BBC0432 for ; Tue, 19 May 2015 21:40:22 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 400C6203B6 for ; Tue, 19 May 2015 21:40:22 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 8838F203B5 for ; Tue, 19 May 2015 21:40:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752163AbbESVkU (ORCPT ); Tue, 19 May 2015 17:40:20 -0400 Received: from mail-pa0-f52.google.com ([209.85.220.52]:35211 "EHLO mail-pa0-f52.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752248AbbESVkS (ORCPT ); Tue, 19 May 2015 17:40:18 -0400 Received: by pacwv17 with SMTP id wv17so40733994pac.2; Tue, 19 May 2015 14:40:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=date:from:to:cc:subject:message-id:references:mime-version :content-type:content-disposition:in-reply-to:user-agent; bh=kNLw/LtbnXgim5U1j9NMNvKRUsr7Q+CogAY5cUJTITg=; b=Iwm/btgf6hklr0YO95w8a84U9QpUUhwEqyNzc3JbY/2ziOYkS5iaV4GO6WY0/3cHHk 5FD0w1nCX6L1cUSKaFc/q/ZqU8/4rxwFWqFgHGRY6z/lfvu4x0epHsPiuS6Ycj9B7HH8 lajetMdoGxNPdGkYq0n2Iu9h+MBd7z1VLrcdU/cuDy9K+TUIIfQnYvH3FA1BtFXO7ULa JrZRw6rwNiKPMQhceUk+rT0LpTkwHP5LIUYMVGmooOi1G5jug2ZiuO8wavwWtLOORROd 1ojTgkPjcyfxdN9TGPOTL2VArR8XeJgVWLaxi7MQwuc5byhKEpBBVT9u6S2AdqHjLGmW n3zA== X-Received: by 10.70.119.36 with SMTP id kr4mr58854097pdb.39.1432071617126; Tue, 19 May 2015 14:40:17 -0700 (PDT) Received: from localhost ([216.228.120.20]) by mx.google.com with ESMTPSA id el6sm13988145pdb.93.2015.05.19.14.40.15 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 19 May 2015 14:40:16 -0700 (PDT) Date: Tue, 19 May 2015 23:40:12 +0200 From: Thierry Reding To: Kevin Hilman Cc: Scot Doyle , Greg Kroah-Hartman , Tomi Valkeinen , Michael Kerrisk , Jiri Slaby , Jean-Christophe Plagniol-Villard , Pavel Machek , Geert Uytterhoeven , lkml , linux-fbdev@vger.kernel.org, linux-man@vger.kernel.org, linux-api@vger.kernel.org, Tyler Baker , Olof Johansson , Daniel Stone , Arnd Bergmann Subject: Re: [PATCH v2 2/3] fbcon: use the cursor blink interval provided by vt Message-ID: <20150519214011.GA27047@ulmo.nvidia.com> References: <20150225094946.GA24627@amd> <20150226220243.GC9935@amd> <20150325111949.GA24230@kroah.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-fbdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fbdev@vger.kernel.org X-Spam-Status: No, score=-6.8 required=5.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_HI, T_DKIM_INVALID, T_RP_MATCHES_RCVD, T_TVD_MIME_EPI, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP On Tue, May 19, 2015 at 02:15:41PM -0700, Kevin Hilman wrote: > On Thu, Mar 26, 2015 at 6:56 AM, Scot Doyle wrote: > > vt now provides a cursor blink interval via vc_data. Use this > > interval instead of the currently hardcoded 200 msecs. Store it in > > fbcon_ops to avoid locking the console in cursor_timer_handler(). > > > > Signed-off-by: Scot Doyle > > Acked-by: Pavel Machek > > This patch hit next-20150519 in the form of commit 27a4c827c34a > (fbcon: use the cursor blink interval provided by vt) and has caused > boot failure on a handful of ARM platforms when booting a MMC root > filesystem. This error was spotted by the kernelci.org bot on > exynos5800-peach-pi[1] and Thierry and Daniel (Cc'd) have seen it on > some tegra platforms too. > > Thierry spotted this commit as a potential cause, and both Daniel and > I have reverted and boot tested on exynos5 and tegra respectively and > the boot panics disappear. FWIW, if I apply the below on top of next-20150519 things seem to be back to normal as well: Tested-by: Kevin Hilman Tested-by: Scot Doyle diff --git a/drivers/video/console/fbcon.c b/drivers/video/console/fbcon.c index 05b1d1a71ef9..658c34bb9076 100644 --- a/drivers/video/console/fbcon.c +++ b/drivers/video/console/fbcon.c @@ -1310,8 +1310,9 @@ static void fbcon_cursor(struct vc_data *vc, int mode) return; ops->cur_blink_jiffies = msecs_to_jiffies(vc->vc_cur_blink_ms); - fbcon_del_cursor_timer(info); - if (!(vc->vc_cursor_type & 0x10)) + if (vc->vc_cursor_type & 0x10) + fbcon_del_cursor_timer(info); + else fbcon_add_cursor_timer(info); ops->cursor_flash = (mode == CM_ERASE) ? 0 : 1;