| Message ID | 20190722182439.44844-5-dianders@chromium.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | video: of: display_timing: Adjust err printing of of_get_display_timing() | expand |
On Mon, Jul 22, 2019 at 8:25 PM Douglas Anderson <dianders@chromium.org> wrote: > In the patch ("video: of: display_timing: Don't yell if no timing node > is present") we'll stop spouting an error directly in > of_get_display_timing() if no node is present. Presumably amba-clcd > should take charge of spouting its own error now. > > NOTE: we'll print two errors if the node was present but there were > problems parsing the timing node (one in of_parse_display_timing() and > this new one). Since this is a fatal error for the driver's probe > (and presumably someone will be debugging), this should be OK. > > Signed-off-by: Douglas Anderson <dianders@chromium.org> Acked-by: Linus Walleij <linus.walleij@linaro.org> Yours, Linus Walleij
diff --git a/drivers/video/fbdev/amba-clcd.c b/drivers/video/fbdev/amba-clcd.c index 89324e42a033..7de43be6ef2c 100644 --- a/drivers/video/fbdev/amba-clcd.c +++ b/drivers/video/fbdev/amba-clcd.c @@ -561,8 +561,10 @@ static int clcdfb_of_get_dpi_panel_mode(struct device_node *node, struct videomode video; err = of_get_display_timing(node, "panel-timing", &timing); - if (err) + if (err) { + pr_err("%pOF: problems parsing panel-timing (%d)\n", node, err); return err; + } videomode_from_timing(&timing, &video);
In the patch ("video: of: display_timing: Don't yell if no timing node is present") we'll stop spouting an error directly in of_get_display_timing() if no node is present. Presumably amba-clcd should take charge of spouting its own error now. NOTE: we'll print two errors if the node was present but there were problems parsing the timing node (one in of_parse_display_timing() and this new one). Since this is a fatal error for the driver's probe (and presumably someone will be debugging), this should be OK. Signed-off-by: Douglas Anderson <dianders@chromium.org> --- drivers/video/fbdev/amba-clcd.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)