| Message ID | 20191012011956.9452-1-gabrielabittencourt00@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | staging: sm750fb: align arguments with open parenthesis | expand |
On Fri, 2019-10-11 at 22:19 -0300, Gabriela Bittencourt wrote: > Cleans up checks of "Alignment should match open parenthesis" in tree sm750fb [] > diff --git a/drivers/staging/sm750fb/sm750_accel.c b/drivers/staging/sm750fb/sm750_accel.c [] > @@ -289,7 +289,7 @@ static unsigned int deGetTransparency(struct lynx_accel *accel) > } > > int sm750_hw_imageblit(struct lynx_accel *accel, > - const char *pSrcbuf, /* pointer to start of source buffer in system memory */ > + const char *pSrcbuf, /* pointer to start of source buffer in system memory */ > u32 srcDelta, /* Pitch value (in bytes) of the source buffer, +ive means top down and -ive mean button up */ checkpatch only warns on the first unaligned argument, but all statement lines are meant to align to the open parenthesis. > u32 startBit, /* Mono data can start at any bit in a byte, this value should be 0 to 7 */ > u32 dBase, /* Address of destination: offset in frame buffer */
On Fri, 11 Oct 2019, Gabriela Bittencourt wrote: > Cleans up checks of "Alignment should match open parenthesis" in tree sm750fb > > Signed-off-by: Gabriela Bittencourt <gabrielabittencourt00@gmail.com> > --- > drivers/staging/sm750fb/ddk750_display.c | 2 +- > drivers/staging/sm750fb/sm750_accel.c | 2 +- > drivers/staging/sm750fb/sm750_accel.h | 8 ++++---- > drivers/staging/sm750fb/sm750_cursor.h | 10 +++++----- > 4 files changed, 11 insertions(+), 11 deletions(-) > > diff --git a/drivers/staging/sm750fb/ddk750_display.c b/drivers/staging/sm750fb/ddk750_display.c > index 887ea8aef43f..8be98a1058d6 100644 > --- a/drivers/staging/sm750fb/ddk750_display.c > +++ b/drivers/staging/sm750fb/ddk750_display.c > @@ -148,7 +148,7 @@ void ddk750_set_logical_disp_out(enum disp_output output) > if (output & PNL_SEQ_USAGE) { > /* set panel sequence */ > sw_panel_power_sequence((output & PNL_SEQ_MASK) >> PNL_SEQ_OFFSET, > - 4); > + 4); > } > > if (output & DAC_USAGE) > diff --git a/drivers/staging/sm750fb/sm750_accel.c b/drivers/staging/sm750fb/sm750_accel.c > index dbcbbd1055da..1a9555bb9edd 100644 > --- a/drivers/staging/sm750fb/sm750_accel.c > +++ b/drivers/staging/sm750fb/sm750_accel.c > @@ -289,7 +289,7 @@ static unsigned int deGetTransparency(struct lynx_accel *accel) > } > > int sm750_hw_imageblit(struct lynx_accel *accel, > - const char *pSrcbuf, /* pointer to start of source buffer in system memory */ > + const char *pSrcbuf, /* pointer to start of source buffer in system memory */ > u32 srcDelta, /* Pitch value (in bytes) of the source buffer, +ive means top down and -ive mean button up */ > u32 startBit, /* Mono data can start at any bit in a byte, this value should be 0 to 7 */ > u32 dBase, /* Address of destination: offset in frame buffer */ It is strange that the change is only does for the firsr parameter, and not for all of them. The kernel also uses a doc format for describing function patameters in a single comment before the function. Look around in other files to see the format. That would look much nicer than these comments going over 80 columns. > diff --git a/drivers/staging/sm750fb/sm750_accel.h b/drivers/staging/sm750fb/sm750_accel.h > index c4f42002a50f..8fb79b09fdd0 100644 > --- a/drivers/staging/sm750fb/sm750_accel.h > +++ b/drivers/staging/sm750fb/sm750_accel.h > @@ -190,9 +190,9 @@ void sm750_hw_set2dformat(struct lynx_accel *accel, int fmt); > void sm750_hw_de_init(struct lynx_accel *accel); > > int sm750_hw_fillrect(struct lynx_accel *accel, > - u32 base, u32 pitch, u32 Bpp, > - u32 x, u32 y, u32 width, u32 height, > - u32 color, u32 rop); > + u32 base, u32 pitch, u32 Bpp, > + u32 x, u32 y, u32 width, u32 height, > + u32 color, u32 rop); > > int sm750_hw_copyarea( > struct lynx_accel *accel, > @@ -210,7 +210,7 @@ unsigned int height, /* width and height of rectangle in pixel value */ > unsigned int rop2); > > int sm750_hw_imageblit(struct lynx_accel *accel, > - const char *pSrcbuf, /* pointer to start of source buffer in system memory */ > + const char *pSrcbuf, /* pointer to start of source buffer in system memory */ > u32 srcDelta, /* Pitch value (in bytes) of the source buffer, +ive means top down and -ive mean button up */ > u32 startBit, /* Mono data can start at any bit in a byte, this value should be 0 to 7 */ > u32 dBase, /* Address of destination: offset in frame buffer */ Same here. > diff --git a/drivers/staging/sm750fb/sm750_cursor.h b/drivers/staging/sm750fb/sm750_cursor.h > index 16ac07eb58d6..039ebfdf0bd9 100644 > --- a/drivers/staging/sm750fb/sm750_cursor.h > +++ b/drivers/staging/sm750fb/sm750_cursor.h > @@ -6,13 +6,13 @@ > void sm750_hw_cursor_enable(struct lynx_cursor *cursor); > void sm750_hw_cursor_disable(struct lynx_cursor *cursor); > void sm750_hw_cursor_setSize(struct lynx_cursor *cursor, > - int w, int h); > + int w, int h); > void sm750_hw_cursor_setPos(struct lynx_cursor *cursor, > - int x, int y); > + int x, int y); Perhaps these could just be all on one line? julia > void sm750_hw_cursor_setColor(struct lynx_cursor *cursor, > - u32 fg, u32 bg); > + u32 fg, u32 bg); > void sm750_hw_cursor_setData(struct lynx_cursor *cursor, > - u16 rop, const u8 *data, const u8 *mask); > + u16 rop, const u8 *data, const u8 *mask); > void sm750_hw_cursor_setData2(struct lynx_cursor *cursor, > - u16 rop, const u8 *data, const u8 *mask); > + u16 rop, const u8 *data, const u8 *mask); > #endif > -- > 2.20.1 > > -- > You received this message because you are subscribed to the Google Groups "outreachy-kernel" group. > To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com. > To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20191012011956.9452-1-gabrielabittencourt00%40gmail.com. >
diff --git a/drivers/staging/sm750fb/ddk750_display.c b/drivers/staging/sm750fb/ddk750_display.c index 887ea8aef43f..8be98a1058d6 100644 --- a/drivers/staging/sm750fb/ddk750_display.c +++ b/drivers/staging/sm750fb/ddk750_display.c @@ -148,7 +148,7 @@ void ddk750_set_logical_disp_out(enum disp_output output) if (output & PNL_SEQ_USAGE) { /* set panel sequence */ sw_panel_power_sequence((output & PNL_SEQ_MASK) >> PNL_SEQ_OFFSET, - 4); + 4); } if (output & DAC_USAGE) diff --git a/drivers/staging/sm750fb/sm750_accel.c b/drivers/staging/sm750fb/sm750_accel.c index dbcbbd1055da..1a9555bb9edd 100644 --- a/drivers/staging/sm750fb/sm750_accel.c +++ b/drivers/staging/sm750fb/sm750_accel.c @@ -289,7 +289,7 @@ static unsigned int deGetTransparency(struct lynx_accel *accel) } int sm750_hw_imageblit(struct lynx_accel *accel, - const char *pSrcbuf, /* pointer to start of source buffer in system memory */ + const char *pSrcbuf, /* pointer to start of source buffer in system memory */ u32 srcDelta, /* Pitch value (in bytes) of the source buffer, +ive means top down and -ive mean button up */ u32 startBit, /* Mono data can start at any bit in a byte, this value should be 0 to 7 */ u32 dBase, /* Address of destination: offset in frame buffer */ diff --git a/drivers/staging/sm750fb/sm750_accel.h b/drivers/staging/sm750fb/sm750_accel.h index c4f42002a50f..8fb79b09fdd0 100644 --- a/drivers/staging/sm750fb/sm750_accel.h +++ b/drivers/staging/sm750fb/sm750_accel.h @@ -190,9 +190,9 @@ void sm750_hw_set2dformat(struct lynx_accel *accel, int fmt); void sm750_hw_de_init(struct lynx_accel *accel); int sm750_hw_fillrect(struct lynx_accel *accel, - u32 base, u32 pitch, u32 Bpp, - u32 x, u32 y, u32 width, u32 height, - u32 color, u32 rop); + u32 base, u32 pitch, u32 Bpp, + u32 x, u32 y, u32 width, u32 height, + u32 color, u32 rop); int sm750_hw_copyarea( struct lynx_accel *accel, @@ -210,7 +210,7 @@ unsigned int height, /* width and height of rectangle in pixel value */ unsigned int rop2); int sm750_hw_imageblit(struct lynx_accel *accel, - const char *pSrcbuf, /* pointer to start of source buffer in system memory */ + const char *pSrcbuf, /* pointer to start of source buffer in system memory */ u32 srcDelta, /* Pitch value (in bytes) of the source buffer, +ive means top down and -ive mean button up */ u32 startBit, /* Mono data can start at any bit in a byte, this value should be 0 to 7 */ u32 dBase, /* Address of destination: offset in frame buffer */ diff --git a/drivers/staging/sm750fb/sm750_cursor.h b/drivers/staging/sm750fb/sm750_cursor.h index 16ac07eb58d6..039ebfdf0bd9 100644 --- a/drivers/staging/sm750fb/sm750_cursor.h +++ b/drivers/staging/sm750fb/sm750_cursor.h @@ -6,13 +6,13 @@ void sm750_hw_cursor_enable(struct lynx_cursor *cursor); void sm750_hw_cursor_disable(struct lynx_cursor *cursor); void sm750_hw_cursor_setSize(struct lynx_cursor *cursor, - int w, int h); + int w, int h); void sm750_hw_cursor_setPos(struct lynx_cursor *cursor, - int x, int y); + int x, int y); void sm750_hw_cursor_setColor(struct lynx_cursor *cursor, - u32 fg, u32 bg); + u32 fg, u32 bg); void sm750_hw_cursor_setData(struct lynx_cursor *cursor, - u16 rop, const u8 *data, const u8 *mask); + u16 rop, const u8 *data, const u8 *mask); void sm750_hw_cursor_setData2(struct lynx_cursor *cursor, - u16 rop, const u8 *data, const u8 *mask); + u16 rop, const u8 *data, const u8 *mask); #endif
Cleans up checks of "Alignment should match open parenthesis" in tree sm750fb Signed-off-by: Gabriela Bittencourt <gabrielabittencourt00@gmail.com> --- drivers/staging/sm750fb/ddk750_display.c | 2 +- drivers/staging/sm750fb/sm750_accel.c | 2 +- drivers/staging/sm750fb/sm750_accel.h | 8 ++++---- drivers/staging/sm750fb/sm750_cursor.h | 10 +++++----- 4 files changed, 11 insertions(+), 11 deletions(-)