From patchwork Sun May 17 22:05:23 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Emil Velikov X-Patchwork-Id: 11554401 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id C3589912 for ; Sun, 17 May 2020 22:08:16 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A984C207D8 for ; Sun, 17 May 2020 22:08:16 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="lsbMd8LB" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726299AbgEQWIQ (ORCPT ); Sun, 17 May 2020 18:08:16 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46138 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726438AbgEQWIQ (ORCPT ); Sun, 17 May 2020 18:08:16 -0400 Received: from mail-wm1-x341.google.com (mail-wm1-x341.google.com [IPv6:2a00:1450:4864:20::341]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 91B8FC061A0C for ; Sun, 17 May 2020 15:08:14 -0700 (PDT) Received: by mail-wm1-x341.google.com with SMTP id w64so8202490wmg.4 for ; Sun, 17 May 2020 15:08:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=L84eJGx9nrBqB4ScS+pZZVQbMN8D1zpwWqD1mcXWMRo=; b=lsbMd8LBESCC1CS6XdcoNp4FHO5Q5lU3uDTrLk0cjtrsZtBbeCdHxhlcUN1grz70JG EEA74kNc+KkGSvydt2S9Iywv6XhQ7uzLOwXewMgMe50Hvrgum/zMbn/H/tBY+xxR1e4O sMagNsYN8Kkx+cN/dwQQv2BdG81I/FZMtGH1XpYLYYUbu9kJ2TV+6TyoLuL/Z+VV3//I 9pgHTvwwtDP91oZmNttEepYzgxlj1z2sQO/jwj9BOxC31xfZ37xhcw/EGiVtkMCXNf12 pMUxQxvtyuPqBQm6QRYzD0+Fempd8rbJJFMyZFDceUEDUWs1g0fwhJlxeP/ogxTW4Mfd ldXQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=L84eJGx9nrBqB4ScS+pZZVQbMN8D1zpwWqD1mcXWMRo=; b=BmPIvnHjEgEtK0EzfvcbKyAk4oF+Euxu1sW2ViFcJ3HQNJx13xYvalpGaqA6aiC0iE X4n7bSlNW6mvFv50JSlmJEJffeIFlTE2AifDf39JnTeair58/rHdMJmxw7qIerxSU4eV FfpM/pXbufG40y0jc54M97t1qndN6MXW+ppKew82y64B/ztT1kxKjhCV9aNCydNGPSWN f+ejKdEKZsi01ghWrKGnoz4M2ITBY2R/QLOHoY1ccNnqfoTi27QRvsONx3bT7Xqr9uSP RD8P/Ao85CtRxk9dhLU4yBMXfawUXnpgdFm4C5EvY7zxomF5zsrXSOtdGSlPDOA3yMon 7vvQ== X-Gm-Message-State: AOAM533ARSP8sMbElWz83SBVS0K3De5++4J+RldzQRsOrZfIVo2JHg3q ZlN8YccZ0xEJfnr85RtrkT8= X-Google-Smtp-Source: ABdhPJxFmsVmzuCAAXDb7Ie+EhKSRU9KNaJEROz6onOoR7FWnj3tr2kR/+uAq5xSOpNHJJEVlyyrPw== X-Received: by 2002:a1c:2943:: with SMTP id p64mr172717wmp.42.1589753293111; Sun, 17 May 2020 15:08:13 -0700 (PDT) Received: from localhost.localdomain (cpc91192-cmbg18-2-0-cust374.5-4.cable.virginm.net. [80.6.113.119]) by smtp.gmail.com with ESMTPSA id d9sm13805482wmd.10.2020.05.17.15.08.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 17 May 2020 15:08:12 -0700 (PDT) From: Emil Velikov To: dri-devel@lists.freedesktop.org Cc: emil.l.velikov@gmail.com, Antonino Daplas , Bartlomiej Zolnierkiewicz , linux-fbdev@vger.kernel.org Subject: [PATCH v2 1/2] fbdev: annotate rivafb/nvidiafb as obsolete Date: Sun, 17 May 2020 23:05:23 +0100 Message-Id: <20200517220524.4036334-1-emil.l.velikov@gmail.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Sender: linux-fbdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fbdev@vger.kernel.org Drivers have not seen any love for years. Be that fixes or improvements, or cosmetics like introducing symbolic names, style and code-flow polish. Seemingly the maintainer has also disappeared years ago :-\ Considering nouveau supports all that hardware (modulo nv03) just mark these as obsolete/broken, referring to nouveau in the help text. v2 (Bartlomiej): - split config changes into separate patch - spell out nouveau DRM driver - don't use BROKEN - add runtime warning Cc: Antonino Daplas Cc: Bartlomiej Zolnierkiewicz Cc: linux-fbdev@vger.kernel.org Cc: dri-devel@lists.freedesktop.org Signed-off-by: Emil Velikov Acked-by: Daniel Vetter (v1) --- MAINTAINERS | 3 +-- drivers/video/fbdev/Kconfig | 4 ++++ drivers/video/fbdev/nvidia/nvidia.c | 3 +++ drivers/video/fbdev/riva/fbdev.c | 3 +++ 4 files changed, 11 insertions(+), 2 deletions(-) diff --git a/MAINTAINERS b/MAINTAINERS index 938316092634..c9498dd15e4a 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -12055,9 +12055,8 @@ F: include/linux/nubus.h F: include/uapi/linux/nubus.h NVIDIA (rivafb and nvidiafb) FRAMEBUFFER DRIVER -M: Antonino Daplas L: linux-fbdev@vger.kernel.org -S: Maintained +S: Obsolete F: drivers/video/fbdev/nvidia/ F: drivers/video/fbdev/riva/ diff --git a/drivers/video/fbdev/Kconfig b/drivers/video/fbdev/Kconfig index fa88e8b9a83d..ccddd06ab430 100644 --- a/drivers/video/fbdev/Kconfig +++ b/drivers/video/fbdev/Kconfig @@ -881,6 +881,8 @@ config FB_NVIDIA select BITREVERSE select VGASTATE help + Obsolete, use the nouveau DRM driver instead. + This driver supports graphics boards with the nVidia chips, TNT and newer. For very old chipsets, such as the RIVA128, then use the rivafb. @@ -928,6 +930,8 @@ config FB_RIVA select BITREVERSE select VGASTATE help + Obsolete, use the nouveau DRM driver instead. + This driver supports graphics boards with the nVidia Riva/Geforce chips. Say Y if you have such a graphics board. diff --git a/drivers/video/fbdev/nvidia/nvidia.c b/drivers/video/fbdev/nvidia/nvidia.c index c24de9107958..a958612ef75b 100644 --- a/drivers/video/fbdev/nvidia/nvidia.c +++ b/drivers/video/fbdev/nvidia/nvidia.c @@ -1512,6 +1512,9 @@ static struct pci_driver nvidiafb_driver = { static int nvidiafb_init(void) { + pr_warn("Legacy nvidiafb framebuffer driver will be removed in 2022\n" + "Please switch to nouveau DRM driver\n"); + #ifndef MODULE char *option = NULL; diff --git a/drivers/video/fbdev/riva/fbdev.c b/drivers/video/fbdev/riva/fbdev.c index 764ec3285e62..c2788e22f5c1 100644 --- a/drivers/video/fbdev/riva/fbdev.c +++ b/drivers/video/fbdev/riva/fbdev.c @@ -2160,6 +2160,9 @@ static struct pci_driver rivafb_driver = { static int rivafb_init(void) { + pr_warn("Legacy rivafb framebuffer driver will be removed in 2022\n" + "Please switch to nouveau DRM driver\n"); + #ifndef MODULE char *option = NULL;