| Message ID | 20201128224114.1033617-29-sam@ravnborg.org (mailing list archive) |
|---|---|
| State | Superseded, archived |
| Headers | show |
| Series | drivers/video: W=1 warning fixes | expand |
Am 28.11.20 um 23:41 schrieb Sam Ravnborg: > Fix following W=1 warnings: > - Fix set but not nused variables which was used only for logging. s/nused/used s/which was/that were Otherwise Reviewed-by: Thomas Zimmermann <tzimmermann@suse.de> > Fixed by introducing no_printk() to trick compiler to think variables > are used > - Fix kernel-doc warning by deleting an empty comment line > > v2: > - Subject updated (Lee) > > Signed-off-by: Sam Ravnborg <sam@ravnborg.org> > Cc: Kristoffer Ericson <kristoffer.ericson@gmail.com> > Cc: Lee Jones <lee.jones@linaro.org> > --- > drivers/video/fbdev/s1d13xxxfb.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/video/fbdev/s1d13xxxfb.c b/drivers/video/fbdev/s1d13xxxfb.c > index 4541afcf9386..d1b5f965bc96 100644 > --- a/drivers/video/fbdev/s1d13xxxfb.c > +++ b/drivers/video/fbdev/s1d13xxxfb.c > @@ -45,7 +45,7 @@ > #if 0 > #define dbg(fmt, args...) do { printk(KERN_INFO fmt, ## args); } while(0) > #else > -#define dbg(fmt, args...) do { } while (0) > +#define dbg(fmt, args...) do { no_printk(KERN_INFO fmt, ## args); } while (0) > #endif > > /* > @@ -512,7 +512,6 @@ s1d13xxxfb_bitblt_copyarea(struct fb_info *info, const struct fb_copyarea *area) > } > > /** > - * > * s1d13xxxfb_bitblt_solidfill - accelerated solidfill function > * @info : framebuffer structure > * @rect : fb_fillrect structure >
Hi Thomas. On Sun, Nov 29, 2020 at 10:59:22AM +0100, Thomas Zimmermann wrote: > > > Am 28.11.20 um 23:41 schrieb Sam Ravnborg: > > Fix following W=1 warnings: > > - Fix set but not nused variables which was used only for logging. > > s/nused/used > > s/which was/that were > > Otherwise > > Reviewed-by: Thomas Zimmermann <tzimmermann@suse.de> Fixed and applied to drm-misc-next. Thanks for the a-b's and r-b. Are you up to take a look at the remaining 24 patches? It is all simple patches so should be doable in limited time. Sam
Hi Sam Am 29.11.20 um 22:52 schrieb Sam Ravnborg: > Hi Thomas. > > On Sun, Nov 29, 2020 at 10:59:22AM +0100, Thomas Zimmermann wrote: >> >> >> Am 28.11.20 um 23:41 schrieb Sam Ravnborg: >>> Fix following W=1 warnings: >>> - Fix set but not nused variables which was used only for logging. >> >> s/nused/used >> >> s/which was/that were >> >> Otherwise >> >> Reviewed-by: Thomas Zimmermann <tzimmermann@suse.de> > > Fixed and applied to drm-misc-next. > > Thanks for the a-b's and r-b. Are you up to take a look at the remaining > 24 patches? It is all simple patches so should be doable in limited time. I think I had a question on one or two of them. If I forgot a patch, just put it into the next iteration and I'll take a look. Best regards Thomas > > Sam > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel >
diff --git a/drivers/video/fbdev/s1d13xxxfb.c b/drivers/video/fbdev/s1d13xxxfb.c index 4541afcf9386..d1b5f965bc96 100644 --- a/drivers/video/fbdev/s1d13xxxfb.c +++ b/drivers/video/fbdev/s1d13xxxfb.c @@ -45,7 +45,7 @@ #if 0 #define dbg(fmt, args...) do { printk(KERN_INFO fmt, ## args); } while(0) #else -#define dbg(fmt, args...) do { } while (0) +#define dbg(fmt, args...) do { no_printk(KERN_INFO fmt, ## args); } while (0) #endif /* @@ -512,7 +512,6 @@ s1d13xxxfb_bitblt_copyarea(struct fb_info *info, const struct fb_copyarea *area) } /** - * * s1d13xxxfb_bitblt_solidfill - accelerated solidfill function * @info : framebuffer structure * @rect : fb_fillrect structure
Fix following W=1 warnings: - Fix set but not nused variables which was used only for logging. Fixed by introducing no_printk() to trick compiler to think variables are used - Fix kernel-doc warning by deleting an empty comment line v2: - Subject updated (Lee) Signed-off-by: Sam Ravnborg <sam@ravnborg.org> Cc: Kristoffer Ericson <kristoffer.ericson@gmail.com> Cc: Lee Jones <lee.jones@linaro.org> --- drivers/video/fbdev/s1d13xxxfb.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)