| Message ID | 20201206190247.1861316-13-sam@ravnborg.org (mailing list archive) |
|---|---|
| State | Superseded, archived |
| Headers | show |
| Series | drivers/video: W=1 warning fixes | expand |
Am 06.12.20 um 20:02 schrieb Sam Ravnborg: > The controlfb driver has a number of dummy defines for IO operations. > They were introduced in commit a07a63b0e24d > ("video: fbdev: controlfb: add COMPILE_TEST support"). > > The write variants did not use their value parameter in the > dummy versions, resulting in set but not used warnings. > Fix this by adding "(void)val" to silence the compiler. > > Signed-off-by: Sam Ravnborg <sam@ravnborg.org> > Cc: Sam Ravnborg <sam@ravnborg.org> > Cc: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com> > Cc: "Gustavo A. R. Silva" <gustavoars@kernel.org> > Cc: Michael Ellerman <mpe@ellerman.id.au> Acked-by: Thomas Zimmermann <tzimmermann@suse.de> > --- > drivers/video/fbdev/controlfb.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/video/fbdev/controlfb.c b/drivers/video/fbdev/controlfb.c > index 2df56bd303d2..509311471d51 100644 > --- a/drivers/video/fbdev/controlfb.c > +++ b/drivers/video/fbdev/controlfb.c > @@ -64,9 +64,9 @@ > #undef in_le32 > #undef out_le32 > #define in_8(addr) 0 > -#define out_8(addr, val) > +#define out_8(addr, val) (void)(val) > #define in_le32(addr) 0 > -#define out_le32(addr, val) > +#define out_le32(addr, val) (void)(val) > #define pgprot_cached_wthru(prot) (prot) > #else > static void invalid_vram_cache(void __force *addr) >
diff --git a/drivers/video/fbdev/controlfb.c b/drivers/video/fbdev/controlfb.c index 2df56bd303d2..509311471d51 100644 --- a/drivers/video/fbdev/controlfb.c +++ b/drivers/video/fbdev/controlfb.c @@ -64,9 +64,9 @@ #undef in_le32 #undef out_le32 #define in_8(addr) 0 -#define out_8(addr, val) +#define out_8(addr, val) (void)(val) #define in_le32(addr) 0 -#define out_le32(addr, val) +#define out_le32(addr, val) (void)(val) #define pgprot_cached_wthru(prot) (prot) #else static void invalid_vram_cache(void __force *addr)
The controlfb driver has a number of dummy defines for IO operations. They were introduced in commit a07a63b0e24d ("video: fbdev: controlfb: add COMPILE_TEST support"). The write variants did not use their value parameter in the dummy versions, resulting in set but not used warnings. Fix this by adding "(void)val" to silence the compiler. Signed-off-by: Sam Ravnborg <sam@ravnborg.org> Cc: Sam Ravnborg <sam@ravnborg.org> Cc: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com> Cc: "Gustavo A. R. Silva" <gustavoars@kernel.org> Cc: Michael Ellerman <mpe@ellerman.id.au> --- drivers/video/fbdev/controlfb.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)