| Message ID | 20220721081655.16128-1-tzimmermann@suse.de (mailing list archive) |
|---|---|
| State | Handled Elsewhere |
| Headers | show |
| Series | fbdev: Fix order of arguments to aperture_remove_conflicting_devices() | expand |
Hello Thomas, On 7/21/22 10:16, Thomas Zimmermann wrote: > Reverse the order of the final two arguments when calling > aperture_remove_conflicting_devices(). An error report is available > at [1]. > > Reported-by: kernel test robot <lkp@intel.com> > Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de> > Fixes: 8d69d008f44c ("fbdev: Convert drivers to aperture helpers") > Cc: Thomas Zimmermann <tzimmermann@suse.de> > Cc: Javier Martinez Canillas <javierm@redhat.com> > Cc: Sudip Mukherjee <sudipm.mukherjee@gmail.com> > Cc: Teddy Wang <teddy.wang@siliconmotion.com> > Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org> > Cc: "K. Y. Srinivasan" <kys@microsoft.com> > Cc: Haiyang Zhang <haiyangz@microsoft.com> > Cc: Stephen Hemminger <sthemmin@microsoft.com> > Cc: Wei Liu <wei.liu@kernel.org> > Cc: Dexuan Cui <decui@microsoft.com> > Cc: linux-fbdev@vger.kernel.org > Cc: linux-hyperv@vger.kernel.org > Link: https://lore.kernel.org/lkml/202207202040.jS1WcTzN-lkp@intel.com/ # 1 > --- > drivers/video/fbdev/aty/radeon_base.c | 2 +- > drivers/video/fbdev/hyperv_fb.c | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/video/fbdev/aty/radeon_base.c b/drivers/video/fbdev/aty/radeon_base.c > index e5e362b8c9da..0a8199985d52 100644 > --- a/drivers/video/fbdev/aty/radeon_base.c > +++ b/drivers/video/fbdev/aty/radeon_base.c > @@ -2243,7 +2243,7 @@ static int radeon_kick_out_firmware_fb(struct pci_dev *pdev) > resource_size_t base = pci_resource_start(pdev, 0); > resource_size_t size = pci_resource_len(pdev, 0); > > - return aperture_remove_conflicting_devices(base, size, KBUILD_MODNAME, false); > + return aperture_remove_conflicting_devices(base, size, false, KBUILD_MODNAME); > } I also missed that the order wasn't correct when reviewing. Reviewed-by: Javier Martinez Canillas <javierm@redhat.com>
From: Thomas Zimmermann <tzimmermann@suse.de> Sent: Thursday, July 21, 2022 1:17 AM > > Reverse the order of the final two arguments when calling > aperture_remove_conflicting_devices(). An error report is available > at [1]. > > Reported-by: kernel test robot <lkp@intel.com> > Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de> > Fixes: 8d69d008f44c ("fbdev: Convert drivers to aperture helpers") > Cc: Thomas Zimmermann <tzimmermann@suse.de> > Cc: Javier Martinez Canillas <javierm@redhat.com> > Cc: Sudip Mukherjee <sudipm.mukherjee@gmail.com> > Cc: Teddy Wang <teddy.wang@siliconmotion.com> > Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org> > Cc: "K. Y. Srinivasan" <kys@microsoft.com> > Cc: Haiyang Zhang <haiyangz@microsoft.com> > Cc: Stephen Hemminger <sthemmin@microsoft.com> > Cc: Wei Liu <wei.liu@kernel.org> > Cc: Dexuan Cui <decui@microsoft.com> > Cc: linux-fbdev@vger.kernel.org > Cc: linux-hyperv@vger.kernel.org > Link: https://lore.kernel.org/lkml/202207202040.jS1WcTzN-lkp@intel.com/ > --- > drivers/video/fbdev/aty/radeon_base.c | 2 +- > drivers/video/fbdev/hyperv_fb.c | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/video/fbdev/aty/radeon_base.c > b/drivers/video/fbdev/aty/radeon_base.c > index e5e362b8c9da..0a8199985d52 100644 > --- a/drivers/video/fbdev/aty/radeon_base.c > +++ b/drivers/video/fbdev/aty/radeon_base.c > @@ -2243,7 +2243,7 @@ static int radeon_kick_out_firmware_fb(struct pci_dev > *pdev) > resource_size_t base = pci_resource_start(pdev, 0); > resource_size_t size = pci_resource_len(pdev, 0); > > - return aperture_remove_conflicting_devices(base, size, KBUILD_MODNAME, > false); > + return aperture_remove_conflicting_devices(base, size, false, > KBUILD_MODNAME); > } > > static int radeonfb_pci_register(struct pci_dev *pdev, > diff --git a/drivers/video/fbdev/hyperv_fb.c b/drivers/video/fbdev/hyperv_fb.c > index a944a6620527..a0e1d70b90d7 100644 > --- a/drivers/video/fbdev/hyperv_fb.c > +++ b/drivers/video/fbdev/hyperv_fb.c > @@ -1077,7 +1077,7 @@ static int hvfb_getmem(struct hv_device *hdev, struct > fb_info *info) > getmem_done: > aperture_remove_conflicting_devices(info->apertures->ranges[0].base, > info->apertures->ranges[0].size, > - KBUILD_MODNAME, false); > + false, KBUILD_MODNAME); > > if (gen2vm) { > /* framebuffer is reallocated, clear screen_info to avoid misuse from > kexec */ > -- > 2.36.1 For the Hyper-V frame buffer driver: Reviewed-by: Michael Kelley <mikelley@microsoft.com>
diff --git a/drivers/video/fbdev/aty/radeon_base.c b/drivers/video/fbdev/aty/radeon_base.c index e5e362b8c9da..0a8199985d52 100644 --- a/drivers/video/fbdev/aty/radeon_base.c +++ b/drivers/video/fbdev/aty/radeon_base.c @@ -2243,7 +2243,7 @@ static int radeon_kick_out_firmware_fb(struct pci_dev *pdev) resource_size_t base = pci_resource_start(pdev, 0); resource_size_t size = pci_resource_len(pdev, 0); - return aperture_remove_conflicting_devices(base, size, KBUILD_MODNAME, false); + return aperture_remove_conflicting_devices(base, size, false, KBUILD_MODNAME); } static int radeonfb_pci_register(struct pci_dev *pdev, diff --git a/drivers/video/fbdev/hyperv_fb.c b/drivers/video/fbdev/hyperv_fb.c index a944a6620527..a0e1d70b90d7 100644 --- a/drivers/video/fbdev/hyperv_fb.c +++ b/drivers/video/fbdev/hyperv_fb.c @@ -1077,7 +1077,7 @@ static int hvfb_getmem(struct hv_device *hdev, struct fb_info *info) getmem_done: aperture_remove_conflicting_devices(info->apertures->ranges[0].base, info->apertures->ranges[0].size, - KBUILD_MODNAME, false); + false, KBUILD_MODNAME); if (gen2vm) { /* framebuffer is reallocated, clear screen_info to avoid misuse from kexec */
Reverse the order of the final two arguments when calling aperture_remove_conflicting_devices(). An error report is available at [1]. Reported-by: kernel test robot <lkp@intel.com> Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de> Fixes: 8d69d008f44c ("fbdev: Convert drivers to aperture helpers") Cc: Thomas Zimmermann <tzimmermann@suse.de> Cc: Javier Martinez Canillas <javierm@redhat.com> Cc: Sudip Mukherjee <sudipm.mukherjee@gmail.com> Cc: Teddy Wang <teddy.wang@siliconmotion.com> Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org> Cc: "K. Y. Srinivasan" <kys@microsoft.com> Cc: Haiyang Zhang <haiyangz@microsoft.com> Cc: Stephen Hemminger <sthemmin@microsoft.com> Cc: Wei Liu <wei.liu@kernel.org> Cc: Dexuan Cui <decui@microsoft.com> Cc: linux-fbdev@vger.kernel.org Cc: linux-hyperv@vger.kernel.org Link: https://lore.kernel.org/lkml/202207202040.jS1WcTzN-lkp@intel.com/ # 1 --- drivers/video/fbdev/aty/radeon_base.c | 2 +- drivers/video/fbdev/hyperv_fb.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)