| Message ID | 20230113062339.1909087-3-hch@lst.de (mailing list archive) |
|---|---|
| State | Rejected |
| Headers | show |
| Series | [01/22] gpu/drm: remove the shmobile drm driver | expand |
On Fri, Jan 13, 2023 at 07:23:19AM +0100, Christoph Hellwig wrote: > USB_OHCI_SH is a dummy option that never builds any code, remove it. > > Signed-off-by: Christoph Hellwig <hch@lst.de> > --- > drivers/usb/host/Kconfig | 11 ----------- > 1 file changed, 11 deletions(-) > > diff --git a/drivers/usb/host/Kconfig b/drivers/usb/host/Kconfig > index 8d799d23c476e1..ca5f657c092cf4 100644 > --- a/drivers/usb/host/Kconfig > +++ b/drivers/usb/host/Kconfig > @@ -548,17 +548,6 @@ config USB_OHCI_HCD_SSB > > If unsure, say N. > > -config USB_OHCI_SH > - bool "OHCI support for SuperH USB controller (DEPRECATED)" > - depends on SUPERH || COMPILE_TEST > - select USB_OHCI_HCD_PLATFORM > - help > - This option is deprecated now and the driver was removed, use > - USB_OHCI_HCD_PLATFORM instead. > - > - Enables support for the on-chip OHCI controller on the SuperH. > - If you use the PCI OHCI controller, this option is not necessary. > - > config USB_OHCI_EXYNOS > tristate "OHCI support for Samsung S5P/Exynos SoC Series" > depends on ARCH_S5PV210 || ARCH_EXYNOS || COMPILE_TEST > -- > 2.39.0 > Do you want all of these to go through a single tree, or can they go through the different driver subsystem trees? If single: Acked-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> If not, I'll be glad to take this. thanks, greg k-h
On Fri, Jan 13, 2023 at 08:12:44AM +0100, Greg Kroah-Hartman wrote: > Do you want all of these to go through a single tree, or can they go > through the different driver subsystem trees? > > If single: > > Acked-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> > > If not, I'll be glad to take this. I think taking all the patches together would make most sense.
Hi Christoph, On Fri, Jan 13, 2023 at 7:23 AM Christoph Hellwig <hch@lst.de> wrote: > USB_OHCI_SH is a dummy option that never builds any code, remove it. > > Signed-off-by: Christoph Hellwig <hch@lst.de> Thanks for your patch! Nice catch! > --- a/drivers/usb/host/Kconfig > +++ b/drivers/usb/host/Kconfig > @@ -548,17 +548,6 @@ config USB_OHCI_HCD_SSB > > If unsure, say N. > > -config USB_OHCI_SH > - bool "OHCI support for SuperH USB controller (DEPRECATED)" > - depends on SUPERH || COMPILE_TEST > - select USB_OHCI_HCD_PLATFORM > - help > - This option is deprecated now and the driver was removed, use > - USB_OHCI_HCD_PLATFORM instead. > - > - Enables support for the on-chip OHCI controller on the SuperH. > - If you use the PCI OHCI controller, this option is not necessary. > - At this point in the series, there are still selects and enablements of USB_OHCI_SH in arch/sh/Kconfig and arch/sh/configs/sh7757lcr_defconfig. I think it would be good to replace them by USB_OHCI_HCD_PLATFORM first, to decouple the fate of this patch from the rest of the series. > config USB_OHCI_EXYNOS > tristate "OHCI support for Samsung S5P/Exynos SoC Series" > depends on ARCH_S5PV210 || ARCH_EXYNOS || COMPILE_TEST Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
On 1/13/23 01:12, Greg Kroah-Hartman wrote: > On Fri, Jan 13, 2023 at 07:23:19AM +0100, Christoph Hellwig wrote: >> USB_OHCI_SH is a dummy option that never builds any code, remove it. >> >> Signed-off-by: Christoph Hellwig <hch@lst.de> >> --- >> drivers/usb/host/Kconfig | 11 ----------- >> 1 file changed, 11 deletions(-) >> >> diff --git a/drivers/usb/host/Kconfig b/drivers/usb/host/Kconfig >> index 8d799d23c476e1..ca5f657c092cf4 100644 >> --- a/drivers/usb/host/Kconfig >> +++ b/drivers/usb/host/Kconfig >> @@ -548,17 +548,6 @@ config USB_OHCI_HCD_SSB >> >> If unsure, say N. >> >> -config USB_OHCI_SH >> - bool "OHCI support for SuperH USB controller (DEPRECATED)" >> - depends on SUPERH || COMPILE_TEST >> - select USB_OHCI_HCD_PLATFORM >> - help >> - This option is deprecated now and the driver was removed, use >> - USB_OHCI_HCD_PLATFORM instead. >> - >> - Enables support for the on-chip OHCI controller on the SuperH. >> - If you use the PCI OHCI controller, this option is not necessary. >> - >> config USB_OHCI_EXYNOS >> tristate "OHCI support for Samsung S5P/Exynos SoC Series" >> depends on ARCH_S5PV210 || ARCH_EXYNOS || COMPILE_TEST >> -- >> 2.39.0 >> > > Do you want all of these to go through a single tree, or can they go > through the different driver subsystem trees? Neither please. Multiple people are objecting. Rob
On Fri, Jan 13, 2023 at 08:12:44AM +0100, Greg Kroah-Hartman wrote: > Do you want all of these to go through a single tree, or can they go > through the different driver subsystem trees? Looks like the big removal isn't going in for this merge winodw, so can you queue this patch up after all Greg?
On Fri, Feb 03, 2023 at 08:15:42AM +0100, Christoph Hellwig wrote: > On Fri, Jan 13, 2023 at 08:12:44AM +0100, Greg Kroah-Hartman wrote: > > Do you want all of these to go through a single tree, or can they go > > through the different driver subsystem trees? > > Looks like the big removal isn't going in for this merge winodw, > so can you queue this patch up after all Greg? Sure, I'll go apply it right now, thanks. greg k-h
diff --git a/drivers/usb/host/Kconfig b/drivers/usb/host/Kconfig index 8d799d23c476e1..ca5f657c092cf4 100644 --- a/drivers/usb/host/Kconfig +++ b/drivers/usb/host/Kconfig @@ -548,17 +548,6 @@ config USB_OHCI_HCD_SSB If unsure, say N. -config USB_OHCI_SH - bool "OHCI support for SuperH USB controller (DEPRECATED)" - depends on SUPERH || COMPILE_TEST - select USB_OHCI_HCD_PLATFORM - help - This option is deprecated now and the driver was removed, use - USB_OHCI_HCD_PLATFORM instead. - - Enables support for the on-chip OHCI controller on the SuperH. - If you use the PCI OHCI controller, this option is not necessary. - config USB_OHCI_EXYNOS tristate "OHCI support for Samsung S5P/Exynos SoC Series" depends on ARCH_S5PV210 || ARCH_EXYNOS || COMPILE_TEST
USB_OHCI_SH is a dummy option that never builds any code, remove it. Signed-off-by: Christoph Hellwig <hch@lst.de> --- drivers/usb/host/Kconfig | 11 ----------- 1 file changed, 11 deletions(-)