diff mbox series

[1/3] backlight: lm3630a: add support for changing the boost frequency

Message ID 20230602-lm3630a_boost_frequency-v1-1-076472036d1a@mweigand.net (mailing list archive)
State Not Applicable
Headers show
Series backlight: lm3630a: add functionality to change boost converter frequency | expand

Commit Message

Maximilian Weigand June 14, 2023, 7:08 p.m. UTC 
From: Maximilian Weigand <mweigand@mweigand.net>

The led driver supports changing the switching frequency of the boost
converter by two means: the base switching frequency can be changed from
500 kHz to 1 MHz, and a frequency shift can be activated, leading to
switching frequencies of 560 kHz or 1.12 Mhz, respectively.

Add this functionality to the led driver by introducing two dts entries
that control the boost frequency (500 kHz by default) and the frequency
shift (no shift by default).

Signed-off-by: Maximilian Weigand <mweigand@mweigand.net>
---
 drivers/video/backlight/lm3630a_bl.c     | 9 ++++++++-
 include/linux/platform_data/lm3630a_bl.h | 5 +++++
 2 files changed, 13 insertions(+), 1 deletion(-)

Comments

Daniel Thompson June 26, 2023, 2:39 p.m. UTC | #1 
On Wed, Jun 14, 2023 at 09:08:52PM +0200, Maximilian Weigand wrote:
> From: Maximilian Weigand <mweigand@mweigand.net>
>
> The led driver supports changing the switching frequency of the boost
> converter by two means: the base switching frequency can be changed from
> 500 kHz to 1 MHz, and a frequency shift can be activated, leading to
> switching frequencies of 560 kHz or 1.12 Mhz, respectively.
>
> Add this functionality to the led driver by introducing two dts entries
> that control the boost frequency (500 kHz by default) and the frequency
> shift (no shift by default).
>
> Signed-off-by: Maximilian Weigand <mweigand@mweigand.net>

Driver changes look ok (or at least will be when the DT bindings are
finalized).

However... I think patches 1 and 2 of this series are in the wrong
order. See #5 in
https://docs.kernel.org/devicetree/bindings/submitting-patches.html
for details.


Daniel.
diff mbox series

Patch

diff --git a/drivers/video/backlight/lm3630a_bl.c b/drivers/video/backlight/lm3630a_bl.c
index d8c42acecb5d..1e8645694ab5 100644
--- a/drivers/video/backlight/lm3630a_bl.c
+++ b/drivers/video/backlight/lm3630a_bl.c
@@ -92,7 +92,7 @@  static int lm3630a_chip_init(struct lm3630a_chip *pchip)
 	/* set Cofig. register */
 	rval |= lm3630a_update(pchip, REG_CONFIG, 0x07, pdata->pwm_ctrl);
 	/* set boost control */
-	rval |= lm3630a_write(pchip, REG_BOOST, 0x38);
+	rval |= lm3630a_write(pchip, REG_BOOST, pdata->boost_ctrl);
 	/* set current A */
 	rval |= lm3630a_update(pchip, REG_I_A, 0x1F, 0x1F);
 	/* set current B */
@@ -528,6 +528,13 @@  static int lm3630a_probe(struct i2c_client *client)
 		pdata->ledb_max_brt = LM3630A_MAX_BRIGHTNESS;
 		pdata->leda_init_brt = LM3630A_MAX_BRIGHTNESS;
 		pdata->ledb_init_brt = LM3630A_MAX_BRIGHTNESS;
+		pdata->boost_ctrl = LM3630A_BOOST_CTRL_DEFAULT;
+
+		if (device_property_read_bool(pchip->dev, "ti,boost_frequency_shift"))
+			pdata->boost_ctrl |= LM3630A_BOOST_SHIFT_FREQ;
+
+		if (device_property_read_bool(pchip->dev, "ti,boost_use_1mhz"))
+			pdata->boost_ctrl |= LM3630A_BOOST_USE_1MHZ;
 
 		rval = lm3630a_parse_node(pchip, pdata);
 		if (rval) {
diff --git a/include/linux/platform_data/lm3630a_bl.h b/include/linux/platform_data/lm3630a_bl.h
index 530be9318711..fb5ffb906dcf 100644
--- a/include/linux/platform_data/lm3630a_bl.h
+++ b/include/linux/platform_data/lm3630a_bl.h
@@ -33,6 +33,9 @@  enum lm3630a_ledb_ctrl {
 };
 
 #define LM3630A_MAX_BRIGHTNESS 255
+#define LM3630A_BOOST_CTRL_DEFAULT 0x38
+#define LM3630A_BOOST_USE_1MHZ BIT(0)
+#define LM3630A_BOOST_SHIFT_FREQ BIT(1)
 /*
  *@leda_label    : optional led a label.
  *@leda_init_brt : led a init brightness. 4~255
@@ -44,6 +47,7 @@  enum lm3630a_ledb_ctrl {
  *@ledb_ctrl     : led b disable, enable linear, enable exponential
  *@pwm_period    : pwm period
  *@pwm_ctrl      : pwm disable, bank a or b, active high or low
+ *@boost_ctrl    : boost converter control
  */
 struct lm3630a_platform_data {
 
@@ -60,6 +64,7 @@  struct lm3630a_platform_data {
 	/* pwm config. */
 	unsigned int pwm_period;
 	enum lm3630a_pwm_ctrl pwm_ctrl;
+	unsigned int boost_ctrl;
 };
 
 #endif /* __LINUX_LM3630A_H */