| Message ID | 20230612141352.29939-22-tzimmermann@suse.de (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | fbdev: Make userspace interfaces optional | expand |
Hi Thomas, On Mon, Jun 12, 2023 at 04:07:59PM +0200, Thomas Zimmermann wrote: > The driver's backlight code requires the framebuffer to be > registered. Therefore reorder the cleanup calls for both data > structures. The init calls are already in the correct order. > > Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de> > Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org> > Reviewed-by: Javier Martinez Canillas <javierm@redhat.com> > --- > drivers/video/fbdev/aty/radeon_base.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/video/fbdev/aty/radeon_base.c b/drivers/video/fbdev/aty/radeon_base.c > index 972c4bbedfa36..8f2a527c26ebf 100644 > --- a/drivers/video/fbdev/aty/radeon_base.c > +++ b/drivers/video/fbdev/aty/radeon_base.c > @@ -2517,9 +2517,8 @@ static void radeonfb_pci_unregister(struct pci_dev *pdev) > > del_timer_sync(&rinfo->lvds_timer); > arch_phys_wc_del(rinfo->wc_cookie); > - unregister_framebuffer(info); > - > radeonfb_bl_exit(rinfo); > + unregister_framebuffer(info); > > iounmap(rinfo->mmio_base); > iounmap(rinfo->fb_base); The mix of spaces and tabs for indent looks strange in the diff. Consider to use the style of the surrounding code if you are going to refresh the patch-set. Sam
diff --git a/drivers/video/fbdev/aty/radeon_base.c b/drivers/video/fbdev/aty/radeon_base.c index 972c4bbedfa36..8f2a527c26ebf 100644 --- a/drivers/video/fbdev/aty/radeon_base.c +++ b/drivers/video/fbdev/aty/radeon_base.c @@ -2517,9 +2517,8 @@ static void radeonfb_pci_unregister(struct pci_dev *pdev) del_timer_sync(&rinfo->lvds_timer); arch_phys_wc_del(rinfo->wc_cookie); - unregister_framebuffer(info); - radeonfb_bl_exit(rinfo); + unregister_framebuffer(info); iounmap(rinfo->mmio_base); iounmap(rinfo->fb_base);